Mailing List Archive: Wikipedia: Wikitech

includes/filerepo/FileRepo.php?&r1=35096&r2=35095&pathrev=35096

Index | Next | Previous | View Threaded

jschulz_4587 at msn

May 21, 2008, 11:38 AM

Post #1 of 3 (151 views)
Permalink

includes/filerepo/FileRepo.php?&r1=35096&r2=35095&pathrev=35096

Why is there a $time parameter there? Doesn't seem to be used.

Also, $titles looses the ones that are matched. That probably should be
documented, since a caller wouldn't expect that most likely.
--
View this message in context: http://www.nabble.com/includes-filerepo-FileRepo.php--r1%3D35096-r2%3D35095-pathrev%3D35096-tp17367662p17367662.html
Sent from the Wikipedia Developers mailing list archive at Nabble.com.

_______________________________________________
Wikitech-l mailing list
Wikitech-l[at]lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

jschulz_4587 at msn

May 21, 2008, 11:39 AM

Post #2 of 3 (142 views)
Permalink

Re: includes/filerepo/FileRepo.php?&r1=35096&r2=35095&pathrev=35096 [In reply to]

http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/filerepo/FileRepo.php?sortby=date&r1=35096&r2=35095&pathrev=35096
handy link

Voice of All wrote:
>
> Why is there a $time parameter there? Doesn't seem to be used.
>
> Also, $titles looses the ones that are matched. That probably should be
> documented, since a caller wouldn't expect that most likely.
>
--
View this message in context: http://www.nabble.com/includes-filerepo-FileRepo.php--r1%3D35096-r2%3D35095-pathrev%3D35096-tp17367662p17367663.html
Sent from the Wikipedia Developers mailing list archive at Nabble.com.

_______________________________________________
Wikitech-l mailing list
Wikitech-l[at]lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

bryan.tongminh at gmail

May 23, 2008, 12:08 PM

Post #3 of 3 (133 views)
Permalink

Re: includes/filerepo/FileRepo.php?&r1=35096&r2=35095&pathrev=35096 [In reply to]

On Wed, May 21, 2008 at 8:38 PM, Voice of All <jschulz_4587[at]msn.com> wrote:
>
> Why is there a $time parameter there? Doesn't seem to be used.
>
Either because I forgot to implement it or because I forgot to remove
the parameter when copying the function call. Do we need it?

> Also, $titles looses the ones that are matched. That probably should be
> documented, since a caller wouldn't expect that most likely.

Agree.

Bryan

> http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/filerepo/FileRepo.php?sortby=date&r1=35096&r2=35095&pathrev=35096

_______________________________________________
Wikitech-l mailing list
Wikitech-l[at]lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact lists@gossamer-threads.com