Mailing List Archive: Wikipedia: Wikitech

Re: [MediaWiki-CVS] SVN: [34906] trunk

Index | Next | Previous | View Threaded

brion at wikimedia

May 17, 2008, 8:42 AM

Post #1 of 2 (74 views)
Permalink

Re: [MediaWiki-CVS] SVN: [34906] trunk

aaron[at]svn.wikimedia.org wrote:
> * number on success and dies horribly on failure.
> *
> * @param Database $dbw
> + * @param bool $edit, was this a new edit? (optional)
> * @return int
> */
> - public function insertOn( &$dbw ) {
> + public function insertOn( &$dbw, $edit=false ) {

I gotta admit I really don't like this; Revision::insertOn() is a very
low-level function, which isn't really a good place to trip high-level
stuff like "I made an edit".

-- brion vibber (brion @ wikimedia.org)

_______________________________________________
Wikitech-l mailing list
Wikitech-l[at]lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

jschulz_4587 at msn

May 17, 2008, 10:50 AM

Post #2 of 2 (69 views)
Permalink

Re: [MediaWiki-CVS] SVN: [34906] trunk [In reply to]

Yeah, I'll commit a new higher level hook soon.

Brion Vibber-3 wrote:
>
> aaron[at]svn.wikimedia.org wrote:
>> * number on success and dies horribly on failure.
>> *
>> * @param Database $dbw
>> + * @param bool $edit, was this a new edit? (optional)
>> * @return int
>> */
>> - public function insertOn( &$dbw ) {
>> + public function insertOn( &$dbw, $edit=false ) {
>
>
> I gotta admit I really don't like this; Revision::insertOn() is a very
> low-level function, which isn't really a good place to trip high-level
> stuff like "I made an edit".
>
> -- brion vibber (brion @ wikimedia.org)
>
> _______________________________________________
> Wikitech-l mailing list
> Wikitech-l[at]lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>
>

--
View this message in context: http://www.nabble.com/Re%3A--MediaWiki-CVS--SVN%3A---34906--trunk-tp17293121p17294473.html
Sent from the Wikipedia Developers mailing list archive at Nabble.com.

_______________________________________________
Wikitech-l mailing list
Wikitech-l[at]lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact lists@gossamer-threads.com