Mailing List Archive: Wikipedia: Wikitech

Re: [MediaWiki-CVS] SVN: [34832] trunk/phase3/includes/RecentChange.php

Index | Next | Previous | View Threaded

greg at endpoint

May 14, 2008, 5:37 PM

Post #1 of 3 (125 views)
Permalink

Re: [MediaWiki-CVS] SVN: [34832] trunk/phase3/includes/RecentChange.php

> revert r34818 -- bad
.
> - 'rc_cur_id' => $action === 'delete' ?
> 0 : $target->getArticleID(),
> + 'rc_cur_id' => $title->getArticleID(),

Is there a better place/way to do this? Since the page doesn't exist, it
seems pointless to store the no-longer-existing page_id. It also throws
an error on those DBs using foreign keys, which is how I found it. Thanks.

--
Greg Sabino Mullane greg[at]endpoint.com
End Point Corporation 610-983-9073

Attachments:

signature.asc (0.16 KB)

brion at wikimedia

May 15, 2008, 8:40 AM

Post #2 of 3 (114 views)
Permalink

Re: [MediaWiki-CVS] SVN: [34832] trunk/phase3/includes/RecentChange.php [In reply to]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Greg Sabino Mullane wrote:
>> revert r34818 -- bad
> .
>> - 'rc_cur_id' => $action === 'delete' ?
>> 0 : $target->getArticleID(),
>> + 'rc_cur_id' => $title->getArticleID(),
>
> Is there a better place/way to do this? Since the page doesn't exist, it
> seems pointless to store the no-longer-existing page_id. It also throws
> an error on those DBs using foreign keys, which is how I found it. Thanks.

They key problem is that $target doesn't exist there, so it caused a
fatal error on every page edit.

- -- brion vibber (brion @ wikimedia.org)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.8 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkgsWYMACgkQwRnhpk1wk47yzwCcD+oDO9nbwCpa/xTZWQpvYl/Q
6AcAoMNnQout08r+hGTtWLo/W/bpr0Zy
=deI7
-----END PGP SIGNATURE-----

_______________________________________________
Wikitech-l mailing list
Wikitech-l[at]lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

greg at endpoint

May 15, 2008, 9:23 AM

Post #3 of 3 (112 views)
Permalink

Re: [MediaWiki-CVS] SVN: [34832] trunk/phase3/includes/RecentChange.php [In reply to]

> They key problem is that $target doesn't exist there, so it caused a
> fatal error on every page edit.

D'oh! So I presume title-> would be okay then. Thanks.

Note to self: Use patchfiles, even if it's just one line.

--
Greg Sabino Mullane greg[at]endpoint.com

Attachments:

signature.asc (0.16 KB)

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact lists@gossamer-threads.com