Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Wikipedia: Wikitech

Re: [MediaWiki-CVS] SVN: [34358] trunk/extensions/CentralAuth

 

 

Wikipedia wikitech RSS feed   Index | Next | Previous | View Threaded


brion at wikimedia

May 7, 2008, 11:01 AM

Post #1 of 5 (355 views)
Permalink
Re: [MediaWiki-CVS] SVN: [34358] trunk/extensions/CentralAuth

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

tstarling [at] svn wrote:
> Revision: 34358
> Author: tstarling
> Date: 2008-05-07 06:43:58 +0000 (Wed, 07 May 2008)

This breaks the site. Overloads the central DB. Reverted.

- -- brion
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.8 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkgh7mgACgkQwRnhpk1wk45/SACfXsY3c9JdWINT+1J7lOIRzG5n
O4YAnRQ2xUDISSAP2Atx1pzntEfn1K+I
=Qbd6
-----END PGP SIGNATURE-----

_______________________________________________
Wikitech-l mailing list
Wikitech-l [at] lists
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


brion at wikimedia

May 7, 2008, 11:19 AM

Post #2 of 5 (325 views)
Permalink
Re: [MediaWiki-CVS] SVN: [34358] trunk/extensions/CentralAuth [In reply to]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Brion Vibber wrote:
> tstarling [at] svn wrote:
>> Revision: 34358
>> Author: tstarling
>> Date: 2008-05-07 06:43:58 +0000 (Wed, 07 May 2008)
>
> This breaks the site. Overloads the central DB. Reverted.


Detail: the s3 master (carrying centralauth DB) was stuffed with these reqs:

SELECT /* Database::safeQuery */ gu_id, lu_dbname, gu_salt,
gu_password,gu_auth_token,

[.sorry, cut off as I didn't do a SHOW FULL PROCESSLIST]


We were getting reports of a lot of "too many connections" errors on
various wikis, mostly from people who *were* logged in but *not* with a
merged account. With a merged account, or anonymous, I didn't seem to be
having any problems.


It looks like something was triggering a lot of extra lookups, which
perhaps aren't getting properly cached.

- -- brion vibber (brion @ wikimedia.org)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.8 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkgh8r0ACgkQwRnhpk1wk45HCgCeLGpzm6hxNLVi5iGEs+UyWZHt
tNIAnjemHeRFwzXATOyBPD1I701CEClf
=xQTp
-----END PGP SIGNATURE-----

_______________________________________________
Wikitech-l mailing list
Wikitech-l [at] lists
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


pathoschild at gmail

May 7, 2008, 11:25 AM

Post #3 of 5 (325 views)
Permalink
Re: [MediaWiki-CVS] SVN: [34358] trunk/extensions/CentralAuth [In reply to]

Brion Vibber <brion [at] wikimedia> wrote:
> With a merged account, or anonymous, I didn't seem to be
> having any problems.

I was getting these errors on various wikis (en.wikisource,
en.wikipedia, and wikimediafoundation) with a merged account.

--
Yours cordially,
Jesse Plamondon-Willard (Pathoschild)

_______________________________________________
Wikitech-l mailing list
Wikitech-l [at] lists
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


andrew at epstone

May 8, 2008, 6:00 AM

Post #4 of 5 (318 views)
Permalink
Re: [MediaWiki-CVS] SVN: [34358] trunk/extensions/CentralAuth [In reply to]

On Thu, May 8, 2008 at 4:19 AM, Brion Vibber <brion [at] wikimedia> wrote:
> Detail: the s3 master (carrying centralauth DB) was stuffed with these reqs:
>
> SELECT /* Database::safeQuery */ gu_id, lu_dbname, gu_salt,
> gu_password,gu_auth_token,
>
> [.sorry, cut off as I didn't do a SHOW FULL PROCESSLIST]
>
>
> We were getting reports of a lot of "too many connections" errors on
> various wikis, mostly from people who *were* logged in but *not* with a
> merged account. With a merged account, or anonymous, I didn't seem to be
> having any problems.
>
>
> It looks like something was triggering a lot of extra lookups, which
> perhaps aren't getting properly cached.
>

I investigated this problem. Full details at [1].

Executive summary: resetState() is called from saveToCache if we don't
have fresh data from the master (i.e. if $this->mFromMaster is not
true). Unfortunately, if no row is found, that variable is not set to
true, whereas it is if a row IS found. I've put a patch for this
problem at the below link, which fixes it on my wiki. It's always the
one-liners ;-)

[1] https://secure.wikimedia.org/wikipedia/mediawiki/wiki/User:Werdna/CentralAuth_investigation

--
Andrew Garrett

_______________________________________________
Wikitech-l mailing list
Wikitech-l [at] lists
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


andrew at epstone

May 8, 2008, 6:02 AM

Post #5 of 5 (319 views)
Permalink
Re: [MediaWiki-CVS] SVN: [34358] trunk/extensions/CentralAuth [In reply to]

On Thu, May 8, 2008 at 11:00 PM, Andrew Garrett <andrew [at] epstone> wrote:
> Executive summary: resetState() is called from saveToCache if we don't
> have fresh data from the master (i.e. if $this->mFromMaster is not
> true). Unfortunately, if no row is found, that variable is not set to
> true, whereas it is if a row IS found.

Forgot to mention: As saveToCache() also calls loadState() to get
fresh data if it's stale, we end up with an infinite loop if browsing
with an unmerged account. Quite unfun.

--
Andrew Garrett

_______________________________________________
Wikitech-l mailing list
Wikitech-l [at] lists
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Wikipedia wikitech RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.