gerrit at wikimedia
Aug 12, 2013, 12:37 AM
Post #2 of 2
(2 views)
Permalink
|
|
[MediaWiki-commits] [Gerrit] Link dynamically with librdkafka - change (operations...varnishkafka)
[In reply to]
|
|
Faidon has submitted this change and it was merged.
Change subject: Link dynamically with librdkafka
......................................................................
Link dynamically with librdkafka
Don't link statically with librdkafka.
Change-Id: I2eac5b60981236d204ef4770152ee67b6f8a7400
---
M Makefile
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Faidon: Verified; Looks good to me, approved
Edenhill: Looks good to me, but someone else must approve
diff --git a/Makefile b/Makefile
index 7594c3d..3152458 100644
--- a/Makefile
+++ b/Makefile
@@ -18,9 +18,7 @@
CFLAGS += -DVARNISHKAFKA_CONF_PATH=\"$(CFPATH)\"
CFLAGS += -Wall -Werror -O2 -g
-# Link librdkafka statically for now.
-LIBS += -Wl,-Bstatic -lrdkafka -Wl,-Bdynamic
-LIBS += -lvarnishapi -lpthread
+LIBS += -lrdkafka -lvarnishapi -lpthread
all:
--
To view, visit https://gerrit.wikimedia.org/r/78780
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2eac5b60981236d204ef4770152ee67b6f8a7400
Gerrit-PatchSet: 1
Gerrit-Project: operations/software/varnish/varnishkafka
Gerrit-Branch: master
Gerrit-Owner: Faidon <faidon [at] wikimedia>
Gerrit-Reviewer: Edenhill <magnus [at] edenhill>
Gerrit-Reviewer: Faidon <faidon [at] wikimedia>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits [at] lists
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
|
