Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Wikipedia: Mediawiki-CVS

[MediaWiki-commits] [Gerrit] Fix Bug 39829 - Language Selection does not work while using... - change (mediawiki...UniversalLanguageSelector[master])

 

 

Wikipedia mediawiki-cvs RSS feed   Index | Next | Previous | View Threaded


gerrit at wikimedia

Sep 3, 2012, 2:06 AM

Post #1 of 2 (36 views)
Permalink
[MediaWiki-commits] [Gerrit] Fix Bug 39829 - Language Selection does not work while using... - change (mediawiki...UniversalLanguageSelector[master])

Santhosh has uploaded a new change for review.

Change subject: Fix Bug 39829 - Language Selection does not work while using Language Code
......................................................................

Fix Bug 39829 - Language Selection does not work while using Language Code

This happens when you type language code and hit enter very fast, without
a pause. A matched language is not available when enter is hit, so it goes
noop.

Handled this special case by checking whether the input is a valid language
code and calling onselect on it.

Change-Id: Icaf809f8db8162264d990247a164449b02b2f418
---
M lib/jquery.uls/src/jquery.uls.languagefilter.js
1 file changed, 9 insertions(+), 1 deletion(-)


git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector refs/changes/38/22438/1
--
To view, visit https://gerrit.wikimedia.org/r/22438
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icaf809f8db8162264d990247a164449b02b2f418
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Santhosh <santhosh.thottingal [at] gmail>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits [at] lists
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


gerrit at wikimedia

Sep 3, 2012, 9:35 AM

Post #2 of 2 (31 views)
Permalink
[MediaWiki-commits] [Gerrit] Fix Bug 39829 - Language Selection does not work while using... - change (mediawiki...UniversalLanguageSelector[master]) [In reply to]

Siebrand has submitted this change and it was merged.

Change subject: Fix Bug 39829 - Language Selection does not work while using Language Code
......................................................................


Fix Bug 39829 - Language Selection does not work while using Language Code

This happens when you type language code and hit enter very fast, without
a pause. A matched language is not available when enter is hit, so it goes
noop.

Handled this special case by checking whether the input is a valid language
code and calling onselect on it.

Change-Id: Icaf809f8db8162264d990247a164449b02b2f418
---
M lib/jquery.uls/src/jquery.uls.languagefilter.js
1 file changed, 9 insertions(+), 1 deletion(-)

Approvals:
Siebrand: Looks good to me, approved
Logicwiki: Verified


--
To view, visit https://gerrit.wikimedia.org/r/22438
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icaf809f8db8162264d990247a164449b02b2f418
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Santhosh <santhosh.thottingal [at] gmail>
Gerrit-Reviewer: Amire80 <amir.aharoni [at] mail>
Gerrit-Reviewer: Logicwiki <srik.lak [at] gmail>
Gerrit-Reviewer: Nikerabbit <niklas.laxstrom [at] gmail>
Gerrit-Reviewer: Santhosh <santhosh.thottingal [at] gmail>
Gerrit-Reviewer: Siebrand <siebrand [at] wikimedia>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits [at] lists
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Wikipedia mediawiki-cvs RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.