aaron at svn
Aug 22, 2008, 2:36 AM
Post #1 of 1
(75 views)
Permalink
|
|
SVN: [39818] trunk/extensions/FlaggedRevs/FlaggedArticle.php
|
|
Revision: 39818
Author: aaron
Date: 2008-08-22 09:36:37 +0000 (Fri, 22 Aug 2008)
Log Message:
-----------
* Fix previous commit: only do this for diffs
* Tone down some UI
Modified Paths:
--------------
trunk/extensions/FlaggedRevs/FlaggedArticle.php
Modified: trunk/extensions/FlaggedRevs/FlaggedArticle.php
===================================================================
--- trunk/extensions/FlaggedRevs/FlaggedArticle.php 2008-08-22 09:33:19 UTC (rev 39817)
+++ trunk/extensions/FlaggedRevs/FlaggedArticle.php 2008-08-22 09:36:37 UTC (rev 39818)
@@ -662,7 +662,8 @@
*/
public function addReviewForm( &$data ) {
global $wgRequest, $wgUser, $wgOut;
- if( !$this->parent->exists() || !$this->isReviewable() ) {
+ # User must have review rights
+ if( !$wgUser->isAllowed('review') || !$this->parent->exists() || !$this->isReviewable() ) {
return true;
}
# Check action and if page is protected
@@ -670,10 +671,7 @@
if( ($action !='view' && $action !='purge') || !$this->parent->getTitle()->quickUserCan('edit') ) {
return true;
}
- # User must have review rights
- if( $wgUser->isAllowed( 'review' ) ) {
- $this->addQuickReview( $data, (bool)$wgRequest->getVal( 'diff'), !$this->getStableRev() );
- }
+ $this->addQuickReview( $data, $wgRequest->getVal('diff'), $wgRequest->getVal('diff') && !$this->getStableRev() );
return true;
}
@@ -1342,10 +1340,9 @@
$form .= Xml::openElement( 'fieldset', array('class' => 'flaggedrevs_reviewform noprint') );
$form .= "<legend><strong>" . wfMsgHtml( 'revreview-flag', $id ) . "</strong></legend>\n";
- if( FlaggedRevs::showStableByDefault() ) {
- $form .= wfMsgExt( 'revreview-text', array('parse') );
- } else {
- $form .= wfMsgExt( 'revreview-text2', array('parse') );
+ if( !FlaggedRevs::lowProfileUI() ) {
+ $msg = FlaggedRevs::showStableByDefault() ? 'revreview-text' : 'revreview-text2';
+ $form .= wfMsgExt( $msg, array('parse') );
}
# Current user has too few rights to change at least one flag, thus entire form disabled
_______________________________________________
MediaWiki-CVS mailing list
MediaWiki-CVS [at] lists
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
|
