brion at svn
Jul 27, 2008, 10:44 PM
Post #1 of 1
(48 views)
Permalink
|
|
SVN: [38122] trunk/phase3
|
|
Revision: 38122
Author: brion
Date: 2008-07-28 05:44:18 +0000 (Mon, 28 Jul 2008)
Log Message:
-----------
Revert r38068 "SpecialMovepageBeforeMove hook from Wikia codebase - allows extensions, such as spamRegex, to interfere with page moving"
This passes a MovePageForm, which seems unwise. It won't apply to the edit API, and generally seems like a weak interface -- an internal UI object is passed instead of specific information, leaving it unstable to future changes.
Modified Paths:
--------------
trunk/phase3/RELEASE-NOTES
trunk/phase3/docs/hooks.txt
trunk/phase3/includes/specials/SpecialMovepage.php
Modified: trunk/phase3/RELEASE-NOTES
===================================================================
--- trunk/phase3/RELEASE-NOTES 2008-07-28 05:31:12 UTC (rev 38121)
+++ trunk/phase3/RELEASE-NOTES 2008-07-28 05:44:18 UTC (rev 38122)
@@ -28,8 +28,6 @@
* (bug 8068) New __INDEX__ and __NOINDEX__ magic words allow user control of
search engine indexing on a per-article basis.
-* Added SpecialMovepageBeforeMove hook to allow extensions to interfere with
- page moves (useful for blacklist-type extensions, for example)
=== Bug fixes in 1.14 ===
Modified: trunk/phase3/docs/hooks.txt
===================================================================
--- trunk/phase3/docs/hooks.txt 2008-07-28 05:31:12 UTC (rev 38121)
+++ trunk/phase3/docs/hooks.txt 2008-07-28 05:44:18 UTC (rev 38122)
@@ -1131,9 +1131,6 @@
$oldTitle: old title (object)
$newTitle: new title (object)
-'SpecialMovepageBeforeMove': Called before moving a page
-&$movePage: MovePageForm object
-
'SpecialPageExecuteAfterPage': called after executing a special page
Warning: Not all the special pages call this hook
$specialPage: SpecialPage object
Modified: trunk/phase3/includes/specials/SpecialMovepage.php
===================================================================
--- trunk/phase3/includes/specials/SpecialMovepage.php 2008-07-28 05:31:12 UTC (rev 38121)
+++ trunk/phase3/includes/specials/SpecialMovepage.php 2008-07-28 05:44:18 UTC (rev 38122)
@@ -264,10 +264,6 @@
return;
}
- if( ! wfRunHooks( 'SpecialMovepageBeforeMove', array(&$this) ) ) {
- return;
- }
-
$ot = $this->oldTitle;
$nt = $this->newTitle;
_______________________________________________
MediaWiki-CVS mailing list
MediaWiki-CVS[at]lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
|
