brion at svn
Jul 27, 2008, 10:31 PM
Post #1 of 1
(71 views)
Permalink
|
|
SVN: [38121] trunk/phase3
|
|
Revision: 38121
Author: brion
Date: 2008-07-28 05:31:12 +0000 (Mon, 28 Jul 2008)
Log Message:
-----------
Revert r38040 "new hook, ConfirmEmailComplete"
This hook is incomplete and won't work as advertised. Will fail to run when the email address is confirmed through other means, such as a password reset; also there's no corresponding hook for when the mail gets *un*confirmed, so would lead to inconsistent state.
Modified Paths:
--------------
trunk/phase3/RELEASE-NOTES
trunk/phase3/docs/hooks.txt
trunk/phase3/includes/specials/SpecialConfirmemail.php
Modified: trunk/phase3/RELEASE-NOTES
===================================================================
--- trunk/phase3/RELEASE-NOTES 2008-07-28 05:25:25 UTC (rev 38120)
+++ trunk/phase3/RELEASE-NOTES 2008-07-28 05:31:12 UTC (rev 38121)
@@ -28,8 +28,6 @@
* (bug 8068) New __INDEX__ and __NOINDEX__ magic words allow user control of
search engine indexing on a per-article basis.
-* Added ConfirmEmailComplete hook to allow extensions to perform actions
- depending on if the user's email is confirmed or not
* Added SpecialMovepageBeforeMove hook to allow extensions to interfere with
page moves (useful for blacklist-type extensions, for example)
Modified: trunk/phase3/docs/hooks.txt
===================================================================
--- trunk/phase3/docs/hooks.txt 2008-07-28 05:25:25 UTC (rev 38120)
+++ trunk/phase3/docs/hooks.txt 2008-07-28 05:31:12 UTC (rev 38121)
@@ -502,9 +502,6 @@
$unpatrolled: Whether or not we are showing unpatrolled changes.
$watched: Whether or not the change is watched by the user.
-'ConfirmEmailComplete': Called after a user's email has been confirmed successfully
-&$user: user (object) whose email is being confirmed
-
'ContribsPager::getQueryInfo': Before the contributions query is about to run
&$pager: Pager object for contributions
&queryInfo: The query for the contribs Pager
Modified: trunk/phase3/includes/specials/SpecialConfirmemail.php
===================================================================
--- trunk/phase3/includes/specials/SpecialConfirmemail.php 2008-07-28 05:25:25 UTC (rev 38120)
+++ trunk/phase3/includes/specials/SpecialConfirmemail.php 2008-07-28 05:31:12 UTC (rev 38121)
@@ -92,7 +92,6 @@
$title = SpecialPage::getTitleFor( 'Userlogin' );
$wgOut->returnToMain( true, $title );
}
- wfRunHooks( 'ConfirmEmailComplete', array( &$user ) );
} else {
$wgOut->addWikiMsg( 'confirmemail_invalid' );
}
_______________________________________________
MediaWiki-CVS mailing list
MediaWiki-CVS [at] lists
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
|
