greg at svn
Jul 17, 2008, 8:46 PM
Post #1 of 1
(65 views)
Permalink
|
|
SVN: [37809] trunk/phase3/maintenance/postgres/compare_schemas.pl
|
|
Revision: 37809
Author: greg
Date: 2008-07-18 03:46:39 +0000 (Fri, 18 Jul 2008)
Log Message:
-----------
Handle new includes directory scheme.
Modified Paths:
--------------
trunk/phase3/maintenance/postgres/compare_schemas.pl
Modified: trunk/phase3/maintenance/postgres/compare_schemas.pl
===================================================================
--- trunk/phase3/maintenance/postgres/compare_schemas.pl 2008-07-18 03:29:40 UTC (rev 37808)
+++ trunk/phase3/maintenance/postgres/compare_schemas.pl 2008-07-18 03:46:39 UTC (rev 37809)
@@ -162,7 +162,7 @@
updatelog
';
-## Make sure all tables in main tables.sql are accounted for int the parsertest.
+## Make sure all tables in main tables.sql are accounted for in the parsertest.
for my $table (sort keys %{$old{'../tables.sql'}}) {
$ptable{$table}++;
next if $ptable{$table} > 2;
@@ -483,12 +483,48 @@
}
close $fh or die qq{Could not close "$file": $!\n};
}
+ rewinddir $dh;
+ for my $subdir (grep { -d "$dir/$_" and ! /\./ } readdir $dh) {
+ print "Entering directory $subdir\n";
+ opendir my $dh, "$dir/$subdir" or die qq{Could not opendir "$dir/$subdir": $!\n};
+ scan_dir("$dir/$subdir" => $dh);
+ closedir $dh;
+ }
closedir $dh or die qq{Closedir failed?!\n};
return;
} ## end of check_includes_dir
+sub scan_dir {
+
+ my ($dir, $dh) = @_;
+
+ for my $file (grep { -f "$dir/$_" and /\.php$/ } readdir $dh) {
+ $file = "$dir/$file";
+ open my $fh, '<', $file or die qq{Could not open "$file": $!\n};
+ while (<$fh>) {
+ if (/FORCE INDEX/ and $file !~ /Database\w*\.php/) {
+ warn "Found FORCE INDEX string at line $. of $file\n";
+ }
+ if (/REPLACE INTO/ and $file !~ /Database\w*\.php/) {
+ warn "Found REPLACE INTO string at line $. of $file\n";
+ }
+ if (/\bIF\s*\(/ and $file !~ /DatabaseMySQL\.php/) {
+ warn "Found IF string at line $. of $file\n";
+ }
+ if (/\bCONCAT\b/ and $file !~ /Database\w*\.php/) {
+ warn "Found CONCAT string at line $. of $file\n";
+ }
+ }
+ close $fh or die qq{Could not close "$file": $!\n};
+ }
+
+ return;
+
+} ## end of scan_dir
+
+
__DATA__
## Known exceptions
OLD: searchindex ## We use tsearch2 directly on the page table instead
_______________________________________________
MediaWiki-CVS mailing list
MediaWiki-CVS[at]lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
|
