minuteelectron at svn
May 11, 2008, 10:31 AM
Post #1 of 1
(11 views)
Permalink
|
|
SVN: [34622] trunk/phase3/includes/SpecialUpload.php
|
|
Revision: 34622
Author: minuteelectron
Date: 2008-05-11 17:31:38 +0000 (Sun, 11 May 2008)
Log Message:
-----------
Avoid possible register_globals issue.
Modified Paths:
--------------
trunk/phase3/includes/SpecialUpload.php
Modified: trunk/phase3/includes/SpecialUpload.php
===================================================================
--- trunk/phase3/includes/SpecialUpload.php 2008-05-11 17:28:51 UTC (rev 34621)
+++ trunk/phase3/includes/SpecialUpload.php 2008-05-11 17:31:38 UTC (rev 34622)
@@ -900,6 +900,11 @@
$useAjaxDestCheck = $wgUseAjax && $wgAjaxUploadDestCheck;
$useAjaxLicensePreview = $wgUseAjax && $wgAjaxLicensePreview;
+ // Initilaize $extensionList here in case it is not set later on
+ // (which would cause a E_NOTICE) and it must not be set only if it
+ // isn't set to avoid a possible register_globals issue.
+ $extensionList = '';
+
$adc = wfBoolToStr( $useAjaxDestCheck );
$alp = wfBoolToStr( $useAjaxLicensePreview );
$autofill = wfBoolToStr( $this->mDesiredDestName == '' );
@@ -1059,10 +1064,6 @@
$encComment = htmlspecialchars( $this->mComment );
- if( !isset( $extensionsList ) ) {
- $extensionsList = '';
- }
-
$wgOut->addHTML(
Xml::openElement( 'form', array( 'method' => 'post', 'action' => $titleObj->getLocalURL(),
'enctype' => 'multipart/form-data', 'id' => 'mw-upload-form' ) ) .
_______________________________________________
MediaWiki-CVS mailing list
MediaWiki-CVS[at]lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
|
