Mailing List Archive: vpnc: devel

svn commit: vpnc r457 - /trunk/vpnc.c

Index | Next | Previous | View Threaded

vpnc at unix-ag

Jan 27, 2011, 10:04 AM

Post #1 of 6 (933 views)
Permalink

svn commit: vpnc r457 - /trunk/vpnc.c

Author: Maurice Massar
Date: Thu Jan 27 19:04:50 2011
New Revision: 457

Log:
fix dpd, broken in r452

Modified:
trunk/vpnc.c

Modified: trunk/vpnc.c
==============================================================================
--- trunk/vpnc.c (original)
+++ trunk/vpnc.c Thu Jan 27 19:04:50 2011
@@ -742,7 +742,7 @@
memcpy(pl->u.n.spi + ISAKMP_COOKIE_LENGTH * 1, s->ike.r_cookie, ISAKMP_COOKIE_LENGTH);
pl->u.n.data_length = 4;
pl->u.n.data = xallocc(4);
- *((uint32_t *) pl->u.n.data) = seqno;
+ *((uint32_t *) pl->u.n.data) = htonl(seqno);
gcry_create_nonce((uint8_t *) & msgid, sizeof(msgid));
/* 2007-09-06 JKU/ZID: Sonicwall drops non hashed r_u_there-requests */
sendrecv_phase2(s, pl, ISAKMP_EXCHANGE_INFORMATIONAL, msgid,

_______________________________________________
vpnc-devel mailing list
vpnc-devel [at] unix-ag
https://lists.unix-ag.uni-kl.de/mailman/listinfo/vpnc-devel
http://www.unix-ag.uni-kl.de/~massar/vpnc/

mmokrejs at fold

Jan 27, 2011, 1:34 PM

Post #2 of 6 (897 views)
Permalink

Re: svn commit: vpnc r457 - /trunk/vpnc.c [In reply to]

Yes, it is much better behaving now for me. ;) Thanks!
Martin

vpnc [at] unix-ag wrote:
> Author: Maurice Massar
> Date: Thu Jan 27 19:04:50 2011
> New Revision: 457
>
> Log:
> fix dpd, broken in r452
>
> Modified:
> trunk/vpnc.c
>
> Modified: trunk/vpnc.c
> ==============================================================================
> --- trunk/vpnc.c (original)
> +++ trunk/vpnc.c Thu Jan 27 19:04:50 2011
> @@ -742,7 +742,7 @@
> memcpy(pl->u.n.spi + ISAKMP_COOKIE_LENGTH * 1, s->ike.r_cookie, ISAKMP_COOKIE_LENGTH);
> pl->u.n.data_length = 4;
> pl->u.n.data = xallocc(4);
> - *((uint32_t *) pl->u.n.data) = seqno;
> + *((uint32_t *) pl->u.n.data) = htonl(seqno);
> gcry_create_nonce((uint8_t *) & msgid, sizeof(msgid));
> /* 2007-09-06 JKU/ZID: Sonicwall drops non hashed r_u_there-requests */
> sendrecv_phase2(s, pl, ISAKMP_EXCHANGE_INFORMATIONAL, msgid,

_______________________________________________
vpnc-devel mailing list
vpnc-devel [at] unix-ag
https://lists.unix-ag.uni-kl.de/mailman/listinfo/vpnc-devel
http://www.unix-ag.uni-kl.de/~massar/vpnc/

mmokrejs at fold

Jan 27, 2011, 2:39 PM

Post #3 of 6 (897 views)
Permalink

Re: svn commit: vpnc r457 - /trunk/vpnc.c [In reply to]

Martin Mokrejs wrote:
> Yes, it is much better behaving now for me. ;) Thanks!

The connection still exits after some while but let me stress out
the patch 457 really helped. Nevertheless, current log is at
http://fold.natur.cuni.cz/~mmokrejs/vpnc.log_r457

M.

> Martin
>
> vpnc [at] unix-ag wrote:
>> Author: Maurice Massar
>> Date: Thu Jan 27 19:04:50 2011
>> New Revision: 457
>>
>> Log:
>> fix dpd, broken in r452
>>
>> Modified:
>> trunk/vpnc.c
>>
>> Modified: trunk/vpnc.c
>> ==============================================================================
>> --- trunk/vpnc.c (original)
>> +++ trunk/vpnc.c Thu Jan 27 19:04:50 2011
>> @@ -742,7 +742,7 @@
>> memcpy(pl->u.n.spi + ISAKMP_COOKIE_LENGTH * 1, s->ike.r_cookie, ISAKMP_COOKIE_LENGTH);
>> pl->u.n.data_length = 4;
>> pl->u.n.data = xallocc(4);
>> - *((uint32_t *) pl->u.n.data) = seqno;
>> + *((uint32_t *) pl->u.n.data) = htonl(seqno);
>> gcry_create_nonce((uint8_t *) & msgid, sizeof(msgid));
>> /* 2007-09-06 JKU/ZID: Sonicwall drops non hashed r_u_there-requests */
>> sendrecv_phase2(s, pl, ISAKMP_EXCHANGE_INFORMATIONAL, msgid,
_______________________________________________
vpnc-devel mailing list
vpnc-devel [at] unix-ag
https://lists.unix-ag.uni-kl.de/mailman/listinfo/vpnc-devel
http://www.unix-ag.uni-kl.de/~massar/vpnc/

jmvpnc at loplof

Mar 8, 2011, 1:22 PM

Post #4 of 6 (807 views)
Permalink

Re: svn commit: vpnc r457 - /trunk/vpnc.c [In reply to]

On Thu, Jan 27, 2011 at 11:39:17PM +0100, Martin Mokrejs wrote:
> Martin Mokrejs wrote:
> > Yes, it is much better behaving now for me. ;) Thanks!
>
> The connection still exits after some while but let me stress out
> the patch 457 really helped. Nevertheless, current log is at
> http://fold.natur.cuni.cz/~mmokrejs/vpnc.log_r457

A short look didn't reveal anything obvious, no idea when we'll find
the time to give it a detailed look.
One question though: Did the original patch fix the problem completely
and it's only the checked in version that has this problem?

Ciao
JÃ¶rg

--
Joerg Mayer <jmayer [at] loplof>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.
_______________________________________________
vpnc-devel mailing list
vpnc-devel [at] unix-ag
https://lists.unix-ag.uni-kl.de/mailman/listinfo/vpnc-devel
http://www.unix-ag.uni-kl.de/~massar/vpnc/

mmokrejs at fold

Mar 8, 2011, 1:37 PM

Post #5 of 6 (805 views)
Permalink

Re: svn commit: vpnc r457 - /trunk/vpnc.c [In reply to]

Hi Joerg,
thanks for looking into this again ... I posted that only if somebody
would find why I have connection drops after an hour or so. I do NOT
have the problem like with version r454 or so anymore.

Joerg Mayer wrote:
> On Thu, Jan 27, 2011 at 11:39:17PM +0100, Martin Mokrejs wrote:
>> Martin Mokrejs wrote:
>>> Yes, it is much better behaving now for me. ;) Thanks!
>>
>> The connection still exits after some while but let me stress out
>> the patch 457 really helped. Nevertheless, current log is at
>> http://fold.natur.cuni.cz/~mmokrejs/vpnc.log_r457
>
> A short look didn't reveal anything obvious, no idea when we'll find
> the time to give it a detailed look.
> One question though: Did the original patch fix the problem completely
> and it's only the checked in version that has this problem?

No, both "work" for me, that means I do not get dropped connection after
few dozens of seconds or minutes but after about an hour. So, with r457
things work for me in the same way as before r452 if I remember right
the number. The r457 was somehow necessary only for me on x86-32bit
and once again, for me behaves same like r451 (or earlier).

BTW:
I am somewhat failing to disable dpd timeout with this line in /etc/vpnc/default

DPD idle timeout 0

I even tried on a commandline "vpnc --dpd-idle 0" but no improvement.
I think I saw vpnc complaining about unknown configuration variable,
is that because of the spaces? Once I manage this i think will have
a stable connection like others have with "DPD disabled". ;)

Best,
Martin

_______________________________________________
vpnc-devel mailing list
vpnc-devel [at] unix-ag
https://lists.unix-ag.uni-kl.de/mailman/listinfo/vpnc-devel
http://www.unix-ag.uni-kl.de/~massar/vpnc/

ljakab at ac

Mar 8, 2011, 2:01 PM

Post #6 of 6 (805 views)
Permalink

Re: svn commit: vpnc r457 - /trunk/vpnc.c [In reply to]

On 03/08/2011 10:37 PM, Martin Mokrejs wrote:
> BTW:
> I am somewhat failing to disable dpd timeout with this line in /etc/vpnc/default
>
> DPD idle timeout 0

I think the correct option is:
DPD idle timeout (our side) 0

-Lori
_______________________________________________
vpnc-devel mailing list
vpnc-devel [at] unix-ag
https://lists.unix-ag.uni-kl.de/mailman/listinfo/vpnc-devel
http://www.unix-ag.uni-kl.de/~massar/vpnc/

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads