Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: vpnc: devel

Patch: default case for switch

 

 

vpnc devel RSS feed   Index | Next | Previous | View Threaded


borneo.antonio at gmail

Dec 25, 2008, 7:15 AM

Post #1 of 1 (774 views)
Permalink
Patch: default case for switch

Hi,
in config.c, function do_config(), there is a loop to check if any
empty config field needs to be filled by user, e.g. password,
username.
The first switch{} does not have a default target, and the rest of the
loop will process also unnecessary cases.
Luckily, this does not provide any "bad" behaviour, but just execution
of useless code.

The patch in attachment adds the default case, skipping the rest of
the iteration.
The same patch can be applied either to vpnc-nortel branch and to
trunk (in latter case with a warning).

Merry Christmas,
Antonio Borneo
Attachments: patch_switch_default.txt (0.30 KB)

vpnc devel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.