Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Varnish: Dev

Varnishapi patches

 

 

Varnish dev RSS feed   Index | Next | Previous | View Threaded


martin at varnish-software

May 13, 2013, 5:44 AM

Post #1 of 5 (156 views)
Permalink
Varnishapi patches

Please find attached patch set for the first parts of new libvarnishapi

Regards,
Martin Blix Grydeland

--
<http://varnish-software.com>*Martin Blix Grydeland*
Senior Developer | Varnish Software AS
Cell: +47 21 98 92 60
We Make Websites Fly!
Attachments: varnishapi.tar.gz (86.5 KB)


dridi.boukelmoune at zenika

May 17, 2013, 12:01 PM

Post #2 of 5 (134 views)
Permalink
Re: Varnishapi patches [In reply to]

Hi,

Those patches have been committed in the master if I'm not mistaken.
I've read a lot of it but at some point it became way beyond my
understanding/knowledge of Varnish internals. Anyway, with the current
master (e16233fd332) varnishd dies (SIGHUP) when I run varnishtest in
verbose mode.

I'm replying here because I remember seeing something about the logs,
varnishlog and varnishtest a some point(s), so I thought it might be
related.

** v1 0.7 as expected: cache_hit (2) == 2
* top 0.7 RESETTING after src/tests/regfilter01_regfilter_in_vcl_hash.vtc
** s1 0.7 Waiting for server
**** s1 0.7 macro undef s1_addr
**** s1 0.7 macro undef s1_port
**** s1 0.7 macro undef s1_sock
**** v1 0.7 macro undef v1_addr
**** v1 0.7 macro undef v1_port
**** v1 0.7 macro undef v1_sock
** v1 0.7 Stop
**** v1 0.7 CLI TX| stop
*** v1 0.7 debug| Stopping Child\n
**** v1 0.7 vsl| 0 CLI - EOF on CLI
connection, worker stops
*** v1 1.7 debug| Child (13868) died status=1\n
*** v1 1.7 debug| Child (13868) said Child dies\n
*** v1 1.7 debug| Child cleanup complete\n
*** v1 1.7 CLI RX 200

It happens at the very end of the test after the last assertion.

Best Regards,
Dridi


On Mon, May 13, 2013 at 2:44 PM, Martin Blix Grydeland
<martin [at] varnish-software> wrote:
>
> Please find attached patch set for the first parts of new libvarnishapi
>
> Regards,
> Martin Blix Grydeland
>
> --
> Martin Blix Grydeland
> Senior Developer | Varnish Software AS
> Cell: +47 21 98 92 60
> We Make Websites Fly!
>
> _______________________________________________
> varnish-dev mailing list
> varnish-dev [at] varnish-cache
> https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev

_______________________________________________
varnish-dev mailing list
varnish-dev [at] varnish-cache
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev


martin at varnish-software

May 21, 2013, 2:19 AM

Post #3 of 5 (132 views)
Permalink
Re: Varnishapi patches [In reply to]

Hi Dridi,

Looking at the varnishtest output attached, that looks completely normal to
me, and the expected behavior. None of those lines indicate an error
condition. When a varnishtest test case ends, it will always stop the
varnishd instance before exiting, which is what the log lines you see
describe. Please elaborate on what problems you are experiencing, and why
you believe this is a problem.

Regards,
Martin Blix Grydeland


On 17 May 2013 21:01, Dridi Boukelmoune <dridi.boukelmoune [at] zenika>wrote:

> Hi,
>
> Those patches have been committed in the master if I'm not mistaken.
> I've read a lot of it but at some point it became way beyond my
> understanding/knowledge of Varnish internals. Anyway, with the current
> master (e16233fd332) varnishd dies (SIGHUP) when I run varnishtest in
> verbose mode.
>
> I'm replying here because I remember seeing something about the logs,
> varnishlog and varnishtest a some point(s), so I thought it might be
> related.
>
> ** v1 0.7 as expected: cache_hit (2) == 2
> * top 0.7 RESETTING after
> src/tests/regfilter01_regfilter_in_vcl_hash.vtc
> ** s1 0.7 Waiting for server
> **** s1 0.7 macro undef s1_addr
> **** s1 0.7 macro undef s1_port
> **** s1 0.7 macro undef s1_sock
> **** v1 0.7 macro undef v1_addr
> **** v1 0.7 macro undef v1_port
> **** v1 0.7 macro undef v1_sock
> ** v1 0.7 Stop
> **** v1 0.7 CLI TX| stop
> *** v1 0.7 debug| Stopping Child\n
> **** v1 0.7 vsl| 0 CLI - EOF on CLI
> connection, worker stops
> *** v1 1.7 debug| Child (13868) died status=1\n
> *** v1 1.7 debug| Child (13868) said Child dies\n
> *** v1 1.7 debug| Child cleanup complete\n
> *** v1 1.7 CLI RX 200
>
> It happens at the very end of the test after the last assertion.
>
> Best Regards,
> Dridi
>
>
> On Mon, May 13, 2013 at 2:44 PM, Martin Blix Grydeland
> <martin [at] varnish-software> wrote:
> >
> > Please find attached patch set for the first parts of new libvarnishapi
> >
> > Regards,
> > Martin Blix Grydeland
> >
> > --
> > Martin Blix Grydeland
> > Senior Developer | Varnish Software AS
> > Cell: +47 21 98 92 60
> > We Make Websites Fly!
> >
> > _______________________________________________
> > varnish-dev mailing list
> > varnish-dev [at] varnish-cache
> > https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev
>



--
<http://varnish-software.com>*Martin Blix Grydeland*
Senior Developer | Varnish Software AS
Cell: +47 21 98 92 60
We Make Websites Fly!


dridi.boukelmoune at zenika

May 21, 2013, 2:53 AM

Post #4 of 5 (132 views)
Permalink
Re: Varnishapi patches [In reply to]

Hi,

This wasn't actually brought by your patches, I've tried to rewind to
the previous commit I was building my module against and had the same
problem.

I can't test this until tonight, but I'll dig in my memory instead:
- varnishtest has become very slow on the master branch, like a second
slower per test. I know this is unrelated but it had to be said :p

- I'm used to grep "varnishtest -v" output, but I wrote the previous
mail after failing to grep and having varnishtest's ouput in stderr
instead. So I assumed there was an error (I don't remember myself
checking the exit status).

I hope this helps.

Best Regards,
Dridi

On Tue, May 21, 2013 at 11:19 AM, Martin Blix Grydeland
<martin [at] varnish-software> wrote:
>
> Hi Dridi,
>
> Looking at the varnishtest output attached, that looks completely normal to me, and the expected behavior. None of those lines indicate an error condition. When a varnishtest test case ends, it will always stop the varnishd instance before exiting, which is what the log lines you see describe. Please elaborate on what problems you are experiencing, and why you believe this is a problem.
>
> Regards,
> Martin Blix Grydeland
>
>
> On 17 May 2013 21:01, Dridi Boukelmoune <dridi.boukelmoune [at] zenika> wrote:
>>
>> Hi,
>>
>> Those patches have been committed in the master if I'm not mistaken.
>> I've read a lot of it but at some point it became way beyond my
>> understanding/knowledge of Varnish internals. Anyway, with the current
>> master (e16233fd332) varnishd dies (SIGHUP) when I run varnishtest in
>> verbose mode.
>>
>> I'm replying here because I remember seeing something about the logs,
>> varnishlog and varnishtest a some point(s), so I thought it might be
>> related.
>>
>> ** v1 0.7 as expected: cache_hit (2) == 2
>> * top 0.7 RESETTING after src/tests/regfilter01_regfilter_in_vcl_hash.vtc
>> ** s1 0.7 Waiting for server
>> **** s1 0.7 macro undef s1_addr
>> **** s1 0.7 macro undef s1_port
>> **** s1 0.7 macro undef s1_sock
>> **** v1 0.7 macro undef v1_addr
>> **** v1 0.7 macro undef v1_port
>> **** v1 0.7 macro undef v1_sock
>> ** v1 0.7 Stop
>> **** v1 0.7 CLI TX| stop
>> *** v1 0.7 debug| Stopping Child\n
>> **** v1 0.7 vsl| 0 CLI - EOF on CLI
>> connection, worker stops
>> *** v1 1.7 debug| Child (13868) died status=1\n
>> *** v1 1.7 debug| Child (13868) said Child dies\n
>> *** v1 1.7 debug| Child cleanup complete\n
>> *** v1 1.7 CLI RX 200
>>
>> It happens at the very end of the test after the last assertion.
>>
>> Best Regards,
>> Dridi
>>
>>
>> On Mon, May 13, 2013 at 2:44 PM, Martin Blix Grydeland
>> <martin [at] varnish-software> wrote:
>> >
>> > Please find attached patch set for the first parts of new libvarnishapi
>> >
>> > Regards,
>> > Martin Blix Grydeland
>> >
>> > --
>> > Martin Blix Grydeland
>> > Senior Developer | Varnish Software AS
>> > Cell: +47 21 98 92 60
>> > We Make Websites Fly!
>> >
>> > _______________________________________________
>> > varnish-dev mailing list
>> > varnish-dev [at] varnish-cache
>> > https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev
>
>
>
>
> --
> Martin Blix Grydeland
> Senior Developer | Varnish Software AS
> Cell: +47 21 98 92 60
> We Make Websites Fly!

_______________________________________________
varnish-dev mailing list
varnish-dev [at] varnish-cache
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev


dridi.boukelmoune at zenika

May 23, 2013, 4:44 AM

Post #5 of 5 (127 views)
Permalink
Re: Varnishapi patches [In reply to]

Hi Martin,

I did some tests regarding this non-issue, and I can't reproduce it. I
came back to my source directory and launched the same exact
commands ("varnishtest | grep" from my bash history) and it worked.

I haven't touched anything in my source tree or my varnish clone, so
I'm clueless. I've also tested a non verbose varnishtest execution with
an error in the test case, and it writes to stdout, so I can't explain why
the output ended up in my tty instead of grep's stdin.

Sorry for the disturbance,
Dridi

On Tue, May 21, 2013 at 11:53 AM, Dridi Boukelmoune
<dridi.boukelmoune [at] zenika> wrote:
> Hi,
>
> This wasn't actually brought by your patches, I've tried to rewind to
> the previous commit I was building my module against and had the same
> problem.
>
> I can't test this until tonight, but I'll dig in my memory instead:
> - varnishtest has become very slow on the master branch, like a second
> slower per test. I know this is unrelated but it had to be said :p
>
> - I'm used to grep "varnishtest -v" output, but I wrote the previous
> mail after failing to grep and having varnishtest's ouput in stderr
> instead. So I assumed there was an error (I don't remember myself
> checking the exit status).
>
> I hope this helps.
>
> Best Regards,
> Dridi
>
> On Tue, May 21, 2013 at 11:19 AM, Martin Blix Grydeland
> <martin [at] varnish-software> wrote:
>>
>> Hi Dridi,
>>
>> Looking at the varnishtest output attached, that looks completely normal to me, and the expected behavior. None of those lines indicate an error condition. When a varnishtest test case ends, it will always stop the varnishd instance before exiting, which is what the log lines you see describe. Please elaborate on what problems you are experiencing, and why you believe this is a problem.
>>
>> Regards,
>> Martin Blix Grydeland
>>
>>
>> On 17 May 2013 21:01, Dridi Boukelmoune <dridi.boukelmoune [at] zenika> wrote:
>>>
>>> Hi,
>>>
>>> Those patches have been committed in the master if I'm not mistaken.
>>> I've read a lot of it but at some point it became way beyond my
>>> understanding/knowledge of Varnish internals. Anyway, with the current
>>> master (e16233fd332) varnishd dies (SIGHUP) when I run varnishtest in
>>> verbose mode.
>>>
>>> I'm replying here because I remember seeing something about the logs,
>>> varnishlog and varnishtest a some point(s), so I thought it might be
>>> related.
>>>
>>> ** v1 0.7 as expected: cache_hit (2) == 2
>>> * top 0.7 RESETTING after src/tests/regfilter01_regfilter_in_vcl_hash.vtc
>>> ** s1 0.7 Waiting for server
>>> **** s1 0.7 macro undef s1_addr
>>> **** s1 0.7 macro undef s1_port
>>> **** s1 0.7 macro undef s1_sock
>>> **** v1 0.7 macro undef v1_addr
>>> **** v1 0.7 macro undef v1_port
>>> **** v1 0.7 macro undef v1_sock
>>> ** v1 0.7 Stop
>>> **** v1 0.7 CLI TX| stop
>>> *** v1 0.7 debug| Stopping Child\n
>>> **** v1 0.7 vsl| 0 CLI - EOF on CLI
>>> connection, worker stops
>>> *** v1 1.7 debug| Child (13868) died status=1\n
>>> *** v1 1.7 debug| Child (13868) said Child dies\n
>>> *** v1 1.7 debug| Child cleanup complete\n
>>> *** v1 1.7 CLI RX 200
>>>
>>> It happens at the very end of the test after the last assertion.
>>>
>>> Best Regards,
>>> Dridi
>>>
>>>
>>> On Mon, May 13, 2013 at 2:44 PM, Martin Blix Grydeland
>>> <martin [at] varnish-software> wrote:
>>> >
>>> > Please find attached patch set for the first parts of new libvarnishapi
>>> >
>>> > Regards,
>>> > Martin Blix Grydeland
>>> >
>>> > --
>>> > Martin Blix Grydeland
>>> > Senior Developer | Varnish Software AS
>>> > Cell: +47 21 98 92 60
>>> > We Make Websites Fly!
>>> >
>>> > _______________________________________________
>>> > varnish-dev mailing list
>>> > varnish-dev [at] varnish-cache
>>> > https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev
>>
>>
>>
>>
>> --
>> Martin Blix Grydeland
>> Senior Developer | Varnish Software AS
>> Cell: +47 21 98 92 60
>> We Make Websites Fly!

_______________________________________________
varnish-dev mailing list
varnish-dev [at] varnish-cache
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev

Varnish dev RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.