Mailing List Archive: Varnish: Dev

[PATCH] support for multiple -o arguments to varnish tools

Index | Next | Previous | View Threaded

tfheen at varnish-software

Apr 27, 2011, 1:32 AM

Post #1 of 2 (273 views)
Permalink

[PATCH] support for multiple -o arguments to varnish tools

The following patch allows multiple -o arguments to varnishlog,
varnishncsa, varnishhist and varnishsizes. The format is -o tag:regex
which will only count a transaction if it matches all the -o
parameters.

Feedback is most welcome, in particular I wonder if -o is a good choice
or if we should go with -m(atch) or somtheing similar. -o is also
somewhat confusing since some people think it means -o(r)

Comments on the implementation is welcome too, of course.

Regards,

Attachments:

multiple_o_support.diff (19.2 KB)

phk at phk

Apr 27, 2011, 1:46 AM

Post #2 of 2 (251 views)
Permalink

Re: [PATCH] support for multiple -o arguments to varnish tools [In reply to]

In message <87aafct7qa.fsf [at] qurzaw>, Tollef Fog Heen writes
:

>The following patch allows multiple -o arguments to varnishlog,

Just for the record:

I take a pretty hands-off attitude to the OaM tools,
varnish{log,stat,hist,...}, because I know even less about what people
need from these than from varnishd.

I have some code-quality and overall structure concerns, but with respect
to what the tools do and how they do it, It's up to the community to
figure things out.

So please give Tollefs patch a spin and give him some feedback.

--
Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
phk [at] FreeBSD | TCP/IP since RFC 956
FreeBSD committer | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.

_______________________________________________
varnish-dev mailing list
varnish-dev [at] varnish-cache
http://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads