phk at varnish-cache
Jul 30, 2012, 9:35 AM
Post #1 of 1
(50 views)
Permalink
|
|
[master] ffa30f0 Change our chosen "bad_ip" to 192.0.2.255 which is a broadcast address from RFC5737's TEST-NET-1 and put a comment there to explain.
|
|
commit ffa30f0490d6e2b59204757ddbdc7f032d64ce3a
Author: Poul-Henning Kamp <phk [at] FreeBSD>
Date: Mon Jul 30 16:33:48 2012 +0000
Change our chosen "bad_ip" to 192.0.2.255 which is a broadcast address
from RFC5737's TEST-NET-1 and put a comment there to explain.
I fear this is a loosing battle, but at least this is more "official"
than the previous "10.255.255.255" choice.
Fixes #1159
diff --git a/bin/varnishtest/vtc.c b/bin/varnishtest/vtc.c
index 99cf840..a2c0571 100644
--- a/bin/varnishtest/vtc.c
+++ b/bin/varnishtest/vtc.c
@@ -563,7 +563,15 @@ exec_file(const char *fn, const char *script, const char *tmpdir,
cwd = getcwd(NULL, PATH_MAX);
macro_def(vltop, NULL, "pwd", "%s", cwd);
macro_def(vltop, NULL, "topbuild", "%s/%s", cwd, TOP_BUILDDIR);
- macro_def(vltop, NULL, "bad_ip", "10.255.255.255");
+
+ /*
+ * We need an IP number which will not repond, ever, and that is a
+ * lot harder than it sounds. This IP# is from RFC5737 and a
+ * C-class broadcast at that.
+ * If tests involving ${bad_ip} fails and you run linux, you should
+ * check your /proc/sys/net/ipv4/ip_nonlocal_bind setting.
+ */
+ macro_def(vltop, NULL, "bad_ip", "192.0.2.255");
/* Move into our tmpdir */
AZ(chdir(tmpdir));
_______________________________________________
varnish-commit mailing list
varnish-commit [at] varnish-cache
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-commit
|
