Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Varnish: Bugs

#1184: Assert error in vfp_esi_bytes_gg

 

 

Varnish bugs RSS feed   Index | Next | Previous | View Threaded


varnish-bugs at varnish-cache

Aug 7, 2012, 2:09 PM

Post #1 of 7 (431 views)
Permalink
#1184: Assert error in vfp_esi_bytes_gg

#1184: Assert error in vfp_esi_bytes_gg
-----------------------------+----------------------
Reporter: dbakerflight | Type: defect
Status: new | Priority: high
Milestone: Varnish 3.0 dev | Component: build
Version: trunk | Severity: critical
Keywords: |
-----------------------------+----------------------
We have been experiencing frequent crashes of varnishd on FreeBSD 9 with
this assert error. The problem remains in 3.0.3rc1


Aug 6 01:17:04 rokit varnishd[59107]: Child (57104) Panic message: Assert
error in vfp_esi_bytes_gg(), cache_esi_fetch.c line 274: Condition(i >=
VGZ_OK) not true. thread = (cache-worker) ident =
FreeBSD,9.0-RELEASE,amd64,-smalloc,-smalloc,-hclassic,kqueue
Aug 6 20:48:03 rokit varnishd[19405]: Child (19406) Panic message: Assert
error in vfp_esi_bytes_gg(), cache_esi_fetch.c line 274: Condition(i >=
VGZ_OK) not true. thread = (cache-worker) ident =
FreeBSD,9.0-RELEASE,amd64,-smalloc,-smalloc,-hclassic,kqueue
Aug 7 20:50:33 rokit varnishd[19405]: Child (30531) Panic message: Assert
error in vfp_esi_bytes_gg(), cache_esi_fetch.c line 274: Condition(i >=
VGZ_OK) not true. thread = (cache-worker) ident =
FreeBSD,9.0-RELEASE,amd64,-smalloc,-smalloc,-hclassic,kqueue

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1184>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs [at] varnish-cache
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs


varnish-bugs at varnish-cache

Aug 7, 2012, 2:27 PM

Post #2 of 7 (415 views)
Permalink
Re: #1184: Assert error in vfp_esi_bytes_gg [In reply to]

#1184: Assert error in vfp_esi_bytes_gg
--------------------------+------------------------------
Reporter: dbakerflight | Owner:
Type: defect | Status: new
Priority: high | Milestone: Varnish 3.0 dev
Component: build | Version: trunk
Severity: critical | Resolution:
Keywords: |
--------------------------+------------------------------

Comment (by dbakerflight):

Relevant code:


{{{
VGZ_Obuf(sp->wrk->vgz_rx, ibuf2, sizeof ibuf2);
i = VGZ_Gunzip(sp->wrk->vgz_rx, &dp, &dl);
/* XXX: check i */
assert(i >= VGZ_OK);
}}}

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1184#comment:1>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs [at] varnish-cache
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs


varnish-bugs at varnish-cache

Aug 7, 2012, 11:55 PM

Post #3 of 7 (414 views)
Permalink
Re: #1184: Assert error in vfp_esi_bytes_gg [In reply to]

#1184: Assert error in vfp_esi_bytes_gg
--------------------------+------------------------------
Reporter: dbakerflight | Owner:
Type: defect | Status: new
Priority: high | Milestone: Varnish 3.0 dev
Component: build | Version: trunk
Severity: critical | Resolution:
Keywords: |
--------------------------+------------------------------
Description changed by phk:

Old description:

> We have been experiencing frequent crashes of varnishd on FreeBSD 9 with
> this assert error. The problem remains in 3.0.3rc1
>

> Aug 6 01:17:04 rokit varnishd[59107]: Child (57104) Panic message:
> Assert error in vfp_esi_bytes_gg(), cache_esi_fetch.c line 274:
> Condition(i >= VGZ_OK) not true. thread = (cache-worker) ident =
> FreeBSD,9.0-RELEASE,amd64,-smalloc,-smalloc,-hclassic,kqueue
> Aug 6 20:48:03 rokit varnishd[19405]: Child (19406) Panic message:
> Assert error in vfp_esi_bytes_gg(), cache_esi_fetch.c line 274:
> Condition(i >= VGZ_OK) not true. thread = (cache-worker) ident =
> FreeBSD,9.0-RELEASE,amd64,-smalloc,-smalloc,-hclassic,kqueue
> Aug 7 20:50:33 rokit varnishd[19405]: Child (30531) Panic message:
> Assert error in vfp_esi_bytes_gg(), cache_esi_fetch.c line 274:
> Condition(i >= VGZ_OK) not true. thread = (cache-worker) ident =
> FreeBSD,9.0-RELEASE,amd64,-smalloc,-smalloc,-hclassic,kqueue

New description:

We have been experiencing frequent crashes of varnishd on FreeBSD 9 with
this assert error. The problem remains in 3.0.3rc1

{{{
Aug 6 01:17:04 rokit varnishd[59107]: Child (57104) Panic message: Assert
error in vfp_esi_bytes_gg(), cache_esi_fetch.c line 274: Condition(i >=
VGZ_OK) not true. thread = (cache-worker) ident =
FreeBSD,9.0-RELEASE,amd64,-smalloc,-smalloc,-hclassic,kqueue
Aug 6 20:48:03 rokit varnishd[19405]: Child (19406) Panic message: Assert
error in vfp_esi_bytes_gg(), cache_esi_fetch.c line 274: Condition(i >=
VGZ_OK) not true. thread = (cache-worker) ident =
FreeBSD,9.0-RELEASE,amd64,-smalloc,-smalloc,-hclassic,kqueue
Aug 7 20:50:33 rokit varnishd[19405]: Child (30531) Panic message: Assert
error in vfp_esi_bytes_gg(), cache_esi_fetch.c line 274: Condition(i >=
VGZ_OK) not true. thread = (cache-worker) ident =
FreeBSD,9.0-RELEASE,amd64,-smalloc,-smalloc,-hclassic,kqueue
}}}

--

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1184#comment:2>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs [at] varnish-cache
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs


varnish-bugs at varnish-cache

Aug 9, 2012, 9:00 AM

Post #4 of 7 (418 views)
Permalink
Re: #1184: Assert error in vfp_esi_bytes_gg [In reply to]

#1184: Assert error in vfp_esi_bytes_gg
--------------------------+------------------------------
Reporter: dbakerflight | Owner:
Type: defect | Status: new
Priority: high | Milestone: Varnish 3.0 dev
Component: build | Version: trunk
Severity: critical | Resolution:
Keywords: |
--------------------------+------------------------------

Comment (by dbakerflight):

We applied this patch and are not seeing any more crashes:

{{{
--- cache_esi_fetch.c.orig 2012-08-07 21:28:47.724109347 +0000
+++ cache_esi_fetch.c 2012-08-07 21:39:32.301109679 +0000
@@ -271,6 +271,9 @@
VGZ_Obuf(sp->wrk->vgz_rx, ibuf2, sizeof ibuf2);
i = VGZ_Gunzip(sp->wrk->vgz_rx, &dp, &dl);
/* XXX: check i */
+if (i < VGZ_OK) {
+ return -1;
+}
assert(i >= VGZ_OK);
vef->bufp = ibuf2;
if (dl > 0)

}}}

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1184#comment:3>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs [at] varnish-cache
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs


varnish-bugs at varnish-cache

Aug 13, 2012, 3:46 AM

Post #5 of 7 (411 views)
Permalink
Re: #1184: Assert error in vfp_esi_bytes_gg [In reply to]

#1184: Assert error in vfp_esi_bytes_gg
--------------------------+------------------------------
Reporter: dbakerflight | Owner: phk
Type: defect | Status: new
Priority: high | Milestone: Varnish 3.0 dev
Component: build | Version: trunk
Severity: critical | Resolution:
Keywords: |
--------------------------+------------------------------
Changes (by phk):

* owner: => phk


--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1184#comment:4>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs [at] varnish-cache
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs


varnish-bugs at varnish-cache

Aug 21, 2012, 1:20 AM

Post #6 of 7 (395 views)
Permalink
Re: #1184: Assert error in vfp_esi_bytes_gg [In reply to]

#1184: Assert error in vfp_esi_bytes_gg
--------------------------+------------------------------
Reporter: dbakerflight | Owner: phk
Type: defect | Status: new
Priority: high | Milestone: Varnish 3.0 dev
Component: build | Version: trunk
Severity: critical | Resolution:
Keywords: |
--------------------------+------------------------------

Comment (by Poul-Henning Kamp <phk@…>):

In [7c784d5c9d2dd959a5ea1a1bea5f7bbb4173437d]:
{{{
#!CommitTicketReference repository=""
revision="7c784d5c9d2dd959a5ea1a1bea5f7bbb4173437d"
Add long time missing error handling of gunzip'ing fetched objects
for ESI processing.

Polish the VGZ code a bit while here anyway.

Fixes #1184
}}}

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1184#comment:5>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs [at] varnish-cache
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs


varnish-bugs at varnish-cache

Aug 21, 2012, 1:20 AM

Post #7 of 7 (393 views)
Permalink
Re: #1184: Assert error in vfp_esi_bytes_gg [In reply to]

#1184: Assert error in vfp_esi_bytes_gg
--------------------------+------------------------------
Reporter: dbakerflight | Owner: phk
Type: defect | Status: closed
Priority: high | Milestone: Varnish 3.0 dev
Component: build | Version: trunk
Severity: critical | Resolution: fixed
Keywords: |
--------------------------+------------------------------
Changes (by Poul-Henning Kamp <phk@…>):

* status: new => closed
* resolution: => fixed


Comment:

(In [7c784d5c9d2dd959a5ea1a1bea5f7bbb4173437d]) Add long time missing
error handling of gunzip'ing fetched objects
for ESI processing.

Polish the VGZ code a bit while here anyway.

Fixes #1184

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1184#comment:6>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs [at] varnish-cache
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs

Varnish bugs RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.