Mailing List Archive: Varnish: Bugs

#1146: Persistent: When dropping empty segments, it will leak objects from LRU_Alloc, and not reset the free_offset to reclaim the space

Index | Next | Previous | View Threaded

varnish-bugs at varnish-cache

Jun 3, 2012, 2:49 PM

Post #1 of 3 (139 views)
Permalink

#1146: Persistent: When dropping empty segments, it will leak objects from LRU_Alloc, and not reset the free_offset to reclaim the space

#1146: Persistent: When dropping empty segments, it will leak objects from
LRU_Alloc, and not reset the free_offset to reclaim the space
----------------------+-----------------------------------------------------
Reporter: martin | Owner:
Type: defect | Status: new
Priority: normal | Milestone:
Component: varnishd | Version: 3.0.2
Severity: normal | Keywords:
----------------------+-----------------------------------------------------
The optimization in smp_close_seg() does not free the LRU object, and does
not reset the free_offset so that the space this segment held can be
reclaimed.

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1146>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs [at] varnish-cache
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs

varnish-bugs at varnish-cache

Oct 10, 2012, 12:49 AM

Post #2 of 3 (88 views)
Permalink

Re: #1146: Persistent: When dropping empty segments, it will leak objects from LRU_Alloc, and not reset the free_offset to reclaim the space [In reply to]

#1146: Persistent: When dropping empty segments, it will leak objects from
LRU_Alloc, and not reset the free_offset to reclaim the space
----------------------+--------------------
Reporter: martin | Owner:
Type: defect | Status: new
Priority: normal | Milestone:
Component: varnishd | Version: 3.0.2
Severity: normal | Resolution:
Keywords: |
----------------------+--------------------

Comment (by Martin Blix Grydeland <martin@…>):

In [c74c457414847d5a1a56894fd9797ce2e4d2e208]:
{{{
#!CommitTicketReference repository=""
revision="c74c457414847d5a1a56894fd9797ce2e4d2e208"
Free the LRU object and set free_offset when dropping empty segments in
smp_close_seg()

Fixes: #1146
}}}

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1146#comment:1>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs [at] varnish-cache
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs

varnish-bugs at varnish-cache

Oct 10, 2012, 12:49 AM

Post #3 of 3 (93 views)
Permalink

Re: #1146: Persistent: When dropping empty segments, it will leak objects from LRU_Alloc, and not reset the free_offset to reclaim the space [In reply to]

#1146: Persistent: When dropping empty segments, it will leak objects from
LRU_Alloc, and not reset the free_offset to reclaim the space
----------------------+---------------------
Reporter: martin | Owner:
Type: defect | Status: closed
Priority: normal | Milestone:
Component: varnishd | Version: 3.0.2
Severity: normal | Resolution: fixed
Keywords: |
----------------------+---------------------
Changes (by Martin Blix Grydeland <martin@…>):

* status: new => closed
* resolution: => fixed

Comment:

(In [c74c457414847d5a1a56894fd9797ce2e4d2e208]) Free the LRU object and
set free_offset when dropping empty segments in smp_close_seg()

Fixes: #1146

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1146#comment:2>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs [at] varnish-cache
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads