Mailing List Archive: Varnish: Bugs

#1086: VGZ_WrwGunzip loops forever if receiving junk data after end of gzip data

Index | Next | Previous | View Threaded

varnish-bugs at varnish-cache

Jan 22, 2012, 8:30 AM

Post #1 of 10 (229 views)
Permalink

#1086: VGZ_WrwGunzip loops forever if receiving junk data after end of gzip data

#1086: VGZ_WrwGunzip loops forever if receiving junk data after end of gzip data
----------------------+-----------------------------------------------------
Reporter: martin | Owner:
Type: defect | Status: new
Priority: normal | Milestone:
Component: varnishd | Version: 3.0.0
Severity: normal | Keywords:
----------------------+-----------------------------------------------------
If VGZ_WrwGunzip is called again with junk data after end of gzip data, it
will loop forever. Note that this does not happen if the junk data is part
of the same input data buffer that contained the of gzip data, but it only
happens on successive calls to VGZ_WrwGunzip and VGZ_Guzip has seen the
end of gzip data.

This has an increased probability of happening when doing streaming. See
attached test case.

Bug has been confirmed in both 3.0 and master.

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1086>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs [at] varnish-cache
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs

varnish-bugs at varnish-cache

Jan 23, 2012, 3:07 AM

Post #2 of 10 (221 views)
Permalink

Re: #1086: VGZ_WrwGunzip loops forever if receiving junk data after end of gzip data [In reply to]

varnish-bugs at varnish-cache

Apr 23, 2012, 9:27 AM

Post #3 of 10 (187 views)
Permalink

Re: #1086: VGZ_WrwGunzip loops forever if receiving junk data after end of gzip data [In reply to]

#1086: VGZ_WrwGunzip loops forever if receiving junk data after end of gzip data
----------------------+-----------------------------------------------------
Reporter: martin | Owner:
Type: defect | Status: closed
Priority: normal | Milestone:
Component: varnishd | Version: 3.0.2
Severity: normal | Resolution: fixed
Keywords: |
----------------------+-----------------------------------------------------
Changes (by phk):

* status: new => closed
* resolution: => fixed

Comment:

I just checked, this is fixed in -trunk

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1086#comment:2>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs [at] varnish-cache
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs

varnish-bugs at varnish-cache

Jan 12, 2013, 1:40 AM

Post #4 of 10 (120 views)
Permalink

Re: #1086: VGZ_WrwGunzip loops forever if receiving junk data after end of gzip data [In reply to]

#1086: VGZ_WrwGunzip loops forever if receiving junk data after end of gzip data
----------------------+---------------------
Reporter: martin | Owner:
Type: defect | Status: closed
Priority: normal | Milestone:
Component: varnishd | Version: 3.0.2
Severity: normal | Resolution: fixed
Keywords: |
----------------------+---------------------

Comment (by LordCope):

I'm seeing behaviour very much in keeping with this issue. Running on
3.0.3 using the Varnish package for Ubuntu, if I run the test case
attached by "martin", it fails.

See attached log of varnishtest.

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1086#comment:3>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs [at] varnish-cache
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs

varnish-bugs at varnish-cache

Jan 12, 2013, 2:00 AM

Post #5 of 10 (110 views)
Permalink

Re: #1086: VGZ_WrwGunzip loops forever if receiving junk data after end of gzip data [In reply to]

#1086: VGZ_WrwGunzip loops forever if receiving junk data after end of gzip data
----------------------+-----------------------
Reporter: martin | Owner:
Type: defect | Status: reopened
Priority: normal | Milestone:
Component: varnishd | Version: 3.0.2
Severity: normal | Resolution:
Keywords: |
----------------------+-----------------------
Changes (by LordCope):

* status: closed => reopened
* resolution: fixed =>

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1086#comment:4>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs [at] varnish-cache
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs

varnish-bugs at varnish-cache

Jan 12, 2013, 2:03 AM

Post #6 of 10 (110 views)
Permalink

Re: #1086: VGZ_WrwGunzip loops forever if receiving junk data after end of gzip data [In reply to]

#1086: VGZ_WrwGunzip loops forever if receiving junk data after end of gzip data
----------------------+-----------------------
Reporter: martin | Owner:
Type: defect | Status: reopened
Priority: normal | Milestone:
Component: varnishd | Version: 3.0.2
Severity: normal | Resolution:
Keywords: |
----------------------+-----------------------

Comment (by LordCope):

Also, although it claims to be fixed, I don't see any relevant commit
logs, or anything in either changelog or the current src which references.
Perhaps when checked by 'phk' the reason for the test passing was
incidental - ie something could have subsequently changed which makes this
issue happen again?

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1086#comment:5>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs [at] varnish-cache
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs

varnish-bugs at varnish-cache

Jan 12, 2013, 6:39 AM

Post #7 of 10 (110 views)
Permalink

Re: #1086: VGZ_WrwGunzip loops forever if receiving junk data after end of gzip data [In reply to]

#1086: VGZ_WrwGunzip loops forever if receiving junk data after end of gzip data
----------------------+-----------------------
Reporter: martin | Owner:
Type: defect | Status: reopened
Priority: normal | Milestone:
Component: varnishd | Version: 3.0.2
Severity: normal | Resolution:
Keywords: |
----------------------+-----------------------

Comment (by LordCope):

Built the current git master of 3.0. Changed debug paramater to
debug=+syncvsl, and ran the test.

Failure attached.

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1086#comment:6>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs [at] varnish-cache
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs

varnish-bugs at varnish-cache

Jan 14, 2013, 3:42 AM

Post #8 of 10 (103 views)
Permalink

Re: #1086: VGZ_WrwGunzip loops forever if receiving junk data after end of gzip data [In reply to]

#1086: VGZ_WrwGunzip loops forever if receiving junk data after end of gzip data
----------------------+---------------------
Reporter: martin | Owner: martin
Type: defect | Status: new
Priority: normal | Milestone:
Component: varnishd | Version: 3.0.2
Severity: normal | Resolution:
Keywords: |
----------------------+---------------------
Changes (by martin):

* status: reopened => new
* owner: => martin

Comment:

Not applicable to trunk. I will have a look to see if this is a real
problem on 3.0. Bear in mind that the test case attached here might not be
very indicative, as testing on close conditions and streaming is not
trivial.

Martin

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1086#comment:7>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs [at] varnish-cache
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs

varnish-bugs at varnish-cache

Jan 14, 2013, 3:53 AM

Post #9 of 10 (105 views)
Permalink

Re: #1086: VGZ_WrwGunzip loops forever if receiving junk data after end of gzip data [In reply to]

#1086: VGZ_WrwGunzip loops forever if receiving junk data after end of gzip data
----------------------+---------------------
Reporter: martin | Owner: martin
Type: defect | Status: new
Priority: normal | Milestone:
Component: varnishd | Version: 3.0.2
Severity: normal | Resolution:
Keywords: |
----------------------+---------------------

Comment (by martin):

Note to self: Look at this with e6e34d24b7b2e47d936867a4a1d7714ca568b7ae
in mind

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1086#comment:8>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs [at] varnish-cache
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs

varnish-bugs at varnish-cache

Feb 13, 2013, 2:00 AM

Post #10 of 10 (85 views)
Permalink

Re: #1086: VGZ_WrwGunzip loops forever if receiving junk data after end of gzip data [In reply to]

#1086: VGZ_WrwGunzip loops forever if receiving junk data after end of gzip data
----------------------+---------------------
Reporter: martin | Owner: martin
Type: defect | Status: new
Priority: normal | Milestone:
Component: varnishd | Version: 3.0.2
Severity: normal | Resolution:
Keywords: |
----------------------+---------------------

Comment (by dstuart):

Hi, Is there any update on this.

Regards,

Dave

--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1086#comment:9>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

_______________________________________________
varnish-bugs mailing list
varnish-bugs [at] varnish-cache
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads