varnish-bugs at varnish-cache
Apr 23, 2012, 7:04 AM
Post #2 of 2
(78 views)
Permalink
|
|
Re: #1017: ESI includes not getting parsed due to faulty comments
[In reply to]
|
|
#1017: ESI includes not getting parsed due to faulty comments
-------------------------+--------------------------------------------------
Reporter: ddunlop | Type: defect
Status: closed | Priority: normal
Milestone: | Component: varnishd
Version: 3.0.1 | Severity: normal
Resolution: worksforme | Keywords: esi, parsing
-------------------------+--------------------------------------------------
Changes (by phk):
* status: new => closed
* resolution: => worksforme
Comment:
Sorry about not getting to this earlier.
I think Varnish behaves sensibly in this case, it sees the beginning of a
comment, and ignores everything up to the end of a comment.
The definition of a comment in XML is
{{{
Comment ::= '<!--' ((Char - '-') | ('-' (Char - '-')))* '-->'
}}}
(See: http://www.w3.org/TR/REC-xml/#sec-comments)
Which specifically does not allow for a minus right before the "end of
comment" sequence, (which is what causes the trouble in the example you
show) so the comment never ends and Varnish does not process ESI inside
comments.
--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1017#comment:1>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator
_______________________________________________
varnish-bugs mailing list
varnish-bugs [at] varnish-cache
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-bugs
|
