Mailing List Archive: Trac: Tickets

[The Trac Project] #1269: Search an expression with CamelCase does not work

Index | Next | Previous | View Threaded

noreply at edgewall

Mar 9, 2005, 7:22 AM

Post #1 of 24 (2518 views)
Permalink

[The Trac Project] #1269: Search an expression with CamelCase does not work

noreply at edgewall

Mar 9, 2005, 7:54 AM

Post #2 of 24 (2492 views)
Permalink

Re: [The Trac Project] #1269: Search an expression with CamelCase does not work [In reply to]

#1269: Search an expression with CamelCase does not work
---------------------+------------------------------------------------------
Id: 1269 | Status: new
Component: general | Modified: Wed Mar 9 07:54:20 2005
Severity: normal | Milestone:
Priority: normal | Version: 0.8.1
Owner: jonas | Reporter: oliver[at]code-project.org
---------------------+------------------------------------------------------
Comment (by cboos[at]bct-technology.com):

At least, that's the intended behavior.

But I see your point. If your a looking for, e.g. a class name,
you would like to see the commit messages or the tickets
talking about that class, not the empty Wiki page for that name.

A simple fix would be to redirect to the wiki page __only__
if such a page already exists.

In all cases, simply prefixing the CamelCase name by one
or more spaces bypasses the redirection and does a regular
search for that name.

--
Ticket URL: <http://projects.edgewall.com/trac/ticket/1269>
The Trac Project <>

noreply at edgewall

Mar 9, 2005, 8:05 AM

Post #3 of 24 (2478 views)
Permalink

Re: [The Trac Project] #1269: Search an expression with CamelCase does not work [In reply to]

noreply at edgewall

Mar 9, 2005, 9:07 AM

Post #4 of 24 (2480 views)
Permalink

Re: [The Trac Project] #1269: Search an expression with CamelCase does not work [In reply to]

noreply at edgewall

Jul 28, 2005, 7:20 PM

Post #5 of 24 (2478 views)
Permalink

Re: [The Trac Project] #1269: Search an expression with CamelCase does not work [In reply to]

noreply at edgewall

Jul 29, 2005, 3:33 AM

Post #6 of 24 (2484 views)
Permalink

Re: [The Trac Project] #1269: Search an expression with CamelCase does not work [In reply to]

#1269: Search an expression with CamelCase does not work
---------------------+------------------------------------------------------
Id: 1269 | Status: new
Component: general | Modified: Fri Jul 29 03:33:49 2005
Severity: normal | Milestone:
Priority: normal | Version: 0.8.1
Owner: jonas | Reporter: oliver[at]code-project.org
---------------------+------------------------------------------------------
Comment (by cboos):

In the trunk, the search module has been reworked a bit,
and the "quick jump" feature is now missing.

As this has to be reimplemented, we should take
this opportunity to fix the problem you raised.

Possible solutions:
* only quick jump if the corresponding object exists,
otherwise revert to normal search.
* same as above, but in addition, don't jump to the object,
but list it at the top of the results.
This would also make natural to simply enter a number,
and see the links to the corresponding ticket,
changeset and report having that number (if they exist)

The problem is that some people used the existing behavior
on purpose, in order to create new Wiki pages quickly...
But that feature was never advertised, and it's not a good
Wiki practice anyway, so maybe it's better to change/fix that.

--
Ticket URL: <http://projects.edgewall.com/trac/ticket/1269>
The Trac Project <>

noreply at edgewall

Oct 19, 2005, 6:23 AM

Post #7 of 24 (2481 views)
Permalink

Re: [The Trac Project] #1269: Search an expression with CamelCase does not work [In reply to]

noreply at edgewall

Mar 15, 2006, 5:32 AM

Post #8 of 24 (2483 views)
Permalink

Re: [The Trac Project] #1269: Search an expression with CamelCase does not work [In reply to]

#1269: Search an expression with CamelCase does not work
-------------------------------------+--------------------------------------
Reporter: oliver[at]code-project.org | Owner: cboos
Type: defect | Status: assigned
Priority: normal | Milestone: 0.10
Component: search system | Version: 0.8.1
Severity: minor | Resolution:
Keywords: search CamelCase |
-------------------------------------+--------------------------------------
Changes (by cboos):

* status: new => assigned
* severity: normal => minor
* owner: jonas => cboos
* milestone: => 0.10

Comment:

So what about doing the quick jump only if the page exist?
{{{
#!diff
Index: trac/Search.py
===================================================================
--- trac/Search.py (revision 3013)
+++ trac/Search.py (working copy)
@@ -22,7 +22,7 @@
from trac.util import TracError, escape, format_datetime, Markup
from trac.web import IRequestHandler
from trac.web.chrome import add_link, add_stylesheet,
INavigationContributor
-from trac.wiki import IWikiSyntaxProvider
+from trac.wiki import WikiSystem, IWikiSyntaxProvider

class ISearchSource(Interface):
@@ -253,7 +253,8 @@
elif len(kwd) > 1 and kwd[0].isupper() and kwd[1].islower():
r = "((^|(?<=[^A-Za-z]))[!]?[A-Z][a-z/]+(?:[A-Z][a-z/]+)+)"
if re.match (r, kwd):
- return self.env.href.wiki(kwd)
+ if WikiSystem(self.env).has_page(kwd):
+ return self.env.href.wiki(kwd)

# IWikiSyntaxProvider methods
}}}

--
Ticket URL: <http://projects.edgewall.com/trac/ticket/1269>
The Trac Project <http://trac.edgewall.com/>

noreply at edgewall

May 29, 2006, 7:09 AM

Post #9 of 24 (2477 views)
Permalink

Re: [The Trac Project] #1269: Search an expression with CamelCase does not work [In reply to]

#1269: Search an expression with CamelCase does not work
-------------------------------------+--------------------------------------
Reporter: oliver[at]code-project.org | Owner: cboos
Type: defect | Status: assigned
Priority: normal | Milestone: 0.10
Component: search system | Version: 0.8.1
Severity: minor | Resolution:
Keywords: search CamelCase |
-------------------------------------+--------------------------------------
Comment (by cboos):

On top of r3350, doing a quickjump only if the page (or any other object)
exists would be implemented like this:
{{{
#!diff
Index: trac/Search.py
===================================================================
--- trac/Search.py (revision 3350)
+++ trac/Search.py (working copy)
@@ -218,7 +218,8 @@
return req.href.browser(kwd)
link = wiki_to_link(kwd, self.env, req)
if isinstance(link, Element):
- return link.attr['href']
+ if 'missing' not in link.attr.get('class_', ''):
+ return link.attr['href']

# IWikiSyntaxProvider methods
}}}

This will ignore redirections to objects that are known to be missing.

Also, it was suggested somewhere that we could disable the quickjump
entirely
in the search page, only have it when the search is triggered from the
small form present on every page... opinions?

--
Ticket URL: <http://projects.edgewall.com/trac/ticket/1269>
The Trac Project <http://trac.edgewall.com/>
_______________________________________________
Trac-Tickets mailing list
Trac-Tickets[at]lists.edgewall.com
http://lists.edgewall.com/mailman/listinfo/trac-tickets

noreply at edgewall

May 29, 2006, 11:56 AM

Post #10 of 24 (2481 views)
Permalink

Re: [The Trac Project] #1269: Search an expression with CamelCase does not work [In reply to]

noreply at edgewall

May 30, 2006, 1:57 AM

Post #11 of 24 (2474 views)
Permalink

Re: [The Trac Project] #1269: Search an expression with CamelCase does not work [In reply to]

noreply at edgewall

Jun 7, 2006, 10:19 PM

Post #12 of 24 (2457 views)
Permalink

Re: [The Trac Project] #1269: Search an expression with CamelCase does not work [In reply to]

#1269: Search an expression with CamelCase does not work
-------------------------------------+--------------------------------------
Reporter: oliver[at]code-project.org | Owner: cboos
Type: defect | Status: assigned
Priority: normal | Milestone: 0.10
Component: search system | Version: 0.8.1
Severity: minor | Resolution:
Keywords: search CamelCase |
-------------------------------------+--------------------------------------
Comment (by athomas):

Seems there are two issues here:

1. Disabling quick jumps (solved with the `!` prefix)
2. An extensible/consistent way of adding quick jumps

This ticket only deals with the first of these and is easily solvable:

{{{
#!diff
Index: trac/Search.py
===================================================================
--- trac/Search.py (revision 3370)
+++ trac/Search.py (working copy)
@@ -164,10 +164,10 @@
if query:
page = int(req.args.get('page', '1'))
redir = self.quickjump(req, query)
- if redir:
+ if query.startswith('!'):
+ query = query[1:]
+ elif redir:
req.redirect(redir)
- elif query.startswith('!'):
- query = query[1:]
terms = search_terms(query)
# Refuse queries that obviously would result in a huge result
set
if len(terms) == 1 and len(terms[0]) < 3:
}}}

Perhaps we should close this for [milestone:0.10 0.10] and move discussion
of 2 to another ticket?

Personally I'm -1 on adding a conditional check for existence because of
the extra ''magic''. For example, I'd prefer `r9999` to tell me the
changeset doesn't exist rather than perform a search.

--
Ticket URL: <http://projects.edgewall.com/trac/ticket/1269>
The Trac Project <http://trac.edgewall.com/>
_______________________________________________
Trac-Tickets mailing list
Trac-Tickets[at]lists.edgewall.com
http://lists.edgewall.com/mailman/listinfo/trac-tickets

noreply at edgewall

Jun 8, 2006, 12:13 AM

Post #13 of 24 (2464 views)
Permalink

Re: [The Trac Project] #1269: Search an expression with CamelCase does not work [In reply to]

noreply at edgewall

Jun 8, 2006, 3:20 AM

Post #14 of 24 (2469 views)
Permalink

Re: [The Trac Project] #1269: Search an expression with CamelCase does not work [In reply to]

noreply at edgewall

Jun 8, 2006, 3:23 AM

Post #15 of 24 (2461 views)
Permalink

Re: [The Trac Project] #1269: Search an expression with CamelCase does not work [In reply to]

noreply at edgewall

Jun 8, 2006, 4:19 AM

Post #16 of 24 (2455 views)
Permalink

Re: [The Trac Project] #1269: Search an expression with CamelCase does not work [In reply to]

noreply at edgewall

Jun 8, 2006, 4:36 AM

Post #17 of 24 (2459 views)
Permalink

Re: [The Trac Project] #1269: Search an expression with CamelCase does not work [In reply to]

#1269: Search an expression with CamelCase does not work
-------------------------------------+--------------------------------------
Reporter: oliver[at]code-project.org | Owner: cboos
Type: defect | Status: assigned
Priority: normal | Milestone: 0.10
Component: search system | Version: 0.8.1
Severity: minor | Resolution:
Keywords: search CamelCase |
-------------------------------------+--------------------------------------
Comment (by cboos):

What I meant is that without your patch, Trac already behaves like this:
the ! will negate the wiki syntax, and no link will be created, therefore
`redir` will be `None`... The optimization you do is to simply by-pass the
Wiki formatting when there's a leading "!". Why not, I'm OK with that.

But again, I think that this ticket is not about using the "!",
rather with the newcomer's surprise when searching for something
and ending up with a create wiki page, as david.tulloh illustrated
it above (hm... no `comment:` links on p.e.c yet :( ).

Quick jumps are pretty useful, so I don't see the point of disabling
that feature entirely just to workaround the above problem, which is
only a minor inconvenience.

What has been proposed so far:
1. Doing a search if the target of the quickjump is known as missing
(option which doesn't seem to be popular... ok)
2. Disabling the quickjump on the search page, but keeping it when
the search is triggered from the top search box

In addition, I'd like to propose a variation on 2:

3. On the search page, retrieve the link given by the quickjump,
but ''don't'' redirect to it, rather present a link to it
before the search results, which will be gathered regardless
of the `redir` value.
The quickjump toplevel search box behaves as usual.

What do you think?

--
Ticket URL: <http://projects.edgewall.com/trac/ticket/1269>
The Trac Project <http://trac.edgewall.com/>
_______________________________________________
Trac-Tickets mailing list
Trac-Tickets[at]lists.edgewall.com
http://lists.edgewall.com/mailman/listinfo/trac-tickets

noreply at edgewall

Jun 8, 2006, 5:03 AM

Post #18 of 24 (2466 views)
Permalink

Re: [The Trac Project] #1269: Search an expression with CamelCase does not work [In reply to]

noreply at edgewall

Jun 13, 2006, 7:21 PM

Post #19 of 24 (2453 views)
Permalink

Re: [The Trac Project] #1269: Search an expression with CamelCase does not work [In reply to]

noreply at edgewall

Jun 13, 2006, 9:48 PM

Post #20 of 24 (2465 views)
Permalink

Re: [The Trac Project] #1269: Search an expression with CamelCase does not work [In reply to]

noreply at edgewall

Jun 14, 2006, 3:18 AM

Post #21 of 24 (2455 views)
Permalink

Re: [The Trac Project] #1269: Search an expression with CamelCase does not work [In reply to]

noreply at edgewall

Jun 20, 2006, 9:14 AM

Post #22 of 24 (2403 views)
Permalink

Re: [The Trac Project] #1269: Search an expression with CamelCase does not work [In reply to]

noreply at edgewall

Jun 23, 2006, 7:31 AM

Post #23 of 24 (2380 views)
Permalink

Re: [The Trac Project] #1269: Search an expression with CamelCase does not work [In reply to]

noreply at edgewall

Jun 24, 2006, 4:12 PM

Post #24 of 24 (2383 views)
Permalink

Re: [The Trac Project] #1269: Search an expression with CamelCase does not work [In reply to]

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact lists@gossamer-threads.com