Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Trac: Tickets

Re: [The Trac Project] #267: Make external references visually distinct

 

 

Trac tickets RSS feed   Index | Next | Previous | View Threaded


noreply at edgewall

Nov 5, 2004, 12:06 PM

Post #1 of 5 (133 views)
Permalink
Re: [The Trac Project] #267: Make external references visually distinct

#267: Make external references visually distinct
-------------------------+--------------------------------------------------
Id: 267 | Status: new
Component: wiki | Modified: Fri Nov 5 12:06:10 2004
Severity: enhancement | Milestone: 0.9
Priority: lowest | Version: 0.6.1
Owner: jonas | Reporter: daniel
-------------------------+--------------------------------------------------
Comment (by cboos [at] bct-technology):

See the patch I attached to #234, which contains an 'external' class.

--
Ticket URL: <http://projects.edgewall.com/trac/ticket/267>
The Trac Project <>


noreply at edgewall

Nov 5, 2004, 12:19 PM

Post #2 of 5 (134 views)
Permalink
Re: [The Trac Project] #267: Make external references visually distinct [In reply to]

#267: Make external references visually distinct
-------------------------+--------------------------------------------------
Id: 267 | Status: new
Component: wiki | Modified: Fri Nov 5 12:19:40 2004
Severity: enhancement | Milestone: 0.9
Priority: low | Version: 0.6.1
Owner: jonas | Reporter: daniel
-------------------------+--------------------------------------------------
Changes (by cboos [at] bct-technology):

* priority: lowest => low

Comment:

... the relevant part being:
{{{
#!text/x-diff
=== htdocs/css/trac.css
==================================================================
--- htdocs/css/trac.css (revision 1030)
+++ htdocs/css/trac.css (local)
@@ -240,6 +240,8 @@
a.missing:link,a.missing:visited { background: #fafaf0; color: #998 }
a.missing:hover { color: #000; }

+a.external:link,a.external:visited { color: #00b }
+
#content.wiki { line-height: 140% }
.wikitoolbar {
border: solid #d7d7d7;
=== trac/WikiFormatter.py
==================================================================
--- trac/WikiFormatter.py (revision 1049)
+++ trac/WikiFormatter.py (local)
@@ -304,7 +304,7 @@
return '<a href="%s">%s</a>' % (self._href.wiki(match),
match)

def _url_formatter(self, match, fullmatch):
- return '<a href="%s">%s</a>' % (match, match)
+ return '<a class="external" href="%s">%s</a>' % (match, match)

def _fancylink_formatter(self, match, fullmatch):
link = fullmatch.group('fancyurl')
@@ -319,7 +319,7 @@
elif module_link:
return '<a href="%s">%s</a>' % (module_link, name)
else:
- return '<a href="%s">%s</a>' % (link, name)
+ return '<a class="external" href="%s">%s</a>' % (link, name)

def _intertrac_link(self, intertrac):
href = self.env.get_config('intertrac', intertrac.upper() +
'.href')

}}}

--
Ticket URL: <http://projects2.edgewall.com/trac/ticket/267>
The Trac Project <>


noreply at edgewall

Nov 16, 2004, 4:50 PM

Post #3 of 5 (134 views)
Permalink
Re: [The Trac Project] #267: Make external references visually distinct [In reply to]

#267: Make external references visually distinct
-------------------------+--------------------------------------------------
Id: 267 | Status: closed
Component: wiki | Modified: Tue Nov 16 16:50:31 2004
Severity: enhancement | Milestone: 0.8
Priority: low | Version: 0.6.1
Owner: jonas | Reporter: daniel
-------------------------+--------------------------------------------------
Changes (by cmlenz):

* resolution: => fixed
* milestone: 0.9 => 0.8
* status: new => closed

Old description:

> Links referencing outside trac should be visually distinct, like i other
> wikis.
>
> This should be done in CSS only.

New description:

Links referencing outside trac should be visually distinct, like i other
wikis.

This should be done in CSS only.

Comment:

Daniel has implemented this in [1068].

--
Ticket URL: <http://projects.edgewall.com/trac/ticket/267>
The Trac Project <>


noreply at edgewall

Nov 16, 2004, 5:48 PM

Post #4 of 5 (133 views)
Permalink
Re: [The Trac Project] #267: Make external references visually distinct [In reply to]

#267: Make external references visually distinct
-------------------------+--------------------------------------------------
Id: 267 | Status: closed
Component: wiki | Modified: Tue Nov 16 17:48:39 2004
Severity: enhancement | Milestone: 0.8
Priority: low | Version: 0.6.1
Owner: jonas | Reporter: daniel
-------------------------+--------------------------------------------------
Comment (by Juanma Barranquero):

Am I the only one who finds the new external link style a bit heavy-
handed? Perhaps a simple color change would have sufficed (yes, I know I
can customize to my heart's content, but still... :)

And, if definitely using an icon, wouldn't be better to have it *after*
the link, ? la [http://wikipedia.sourceforge.net/ MediaWiki]?

--
Ticket URL: <http://projects.edgewall.com/trac/ticket/267>
The Trac Project <>


noreply at edgewall

Nov 17, 2004, 3:54 AM

Post #5 of 5 (131 views)
Permalink
Re: [The Trac Project] #267: Make external references visually distinct [In reply to]

#267: Make external references visually distinct
-------------------------+--------------------------------------------------
Id: 267 | Status: closed
Component: wiki | Modified: Wed Nov 17 03:54:26 2004
Severity: enhancement | Milestone: 0.8
Priority: low | Version: 0.6.1
Owner: jonas | Reporter: daniel
-------------------------+--------------------------------------------------
Comment (by cboos [at] bct-technology):

I like the new style, and didn't hesitate a split second
to drop my "color-only" change...

--
Ticket URL: <http://projects.edgewall.com/trac/ticket/267>
The Trac Project <>

Trac tickets RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.