Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Trac: Tickets

[The Trac Project] #3753: Support the sqlite3 module that comes with Python 2.5

 

 

Trac tickets RSS feed   Index | Next | Previous | View Threaded


noreply at edgewall

Sep 20, 2006, 2:26 AM

Post #1 of 9 (1228 views)
Permalink
[The Trac Project] #3753: Support the sqlite3 module that comes with Python 2.5

#3753: Support the sqlite3 module that comes with Python 2.5
-------------------------+--------------------------------------------------
Reporter: cmlenz | Owner: jonas
Type: enhancement | Status: new
Priority: high | Milestone: 0.10
Component: general | Version: 0.10b1
Severity: normal | Keywords:
-------------------------+--------------------------------------------------
Now that Python 2.5 has been released, we should support the `sqlite3`
module that comes bundled.

The package name has been changed from `pysqlite2.dbapi2` to `sqlite3`, so
an adjustment of Trac's `sqlite_backend` is required. One open question is
whether `pysqlite2.dbapi2` should take precedence over `sqlite3` or the
other way around.

I'll attach a patch that adds support for `sqlite3`, and prefers it to the
standalone PySQLite driver.

--
Ticket URL: <http://trac.edgewall.org/ticket/3753>
The Trac Project <http://trac.edgewall.org/>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac Tickets" group.
To post to this group, send email to trac-tickets [at] googlegroups
To unsubscribe from this group, send email to trac-tickets-unsubscribe [at] googlegroups
For more options, visit this group at http://groups.google.se/group/trac-tickets
-~----------~----~----~----~------~----~------~--~---


noreply at edgewall

Sep 20, 2006, 2:27 AM

Post #2 of 9 (1152 views)
Permalink
Re: [The Trac Project] #3753: Support the sqlite3 module that comes with Python 2.5 [In reply to]

#3753: Support the sqlite3 module that comes with Python 2.5
-------------------------+--------------------------------------------------
Reporter: cmlenz | Owner: jonas
Type: enhancement | Status: new
Priority: high | Milestone: 0.10
Component: general | Version: 0.10b1
Severity: normal | Resolution:
Keywords: |
-------------------------+--------------------------------------------------
Comment (by cmlenz):

Can someone review this patch before we check it in?

--
Ticket URL: <http://trac.edgewall.org/ticket/3753#comment:1>
The Trac Project <http://trac.edgewall.org/>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac Tickets" group.
To post to this group, send email to trac-tickets [at] googlegroups
To unsubscribe from this group, send email to trac-tickets-unsubscribe [at] googlegroups
For more options, visit this group at http://groups.google.se/group/trac-tickets
-~----------~----~----~----~------~----~------~--~---


noreply at edgewall

Sep 20, 2006, 2:36 AM

Post #3 of 9 (1169 views)
Permalink
Re: [The Trac Project] #3753: Support the sqlite3 module that comes with Python 2.5 [In reply to]

#3753: Support the sqlite3 module that comes with Python 2.5
-------------------------+--------------------------------------------------
Reporter: cmlenz | Owner: jonas
Type: enhancement | Status: new
Priority: high | Milestone: 0.10
Component: general | Version: 0.10b1
Severity: normal | Resolution:
Keywords: review |
-------------------------+--------------------------------------------------
Changes (by cboos):

* keywords: => review

Comment:

I think that pysqlite2 should take precedence over sqlite3 if it
corresponds to a more recent version.

--
Ticket URL: <http://trac.edgewall.org/ticket/3753#comment:2>
The Trac Project <http://trac.edgewall.org/>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac Tickets" group.
To post to this group, send email to trac-tickets [at] googlegroups
To unsubscribe from this group, send email to trac-tickets-unsubscribe [at] googlegroups
For more options, visit this group at http://groups.google.se/group/trac-tickets
-~----------~----~----~----~------~----~------~--~---


noreply at edgewall

Sep 20, 2006, 5:35 AM

Post #4 of 9 (1161 views)
Permalink
Re: [The Trac Project] #3753: Support the sqlite3 module that comes with Python 2.5 [In reply to]

#3753: Support the sqlite3 module that comes with Python 2.5
-----------------------------+----------------------------------------------
Reporter: cmlenz | Owner: jonas
Type: enhancement | Status: new
Priority: high | Milestone: 0.10
Component: general | Version: devel
Severity: normal | Resolution:
Keywords: python25 review |
-----------------------------+----------------------------------------------
Changes (by cboos):

* keywords: review => python25 review
* version: 0.10b1 => devel

Comment:

Updated the patch. A typical scenario for this is that you have the need
for a bug fix, then it's probably much easier to install the new pysqlite
package from initd.org than to upgrade the bundled sqlite3 package. Or,
you need to recompile pysqlite so that it uses a specific sqlite version
(in that case, you'd also have to bump the PYSQLITE_VERSION in
src/module.h to something higher than 2.3.2, which is sqlite3's version
for the Python 2.5 release).

Besides this, I've successfully tested both sqlite3.diff and
sqlite3.2.diff on the Genshi branch, using Python 2.5 freshly installed
from the python-2.5.msi

Side-note: if we're to support python 2.5 for 0.10, we probably need to
backport r3751 (or a better fix) on trunk.

--
Ticket URL: <http://trac.edgewall.org/ticket/3753#comment:3>
The Trac Project <http://trac.edgewall.org/>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac Tickets" group.
To post to this group, send email to trac-tickets [at] googlegroups
To unsubscribe from this group, send email to trac-tickets-unsubscribe [at] googlegroups
For more options, visit this group at http://groups.google.se/group/trac-tickets
-~----------~----~----~----~------~----~------~--~---


noreply at edgewall

Sep 20, 2006, 5:45 AM

Post #5 of 9 (1153 views)
Permalink
Re: [The Trac Project] #3753: Support the sqlite3 module that comes with Python 2.5 [In reply to]

#3753: Support the sqlite3 module that comes with Python 2.5
-----------------------------+----------------------------------------------
Reporter: cmlenz | Owner: jonas
Type: enhancement | Status: new
Priority: high | Milestone: 0.10
Component: general | Version: devel
Severity: normal | Resolution:
Keywords: python25 review |
-----------------------------+----------------------------------------------
Comment (by cmlenz):

I agree it should default to `pysqlite2.dbapi2`. Don't see the point of
the version comparison though, I'd rather keep the logic simple and always
use PySQLite2 in preference to the bundled `sqlite3` module.

Also agree about backporting r3751. Python 2.5 compatibility should
definitely be a goal with 0.10.x.

--
Ticket URL: <http://trac.edgewall.org/ticket/3753#comment:4>
The Trac Project <http://trac.edgewall.org/>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac Tickets" group.
To post to this group, send email to trac-tickets [at] googlegroups
To unsubscribe from this group, send email to trac-tickets-unsubscribe [at] googlegroups
For more options, visit this group at http://groups.google.se/group/trac-tickets
-~----------~----~----~----~------~----~------~--~---


noreply at edgewall

Sep 20, 2006, 6:38 AM

Post #6 of 9 (1168 views)
Permalink
Re: [The Trac Project] #3753: Support the sqlite3 module that comes with Python 2.5 [In reply to]

#3753: Support the sqlite3 module that comes with Python 2.5
-----------------------------+----------------------------------------------
Reporter: cmlenz | Owner: jonas
Type: enhancement | Status: new
Priority: high | Milestone: 0.10
Component: general | Version: devel
Severity: normal | Resolution:
Keywords: python25 review |
-----------------------------+----------------------------------------------
Comment (by cboos):

Ok, so attachment:sqlite3.3.diff should do the trick.

--
Ticket URL: <http://trac.edgewall.org/ticket/3753#comment:5>
The Trac Project <http://trac.edgewall.org/>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac Tickets" group.
To post to this group, send email to trac-tickets [at] googlegroups
To unsubscribe from this group, send email to trac-tickets-unsubscribe [at] googlegroups
For more options, visit this group at http://groups.google.se/group/trac-tickets
-~----------~----~----~----~------~----~------~--~---


noreply at edgewall

Sep 20, 2006, 6:47 AM

Post #7 of 9 (1165 views)
Permalink
Re: [The Trac Project] #3753: Support the sqlite3 module that comes with Python 2.5 [In reply to]

#3753: Support the sqlite3 module that comes with Python 2.5
-----------------------------+----------------------------------------------
Reporter: cmlenz | Owner: jonas
Type: enhancement | Status: new
Priority: high | Milestone: 0.10
Component: general | Version: devel
Severity: normal | Resolution:
Keywords: python25 review |
-----------------------------+----------------------------------------------
Comment (by mgood):

Replying to [comment:5 cboos]:
> Ok, so attachment:sqlite3.3.diff should do the trick.

No, you reattached the second version of the patch.

--
Ticket URL: <http://trac.edgewall.org/ticket/3753#comment:6>
The Trac Project <http://trac.edgewall.org/>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac Tickets" group.
To post to this group, send email to trac-tickets [at] googlegroups
To unsubscribe from this group, send email to trac-tickets-unsubscribe [at] googlegroups
For more options, visit this group at http://groups.google.se/group/trac-tickets
-~----------~----~----~----~------~----~------~--~---


noreply at edgewall

Sep 20, 2006, 7:14 AM

Post #8 of 9 (1172 views)
Permalink
Re: [The Trac Project] #3753: Support the sqlite3 module that comes with Python 2.5 [In reply to]

#3753: Support the sqlite3 module that comes with Python 2.5
-----------------------------+----------------------------------------------
Reporter: cmlenz | Owner: jonas
Type: enhancement | Status: new
Priority: high | Milestone: 0.10
Component: general | Version: devel
Severity: normal | Resolution:
Keywords: python25 review |
-----------------------------+----------------------------------------------
Comment (by cboos):

Oops -- fixed. As you can see, that's actually the same thing as cmlenz'
first attempt, only the order of sqlite3 and pysqlite2 imports has been
permuted.

--
Ticket URL: <http://trac.edgewall.org/ticket/3753#comment:7>
The Trac Project <http://trac.edgewall.org/>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac Tickets" group.
To post to this group, send email to trac-tickets [at] googlegroups
To unsubscribe from this group, send email to trac-tickets-unsubscribe [at] googlegroups
For more options, visit this group at http://groups.google.se/group/trac-tickets
-~----------~----~----~----~------~----~------~--~---


noreply at edgewall

Sep 20, 2006, 1:16 PM

Post #9 of 9 (1176 views)
Permalink
Re: [The Trac Project] #3753: Support the sqlite3 module that comes with Python 2.5 [In reply to]

#3753: Support the sqlite3 module that comes with Python 2.5
-----------------------------+----------------------------------------------
Reporter: cmlenz | Owner: jonas
Type: enhancement | Status: closed
Priority: high | Milestone: 0.10
Component: general | Version: devel
Severity: normal | Resolution: fixed
Keywords: python25 review |
-----------------------------+----------------------------------------------
Changes (by cmlenz):

* status: new => closed
* resolution: => fixed

Comment:

Checked in the patch in [3754].

''Sooo'' close to matching the ticket number to the changeset number here
:-P

--
Ticket URL: <http://trac.edgewall.org/ticket/3753#comment:8>
The Trac Project <http://trac.edgewall.org/>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac Tickets" group.
To post to this group, send email to trac-tickets [at] googlegroups
To unsubscribe from this group, send email to trac-tickets-unsubscribe [at] googlegroups
For more options, visit this group at http://groups.google.se/group/trac-tickets
-~----------~----~----~----~------~----~------~--~---

Trac tickets RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.