Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Trac: Tickets

[The Trac Project] #3167: Trac RSS feeds lack GUID elements

 

 

Trac tickets RSS feed   Index | Next | Previous | View Threaded


noreply at edgewall

May 19, 2006, 9:45 AM

Post #1 of 9 (2105 views)
Permalink
[The Trac Project] #3167: Trac RSS feeds lack GUID elements

#3167: Trac RSS feeds lack GUID elements
--------------------------------+-------------------------------------------
Reporter: exarkun [at] divmod | Owner: jonas
Type: defect | Status: new
Priority: normal | Milestone:
Component: general | Version: 0.9.5
Severity: normal | Keywords:
--------------------------------+-------------------------------------------
RSS 2.0 has per-item guids. These let clients unambiguously determine the
identity of feed items and do such things as handle read/unread status
correctly. Trac should include a guid element in each item element in its
feeds.

--
Ticket URL: <http://projects.edgewall.com/trac/ticket/3167>
The Trac Project <http://trac.edgewall.com/>
_______________________________________________
Trac-Tickets mailing list
Trac-Tickets [at] lists
http://lists.edgewall.com/mailman/listinfo/trac-tickets


noreply at edgewall

Aug 16, 2006, 8:09 AM

Post #2 of 9 (2023 views)
Permalink
Re: [The Trac Project] #3167: Trac RSS feeds lack GUID elements [In reply to]

#3167: Trac RSS feeds lack GUID elements
--------------------------------+-------------------------------------------
Reporter: exarkun [at] divmod | Owner: jonas
Type: defect | Status: new
Priority: normal | Milestone:
Component: general | Version: 0.9.5
Severity: normal | Resolution:
Keywords: |
--------------------------------+-------------------------------------------
Comment (by anonymous):

I've attached a patch that adds a guid element to the Timeline feed... The
guid value is a md5 hash build from the link to, and the date of, the
event (hence, it is no !PermaLink, i.e. isPermaLink="false"!!)
The patches apply to Timeline.py and timeline_rss.cs of Trac version
0.9.6...

To find out more about the patch, have a look at http://dawis2.icb.uni-
due.de/jpddtools/AddGuidToTimelineFeedPatch.html

nik4536

--
Ticket URL: <http://trac.edgewall.org/ticket/3167#comment:1>
The Trac Project <http://trac.edgewall.com/>
_______________________________________________
Trac-Tickets mailing list
Trac-Tickets [at] lists
http://lists.edgewall.com/mailman/listinfo/trac-tickets


noreply at edgewall

Aug 16, 2006, 8:30 AM

Post #3 of 9 (2016 views)
Permalink
Re: [The Trac Project] #3167: Trac RSS feeds lack GUID elements [In reply to]

#3167: Trac RSS feeds lack GUID elements
--------------------------------+-------------------------------------------
Reporter: exarkun [at] divmod | Owner: jonas
Type: defect | Status: new
Priority: normal | Milestone:
Component: general | Version: 0.9.5
Severity: normal | Resolution:
Keywords: |
--------------------------------+-------------------------------------------
Comment (by cmlenz):

I'd rather see us support permalinks for all entry instead of artificial
GUIDs. Trunk already does that for tickets, and we should probably do the
same for ticket changes.

--
Ticket URL: <http://trac.edgewall.org/ticket/3167#comment:2>
The Trac Project <http://trac.edgewall.com/>
_______________________________________________
Trac-Tickets mailing list
Trac-Tickets [at] lists
http://lists.edgewall.com/mailman/listinfo/trac-tickets


noreply at edgewall

Aug 16, 2006, 10:54 AM

Post #4 of 9 (2023 views)
Permalink
Re: [The Trac Project] #3167: Trac RSS feeds lack GUID elements [In reply to]

#3167: Trac RSS feeds lack GUID elements
--------------------------------+-------------------------------------------
Reporter: exarkun [at] divmod | Owner: jonas
Type: defect | Status: new
Priority: normal | Milestone:
Component: general | Version: 0.9.5
Severity: normal | Resolution:
Keywords: |
--------------------------------+-------------------------------------------
Comment (by mgood):

Replying to [comment:1 anonymous]:
> I've attached a patch that adds a guid element to the Timeline feed...

It's easier if you attach a single patch file instead of separate diffs
for each file you changed. See TracDev/SubmittingPatches.

I agree with cmlenz that we should use permalinks here. It seems like
this would require a change to the return value of
`ITimelineEventProvider.get_timeline_events` so each module could provide
its own permalinks, so this should probably be made before the 0.10
release, or post-poned to 0.11.

--
Ticket URL: <http://trac.edgewall.org/ticket/3167#comment:3>
The Trac Project <http://trac.edgewall.com/>
_______________________________________________
Trac-Tickets mailing list
Trac-Tickets [at] lists
http://lists.edgewall.com/mailman/listinfo/trac-tickets


noreply at edgewall

Aug 16, 2006, 11:25 AM

Post #5 of 9 (2012 views)
Permalink
Re: [The Trac Project] #3167: Trac RSS feeds lack GUID elements [In reply to]

#3167: Trac RSS feeds lack GUID elements
--------------------------------+-------------------------------------------
Reporter: exarkun [at] divmod | Owner: jonas
Type: defect | Status: new
Priority: normal | Milestone:
Component: general | Version: 0.9.5
Severity: normal | Resolution:
Keywords: |
--------------------------------+-------------------------------------------
Comment (by cmlenz):

Replying to [comment:3 mgood]:
> I agree with cmlenz that we should use permalinks here. It seems like
this would
> require a change to the return value of
`ITimelineEventProvider.get_timeline_events`
> so each module could provide its own permalinks, so this should probably
be made
> before the 0.10 release, or post-poned to 0.11.

I don't see why an interface change would be needed. If it makes sense for
the RSS feed to use a link to a specific version/comment of a page, why
shouldn't the timeline itself do the same? I.e. the providers ''should''
return unique links for the events, and the timeline RSS feed just reuses
those for the permalinks.

--
Ticket URL: <http://trac.edgewall.org/ticket/3167#comment:4>
The Trac Project <http://trac.edgewall.com/>
_______________________________________________
Trac-Tickets mailing list
Trac-Tickets [at] lists
http://lists.edgewall.com/mailman/listinfo/trac-tickets


noreply at edgewall

Oct 1, 2006, 7:45 AM

Post #6 of 9 (1998 views)
Permalink
Re: [The Trac Project] #3167: Trac RSS feeds lack GUID elements [In reply to]

#3167: Trac RSS feeds lack GUID elements
--------------------------------+-------------------------------------------
Reporter: exarkun [at] divmod | Owner: eblot
Type: defect | Status: assigned
Priority: normal | Milestone:
Component: general | Version: 0.9.5
Severity: normal | Resolution:
Keywords: |
--------------------------------+-------------------------------------------
Changes (by eblot):

* owner: jonas => eblot
* status: new => assigned

Comment:

I tried to have a look at this ticket. I'm attaching a patch.

For the timeline feed, we need to add an extra information to the HDF: the
date, unformatted.[[BR]]
This is required for wiki page edition, as the link is always the same for
any version of the same wiki page, which would make the ''guid'' not
unique.

For the feed an event is always unique:
* report: ticket number
* query: ticket number
* ticket: ticket and comment number
* repository log: version number (only tested w/ SVN)

I've submitted 5 feed samples (on for each feed source) to the
[http://validator.w3.org/feed/check.cgi w3c validator] and all of them
have been repored as valid, without warnings.

--
Ticket URL: <http://trac.edgewall.org/ticket/3167#comment:5>
The Trac Project <http://trac.edgewall.org/>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac Tickets" group.
To post to this group, send email to trac-tickets [at] googlegroups
To unsubscribe from this group, send email to trac-tickets-unsubscribe [at] googlegroups
For more options, visit this group at http://groups.google.se/group/trac-tickets
-~----------~----~----~----~------~----~------~--~---


noreply at edgewall

Oct 1, 2006, 7:46 AM

Post #7 of 9 (1988 views)
Permalink
Re: [The Trac Project] #3167: Trac RSS feeds lack GUID elements [In reply to]

#3167: Trac RSS feeds lack GUID elements
--------------------------------+-------------------------------------------
Reporter: exarkun [at] divmod | Owner: eblot
Type: defect | Status: assigned
Priority: normal | Milestone:
Component: general | Version: 0.9.5
Severity: normal | Resolution:
Keywords: review |
--------------------------------+-------------------------------------------
Changes (by eblot):

* keywords: => review

--
Ticket URL: <http://trac.edgewall.org/ticket/3167#comment:6>
The Trac Project <http://trac.edgewall.org/>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac Tickets" group.
To post to this group, send email to trac-tickets [at] googlegroups
To unsubscribe from this group, send email to trac-tickets-unsubscribe [at] googlegroups
For more options, visit this group at http://groups.google.se/group/trac-tickets
-~----------~----~----~----~------~----~------~--~---


noreply at edgewall

Oct 1, 2006, 8:22 AM

Post #8 of 9 (1999 views)
Permalink
Re: [The Trac Project] #3167: Trac RSS feeds lack GUID elements [In reply to]

#3167: Trac RSS feeds lack GUID elements
--------------------------------+-------------------------------------------
Reporter: exarkun [at] divmod | Owner: eblot
Type: defect | Status: assigned
Priority: normal | Milestone:
Component: general | Version: 0.9.5
Severity: normal | Resolution:
Keywords: review |
--------------------------------+-------------------------------------------
Comment (by eblot):

As ''cmlenz'' noticed (on IRC) ''guid''s should not be declared as
permalinks, as ticket&wiki pages can be edited/deleted which mean that URL
can stop to point to valid pages or point to pages whose content has
changed.

--
Ticket URL: <http://trac.edgewall.org/ticket/3167#comment:7>
The Trac Project <http://trac.edgewall.org/>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac Tickets" group.
To post to this group, send email to trac-tickets [at] googlegroups
To unsubscribe from this group, send email to trac-tickets-unsubscribe [at] googlegroups
For more options, visit this group at http://groups.google.se/group/trac-tickets
-~----------~----~----~----~------~----~------~--~---


noreply at edgewall

Oct 1, 2006, 10:39 AM

Post #9 of 9 (1988 views)
Permalink
Re: [The Trac Project] #3167: Trac RSS feeds lack GUID elements [In reply to]

#3167: Trac RSS feeds lack GUID elements
--------------------------------+-------------------------------------------
Reporter: exarkun [at] divmod | Owner: eblot
Type: defect | Status: closed
Priority: normal | Milestone: 0.10.1
Component: general | Version: 0.9.5
Severity: normal | Resolution: fixed
Keywords: review |
--------------------------------+-------------------------------------------
Changes (by eblot):

* status: assigned => closed
* resolution: => fixed
* milestone: => 0.10.1

Comment:

Patch has been commited in r3814 and r3815, without support for permalinks

--
Ticket URL: <http://trac.edgewall.org/ticket/3167#comment:8>
The Trac Project <http://trac.edgewall.org/>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac Tickets" group.
To post to this group, send email to trac-tickets [at] googlegroups
To unsubscribe from this group, send email to trac-tickets-unsubscribe [at] googlegroups
For more options, visit this group at http://groups.google.se/group/trac-tickets
-~----------~----~----~----~------~----~------~--~---

Trac tickets RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.