Mailing List Archive: Trac: Tickets

[The Trac Project] #3167: Trac RSS feeds lack GUID elements

Index | Next | Previous | View Threaded

noreply at edgewall

May 19, 2006, 9:45 AM

Post #1 of 9 (1810 views)
Permalink

[The Trac Project] #3167: Trac RSS feeds lack GUID elements

noreply at edgewall

Aug 16, 2006, 8:09 AM

Post #2 of 9 (1732 views)
Permalink

Re: [The Trac Project] #3167: Trac RSS feeds lack GUID elements [In reply to]

#3167: Trac RSS feeds lack GUID elements
--------------------------------+-------------------------------------------
Reporter: exarkun [at] divmod | Owner: jonas
Type: defect | Status: new
Priority: normal | Milestone:
Component: general | Version: 0.9.5
Severity: normal | Resolution:
Keywords: |
--------------------------------+-------------------------------------------
Comment (by anonymous):

I've attached a patch that adds a guid element to the Timeline feed... The
guid value is a md5 hash build from the link to, and the date of, the
event (hence, it is no !PermaLink, i.e. isPermaLink="false"!!)
The patches apply to Timeline.py and timeline_rss.cs of Trac version
0.9.6...

To find out more about the patch, have a look at http://dawis2.icb.uni-
due.de/jpddtools/AddGuidToTimelineFeedPatch.html

nik4536

--
Ticket URL: <http://trac.edgewall.org/ticket/3167#comment:1>
The Trac Project <http://trac.edgewall.com/>
_______________________________________________
Trac-Tickets mailing list
Trac-Tickets [at] lists
http://lists.edgewall.com/mailman/listinfo/trac-tickets

noreply at edgewall

Aug 16, 2006, 8:30 AM

Post #3 of 9 (1727 views)
Permalink

Re: [The Trac Project] #3167: Trac RSS feeds lack GUID elements [In reply to]

noreply at edgewall

Aug 16, 2006, 10:54 AM

Post #4 of 9 (1733 views)
Permalink

Re: [The Trac Project] #3167: Trac RSS feeds lack GUID elements [In reply to]

#3167: Trac RSS feeds lack GUID elements
--------------------------------+-------------------------------------------
Reporter: exarkun [at] divmod | Owner: jonas
Type: defect | Status: new
Priority: normal | Milestone:
Component: general | Version: 0.9.5
Severity: normal | Resolution:
Keywords: |
--------------------------------+-------------------------------------------
Comment (by mgood):

Replying to [comment:1 anonymous]:
> I've attached a patch that adds a guid element to the Timeline feed...

It's easier if you attach a single patch file instead of separate diffs
for each file you changed. See TracDev/SubmittingPatches.

I agree with cmlenz that we should use permalinks here. It seems like
this would require a change to the return value of
`ITimelineEventProvider.get_timeline_events` so each module could provide
its own permalinks, so this should probably be made before the 0.10
release, or post-poned to 0.11.

--
Ticket URL: <http://trac.edgewall.org/ticket/3167#comment:3>
The Trac Project <http://trac.edgewall.com/>
_______________________________________________
Trac-Tickets mailing list
Trac-Tickets [at] lists
http://lists.edgewall.com/mailman/listinfo/trac-tickets

noreply at edgewall

Aug 16, 2006, 11:25 AM

Post #5 of 9 (1723 views)
Permalink

Re: [The Trac Project] #3167: Trac RSS feeds lack GUID elements [In reply to]

#3167: Trac RSS feeds lack GUID elements
--------------------------------+-------------------------------------------
Reporter: exarkun [at] divmod | Owner: jonas
Type: defect | Status: new
Priority: normal | Milestone:
Component: general | Version: 0.9.5
Severity: normal | Resolution:
Keywords: |
--------------------------------+-------------------------------------------
Comment (by cmlenz):

Replying to [comment:3 mgood]:
> I agree with cmlenz that we should use permalinks here. It seems like
this would
> require a change to the return value of
`ITimelineEventProvider.get_timeline_events`
> so each module could provide its own permalinks, so this should probably
be made
> before the 0.10 release, or post-poned to 0.11.

I don't see why an interface change would be needed. If it makes sense for
the RSS feed to use a link to a specific version/comment of a page, why
shouldn't the timeline itself do the same? I.e. the providers ''should''
return unique links for the events, and the timeline RSS feed just reuses
those for the permalinks.

--
Ticket URL: <http://trac.edgewall.org/ticket/3167#comment:4>
The Trac Project <http://trac.edgewall.com/>
_______________________________________________
Trac-Tickets mailing list
Trac-Tickets [at] lists
http://lists.edgewall.com/mailman/listinfo/trac-tickets

noreply at edgewall

Oct 1, 2006, 7:45 AM

Post #6 of 9 (1710 views)
Permalink

Re: [The Trac Project] #3167: Trac RSS feeds lack GUID elements [In reply to]

#3167: Trac RSS feeds lack GUID elements
--------------------------------+-------------------------------------------
Reporter: exarkun [at] divmod | Owner: eblot
Type: defect | Status: assigned
Priority: normal | Milestone:
Component: general | Version: 0.9.5
Severity: normal | Resolution:
Keywords: |
--------------------------------+-------------------------------------------
Changes (by eblot):

* owner: jonas => eblot
* status: new => assigned

Comment:

I tried to have a look at this ticket. I'm attaching a patch.

For the timeline feed, we need to add an extra information to the HDF: the
date, unformatted.[[BR]]
This is required for wiki page edition, as the link is always the same for
any version of the same wiki page, which would make the ''guid'' not
unique.

For the feed an event is always unique:
* report: ticket number
* query: ticket number
* ticket: ticket and comment number
* repository log: version number (only tested w/ SVN)

I've submitted 5 feed samples (on for each feed source) to the
[http://validator.w3.org/feed/check.cgi w3c validator] and all of them
have been repored as valid, without warnings.

--
Ticket URL: <http://trac.edgewall.org/ticket/3167#comment:5>
The Trac Project <http://trac.edgewall.org/>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac Tickets" group.
To post to this group, send email to trac-tickets [at] googlegroups
To unsubscribe from this group, send email to trac-tickets-unsubscribe [at] googlegroups
For more options, visit this group at http://groups.google.se/group/trac-tickets
-~----------~----~----~----~------~----~------~--~---

noreply at edgewall

Oct 1, 2006, 7:46 AM

Post #7 of 9 (1700 views)
Permalink

Re: [The Trac Project] #3167: Trac RSS feeds lack GUID elements [In reply to]

noreply at edgewall

Oct 1, 2006, 8:22 AM

Post #8 of 9 (1712 views)
Permalink

Re: [The Trac Project] #3167: Trac RSS feeds lack GUID elements [In reply to]

noreply at edgewall

Oct 1, 2006, 10:39 AM

Post #9 of 9 (1698 views)
Permalink

Re: [The Trac Project] #3167: Trac RSS feeds lack GUID elements [In reply to]

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads