Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Trac: Tickets

[The Trac Project] #2558: Subversion diffs formatted with diff wiki processor are double-escaped

 

 

Trac tickets RSS feed   Index | Next | Previous | View Threaded


noreply at edgewall

Jan 4, 2006, 10:42 AM

Post #1 of 3 (267 views)
Permalink
[The Trac Project] #2558: Subversion diffs formatted with diff wiki processor are double-escaped

#2558: Subversion diffs formatted with diff wiki processor are double-escaped
-------------------------------------------------+--------------------------
Reporter: Bruce Christensen <trac [at] brucec> | Owner: jonas
Type: defect | Status: new
Priority: normal | Milestone: 0.9.3
Component: wiki | Version: devel
Severity: major | Keywords:
-------------------------------------------------+--------------------------
Subversion diffs in tickets, wiki pages, and attachments rendered using
the `diff` processor are double-escaped. Examples:

* Ticket: ticket:2432
* Attachment: attachment:ticket:2432:web_ui.py.patch
* Wiki: no current wiki pages use the diff processor, but I confirmed on
the SandBox page that it is indeed broken.

For example, this text:

{{{
#!html
<pre class="wiki">
{{{
#!diff
Index: test.txt
===================================================================
--- test.txt (revision 257)
+++ test.txt (working copy)
@@ -25,6 +25,7 @@
this is some text

this is more text
+ this is indented text with funky chars: <>"' and funky
spacing


hey
}}}
</pre>
}}}

is rendered as:

{{{
#!diff
Index: test.txt
===================================================================
--- test.txt (revision 257)
+++ test.txt (working copy)
@@ -25,6 +25,7 @@
this is some text

this is more text
+ this is indented text with funky chars: <>"' and funky
spacing


hey
}}}

Note that changesets shown in TracBrowser don't have this problem. Also,
non-Subversion diffs are fine. For example, this text:

{{{
#!html
<pre class="wiki">
{{{
#!diff
--- test1.txt Wed Jan 4 10:23:48 2006
+++ test2.txt Wed Jan 4 10:23:38 2006
@@ -1 +1,5 @@
This is a test of some stuff.
+
+Notice that this line has special <>" characters in it.
+
+ This line has some funky spacing.
}}}
</pre>
}}}

renders as:

{{{
#!diff
--- test1.txt Wed Jan 4 10:23:48 2006
+++ test2.txt Wed Jan 4 10:23:38 2006
@@ -1 +1,5 @@
This is a test of some stuff.
+
+Notice that this line has special <>" characters in it.
+
+ This line has some funky spacing.
}}}

--
Ticket URL: <http://projects.edgewall.com/trac/ticket/2558>
The Trac Project <http://trac.edgewall.com/>


noreply at edgewall

Jan 4, 2006, 10:56 AM

Post #2 of 3 (255 views)
Permalink
Re: [The Trac Project] #2558: Subversion diffs formatted with diff wiki processor are double-escaped [In reply to]

#2558: Subversion diffs formatted with diff wiki processor are double-escaped
-------------------------------------------------+--------------------------
Reporter: Bruce Christensen <trac [at] brucec> | Owner: cmlenz
Type: defect | Status: assigned
Priority: normal | Milestone: 0.9.3
Component: wiki | Version: devel
Severity: major | Resolution:
Keywords: |
-------------------------------------------------+--------------------------
Changes (by cmlenz):

* status: new => assigned
* owner: jonas => cmlenz

Comment:

Yeah, just noticed that too.

--
Ticket URL: <http://projects.edgewall.com/trac/ticket/2558>
The Trac Project <http://trac.edgewall.com/>


noreply at edgewall

Jan 4, 2006, 11:08 AM

Post #3 of 3 (257 views)
Permalink
Re: [The Trac Project] #2558: Subversion diffs formatted with diff wiki processor are double-escaped [In reply to]

#2558: Subversion diffs formatted with diff wiki processor are double-escaped
-------------------------------------------------+--------------------------
Reporter: Bruce Christensen <trac [at] brucec> | Owner: cmlenz
Type: defect | Status: closed
Priority: normal | Milestone: 0.9.3
Component: wiki | Version: devel
Severity: major | Resolution: fixed
Keywords: |
-------------------------------------------------+--------------------------
Changes (by cmlenz):

* status: assigned => closed
* resolution: => fixed

Comment:

Should be fixed in [2730], [2731].

--
Ticket URL: <http://projects.edgewall.com/trac/ticket/2558>
The Trac Project <http://trac.edgewall.com/>

Trac tickets RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.