Mailing List Archive: Trac: Tickets

[The Trac Project] #2006: broken images and attachments. SSL related.

Index | Next | Previous | View Threaded

noreply at edgewall

Sep 5, 2005, 4:47 AM

Post #1 of 20 (4710 views)
Permalink

[The Trac Project] #2006: broken images and attachments. SSL related.

#2006: broken images and attachments. SSL related.
-------------------------------------------------+--------------------------
Reporter: tiger [at] tadol | Owner: jonas
Type: defect | Status: new
Priority: normal | Milestone:
Component: browser | Version: devel
Severity: normal | Keywords: https ssl broken images attachments |
-------------------------------------------------+--------------------------
There is a problem in viewing images and dowloading attachments
in https mode.

Symptoms:

1. Attachment image being show once normally.
2. When you refresh page browser reports that image is broken.
3. Again refresh - image again being shown normally.

This goes in a cyclic fashion.

With attachments also problem that attachment is being cached by
the browser. So you often getting stale files after attachment was
updated.

I found that that's all related to the cache control headers.

Here is a patch which fixes such behaviour:

{{{
Index: trac/web/main.py
===================================================================
--- trac/web/main.py (revision 2067)
+++ trac/web/main.py (working copy)
@@ -218,9 +218,12 @@
self.send_response(200)
if not mimetype:
mimetype = mimetypes.guess_type(path)[0]
+
+ self.send_header('Cache-control', 'must-revalidate')
+ self.send_header('Expires', 'Fri, 01 Jan 1999 00:00:00 GMT')
self.send_header('Content-Type', mimetype)
self.send_header('Content-Length', stat.st_size)
- self.send_header('Last-Modified', last_modified)
+ #self.send_header('Last-Modified', last_modified)
self.end_headers()

if self.method != 'HEAD':
}}}

--
Ticket URL: <http://projects.edgewall.com/trac/ticket/2006>
The Trac Project <http://trac.edgewall.com/>

noreply at edgewall

Sep 5, 2005, 5:06 AM

Post #2 of 20 (4632 views)
Permalink

Re: [The Trac Project] #2006: broken images and attachments. SSL related. [In reply to]

noreply at edgewall

Sep 5, 2005, 8:51 AM

Post #3 of 20 (4633 views)
Permalink

Re: [The Trac Project] #2006: broken images and attachments. SSL related. [In reply to]

#2006: broken images and attachments. SSL related.
-------------------------------------------------+--------------------------
Reporter: tiger [at] tadol | Owner: jonas
Type: defect | Status: new
Priority: normal | Milestone:
Component: browser | Version: devel
Severity: normal | Resolution:
Keywords: https ssl broken images attachments |
-------------------------------------------------+--------------------------
Comment (by tiger [at] tadol):

Ok. It's my folt. Things tends to change rapidly...
Below patch for the today's trunk.

{{{
Index: trac/web/api.py
===================================================================
--- trac/web/api.py (revision 2184)
+++ trac/web/api.py (working copy)
@@ -184,9 +184,12 @@
self.send_response(200)
if not mimetype:
mimetype = mimetypes.guess_type(path)[0]
+
+ self.send_header('Cache-control', 'must-revalidate')
+ self.send_header('Expires', 'Fri, 01 Jan 1999 00:00:00 GMT')
self.send_header('Content-Type', mimetype)
self.send_header('Content-Length', stat.st_size)
- self.send_header('Last-Modified', last_modified)
+ #self.send_header('Last-Modified', last_modified)
self._send_cookie_headers()
self.end_headers()
}}}

--
Ticket URL: <http://projects.edgewall.com/trac/ticket/2006>
The Trac Project <http://trac.edgewall.com/>

noreply at edgewall

Sep 19, 2005, 4:08 AM

Post #4 of 20 (4657 views)
Permalink

Re: [The Trac Project] #2006: broken images and attachments. SSL related. [In reply to]

noreply at edgewall

Oct 19, 2005, 5:16 AM

Post #5 of 20 (4632 views)
Permalink

Re: [The Trac Project] #2006: broken images and attachments. SSL related. [In reply to]

noreply at edgewall

Oct 25, 2005, 6:33 AM

Post #6 of 20 (4647 views)
Permalink

Re: [The Trac Project] #2006: broken images and attachments. SSL related. [In reply to]

noreply at edgewall

Oct 25, 2005, 1:45 PM

Post #7 of 20 (4638 views)
Permalink

Re: [The Trac Project] #2006: broken images and attachments. SSL related. [In reply to]

noreply at edgewall

Oct 25, 2005, 1:51 PM

Post #8 of 20 (4634 views)
Permalink

Re: [The Trac Project] #2006: broken images and attachments. SSL related. [In reply to]

noreply at edgewall

Oct 26, 2005, 5:46 PM

Post #9 of 20 (4649 views)
Permalink

Re: [The Trac Project] #2006: broken images and attachments. SSL related. [In reply to]

noreply at edgewall

Oct 26, 2005, 9:03 PM

Post #10 of 20 (4640 views)
Permalink

Re: [The Trac Project] #2006: broken images and attachments. SSL related. [In reply to]

noreply at edgewall

Dec 1, 2005, 8:32 AM

Post #11 of 20 (4630 views)
Permalink

Re: [The Trac Project] #2006: broken images and attachments. SSL related. [In reply to]

noreply at edgewall

Dec 23, 2005, 2:50 PM

Post #12 of 20 (4655 views)
Permalink

Re: [The Trac Project] #2006: broken images and attachments. SSL related. [In reply to]

#2006: broken images and attachments. SSL related.
-------------------------------------------------+--------------------------
Reporter: tiger [at] tadol | Owner: jonas
Type: defect | Status: new
Priority: normal | Milestone: 0.9.3
Component: general | Version: devel
Severity: normal | Resolution:
Keywords: https ssl broken images attachments |
-------------------------------------------------+--------------------------
Changes (by nielsen [at] memberwebs):

* cc: tiger [at] tadol => tiger [at] tadol, nielsen [at] memberwebs

Comment:

I have this problem with version 0.9.2 running as in as a CGI under Apache
2.0.55.

I'm using Firefox with Live HTTP Headers to narrow down the problem. Every
second request to get the a CSS (or image) turns up like this:

{{{
http://dev/projects/network/chrome/common/css/trac.css

GET /projects/network/chrome/common/css/trac.css HTTP/1.1
Host: dev
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12)
Gecko/20051010 Firefox/1.0.7 (Ubuntu package 1.0.7)
Accept:
text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5
Accept-Language: en-us,en;q=0.5
Accept-Encoding: gzip,deflate
Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7
Keep-Alive: 300
Connection: keep-alive
Cookie: trac_session=f4964209c822ff5dc3f3837e
If-Modified-Since: Mon, 05 Dec 2005 18:20:12 GMT
Cache-Control: max-age=0

HTTP/1.x 200 OK
Date: Fri, 23 Dec 2005 22:36:47 GMT
Server: Apache/2.0.55 (FreeBSD) DAV/2 SVN/1.3.0-rc4
Connection: close
}}}

* It only occurs when 'If-Modified-Since' is sent from the browser.
* The above patch does suppress the behavior.
* When running under Apache 1.3 the problem does not occur.

--
Ticket URL: <http://projects.edgewall.com/trac/ticket/2006>
The Trac Project <http://trac.edgewall.com/>

noreply at edgewall

Jan 4, 2006, 2:15 AM

Post #13 of 20 (4655 views)
Permalink

Re: [The Trac Project] #2006: broken images and attachments. SSL related. [In reply to]

#2006: broken images and attachments. SSL related.
-------------------------------------------------+--------------------------
Reporter: tiger [at] tadol | Owner: jonas
Type: defect | Status: new
Priority: normal | Milestone: 0.9.3
Component: general | Version: devel
Severity: normal | Resolution:
Keywords: https ssl broken images attachments |
-------------------------------------------------+--------------------------
Comment (by markus):

I'm running TracCgi on IIS in https mode myself and have never seen this
reported behavior (as I already said above).

To me this seems like it has nothing to do with SSL but with TracCgi and
Apache. You can find many error reports about a race condition in Apache
when the Browser sends an `Is-Modified-Since` header.

So, I'd rather try to speed up the response header transaction than remove
the `Last-Modified` header part. You may try the following patch below:

{{{
#!diff
Index: trac/web/cgi_frontend.py
===================================================================
--- trac/web/cgi_frontend.py (revision 2721)
+++ trac/web/cgi_frontend.py (working copy)
@@ -70,6 +70,9 @@
def write(self, data):
return self.__output.write(data)

+ def flush(self):
+ return self.__output.flush()
+
def get_header(self, name):
return self.__environ.get('HTTP_' + re.sub('-', '_',
name.upper()))

@@ -81,6 +84,7 @@

def end_headers(self):
self.write('\r\n')
+ self.flush()

class TracFieldStorage(cgi.FieldStorage):
}}}

--
Ticket URL: <http://projects.edgewall.com/trac/ticket/2006>
The Trac Project <http://trac.edgewall.com/>

noreply at edgewall

Jan 8, 2006, 6:24 AM

Post #14 of 20 (4626 views)
Permalink

Re: [The Trac Project] #2006: broken images and attachments. SSL related. [In reply to]

noreply at edgewall

Jan 23, 2006, 2:22 PM

Post #15 of 20 (4632 views)
Permalink

Re: [The Trac Project] #2006: broken images and attachments. SSL related. [In reply to]

noreply at edgewall

Feb 12, 2006, 4:13 AM

Post #16 of 20 (4634 views)
Permalink

Re: [The Trac Project] #2006: broken images and attachments. SSL related. [In reply to]

noreply at edgewall

Feb 12, 2006, 5:15 AM

Post #17 of 20 (4644 views)
Permalink

Re: [The Trac Project] #2006: broken images and attachments. SSL related. [In reply to]

noreply at edgewall

Feb 12, 2006, 6:24 AM

Post #18 of 20 (4622 views)
Permalink

Re: [The Trac Project] #2006: broken images and attachments. SSL related. [In reply to]

noreply at edgewall

Feb 13, 2006, 7:53 AM

Post #19 of 20 (4633 views)
Permalink

Re: [The Trac Project] #2006: broken images and attachments. SSL related. [In reply to]

noreply at edgewall

Oct 1, 2006, 3:55 AM

Post #20 of 20 (4406 views)
Permalink

Re: [The Trac Project] #2006: broken images and attachments. SSL related. [In reply to]

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads