Mailing List Archive: SPF: Devel

NetAddr::IP's use of $& and $`

Index | Next | Previous | View Threaded

spamassassin at dostech

Jun 6, 2007, 9:46 AM

Post #1 of 5 (2066 views)
Permalink

NetAddr::IP's use of $& and $`

Hi Luis and Michael,

Would you be able to consider reworking NetAddr::IP to avoid the use of,
or loading of anything that uses, $& or $` so that the huge speed
penalty imposed by Perl when doing so can be avoided?

NetAddr::IP is used by Mail::SPF which is used by Mail::SpamAssassin.
Apache SpamAssassin needs to avoid the speed penalty imposed by $& and
$` at all costs.

Please see SpamAssassin bug 5312 for some background on this:
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5312

Thanks!

Regards,

Daryl C. W. O'Shea
Apache SpamAssassin PMC Member

-------------------------------------------
-----------------------------------------------------------------------
To unsubscribe, change your address, or temporarily deactivate your
subscription,
please go to http://v2.listbox.com/member/?member_id=1311533&user_secret=456ecacd
Powered by Listbox: http://www.listbox.com

spamassassin at dostech

Jun 6, 2007, 2:36 PM

Post #2 of 5 (2003 views)
Permalink

Re: NetAddr::IP's use of $& and $` [In reply to]

Luis E. Muñoz wrote:
>
> On Jun 6, 2007, at 12:46 PM, Daryl C. W. O'Shea wrote:
>
>> Would you be able to consider reworking NetAddr::IP to avoid the use
>> of, or loading of anything that uses, $& or $` so that the huge speed
>> penalty imposed by Perl when doing so can be avoided?
>
> Please find attached the next RC for NetAddr::IP - I'll await your
> confirmation that your tests pass before uploading to CPAN.

I will install it and run a make test for both Mail::SPF and
Mail::SpamAssassin (it does some more SPF testing).

I'll also forward a copy to Mark Martinec (amavisd-new maintainer) who
spotted the issue and Julian Mehnle (Mail::SPF maintainer).

> Thanks for the report.

No problem. Thank you for the super fast response!

Daryl

-------------------------------------------
-----------------------------------------------------------------------
To unsubscribe, change your address, or temporarily deactivate your
subscription,
please go to http://v2.listbox.com/member/?member_id=1311533&user_secret=456ecacd
Powered by Listbox: http://www.listbox.com

scott at kitterman

Jun 6, 2007, 2:59 PM

Post #3 of 5 (1977 views)
Permalink

Re: Re: NetAddr::IP's use of $& and $` [In reply to]

On Wed, 06 Jun 2007 17:36:49 -0400 "Daryl C. W. O'Shea" <spamassassin [at] dostech> wrote:
>Luis E. Muñoz wrote:
>>
>> On Jun 6, 2007, at 12:46 PM, Daryl C. W. O'Shea wrote:
>>
>>> Would you be able to consider reworking NetAddr::IP to avoid the use
>>> of, or loading of anything that uses, $& or $` so that the huge speed
>>> penalty imposed by Perl when doing so can be avoided?
>>
>> Please find attached the next RC for NetAddr::IP - I'll await your
>> confirmation that your tests pass before uploading to CPAN.
>
>I will install it and run a make test for both Mail::SPF and
>Mail::SpamAssassin (it does some more SPF testing).
>
>I'll also forward a copy to Mark Martinec (amavisd-new maintainer) who
>spotted the issue and Julian Mehnle (Mail::SPF maintainer).
>
Please let me know too so I can get Ubuntu updated.

Scott K

-------------------------------------------
-----------------------------------------------------------------------
To unsubscribe, change your address, or temporarily deactivate your
subscription,
please go to http://v2.listbox.com/member/?member_id=1311533&user_secret=456ecacd
Powered by Listbox: http://www.listbox.com

spamassassin at dostech

Jun 6, 2007, 8:15 PM

Post #4 of 5 (1983 views)
Permalink

Re: NetAddr::IP's use of $& and $` [In reply to]

NetAddr::IP v4.007 removes everything that would cause PL_sawampersand
to be set to true.

Daryl

Daryl C. W. O'Shea wrote:
> Hi Luis and Michael,
>
> Would you be able to consider reworking NetAddr::IP to avoid the use of,
> or loading of anything that uses, $& or $` so that the huge speed
> penalty imposed by Perl when doing so can be avoided?
>
> NetAddr::IP is used by Mail::SPF which is used by Mail::SpamAssassin.
> Apache SpamAssassin needs to avoid the speed penalty imposed by $& and
> $` at all costs.
>
> Please see SpamAssassin bug 5312 for some background on this:
> http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5312
>
> Thanks!
>
> Regards,
>
> Daryl C. W. O'Shea
> Apache SpamAssassin PMC Member

-------------------------------------------
-----------------------------------------------------------------------
To unsubscribe, change your address, or temporarily deactivate your
subscription,
please go to http://v2.listbox.com/member/?member_id=1311533&user_secret=456ecacd
Powered by Listbox: http://www.listbox.com

julian at mehnle

Jun 7, 2007, 3:07 AM

Post #5 of 5 (1990 views)
Permalink

Re: NetAddr::IP's use of $& and $` [In reply to]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Daryl C. W. O'Shea wrote:
> NetAddr::IP v4.007 removes everything that would cause PL_sawampersand
> to be set to true.

The next Mail::SPF release will explicitly _recommend_ NetAddr::IP v4.007,
but will (obviously) still _strictly_require_ only v4.000.

Present Mail::SPF releases should work fine as-is with NetAddr::IP v4.007.

Julian.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFGZ9jNwL7PKlBZWjsRAhhwAJ9TCarw4e5tasf7xQHQf5hGfEv27ACfSe38
ywaaKXwcBMYXiowP/h/XHgw=
=RfId
-----END PGP SIGNATURE-----

-------------------------------------------
-----------------------------------------------------------------------
To unsubscribe, change your address, or temporarily deactivate your
subscription,
please go to http://v2.listbox.com/member/?member_id=1311533&user_secret=456ecacd
Powered by Listbox: http://www.listbox.com

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads