Mailing List Archive: SpamAssassin: devel

[Bug 6820] listpromotable throwing an error

Index | Next | Previous | View Threaded

bugzilla-daemon at bugzilla

Aug 8, 2012, 6:46 AM

Post #1 of 5 (222 views)
Permalink

[Bug 6820] listpromotable throwing an error

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6820

--- Comment #1 from Mark Martinec <Mark.Martinec [at] ijs> ---
> + /local/perl586/bin/perl ./build/mkupdates/listpromotable
> Use of uninitialized value in concatenation (.) or string at
> ./build/mkupdates/listpromotable line 213.

> if ($tfs =~ /\bpublish\b/) {
> if (defined $1) {
> $notes = "tflags ".$1;
> } else {
> #BUG 6820: What's this supposed to do because I don't see a possibility that $1 is set
> print "DEBUG: \$1 isn't defined - $tfs\n";
> }
> goto publish;
> }
> }

Guessing from the analogy further down in:

if ($tfs && $tfs =~ /\b(userconf|learn|net)\b/) {
$notes = "tflags ".$1;
goto publish;
}

the /\bpublish\b/ was supposed to be a /\b(publish)\b/

--
You are receiving this mail because:
You are the assignee for the bug.

bugzilla-daemon at bugzilla

Aug 8, 2012, 6:53 AM

Post #2 of 5 (218 views)
Permalink

[Bug 6820] listpromotable throwing an error [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6820

--- Comment #2 from Kevin A. McGrail <kmcgrail [at] pccc> ---
Adding this:

Index: /usr/src/Mail-SpamAssassin/trunk/build/mkupdates/listpromotable
===================================================================
--- /usr/src/Mail-SpamAssassin/trunk/build/mkupdates/listpromotable
(revision 1353252)
+++ /usr/src/Mail-SpamAssassin/trunk/build/mkupdates/listpromotable
(working copy)
@@ -210,7 +210,12 @@
next if ($tfs =~ /\bnopublish\b/);

if ($tfs =~ /\bpublish\b/) {
- $notes = "tflags ".$1;
+ if (defined $1) {
+ $notes = "tflags ".$1;
+ } else {
+ #BUG 6820: What's this supposed to do because I don't see a
possibility that $1 is set
+ print "DEBUG: \$1 isn't defined - $tfs\n";
+ }
goto publish;
}
}

svn commit /usr/src/Mail-SpamAssassin/trunk/build/mkupdates/listpromotable -m
'DEBUG for bug 6820'
Sending /usr/src/Mail-SpamAssassin/trunk/build/mkupdates/listpromotable
Transmitting file data .
Committed revision 1370753.

Anyone have any idea what $1 is supposed to contain because I can't see what it
would possibly do?

--
You are receiving this mail because:
You are the assignee for the bug.

bugzilla-daemon at bugzilla

Aug 8, 2012, 7:21 AM

Post #3 of 5 (218 views)
Permalink

[Bug 6820] listpromotable throwing an error [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6820

John Hardin <jhardin [at] impsec> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |jhardin [at] impsec

--- Comment #3 from John Hardin <jhardin [at] impsec> ---
(In reply to comment #2)
> Anyone have any idea what $1 is supposed to contain because I can't see what
> it would possibly do?

Well, if Mark is right and it's supposed to be/\b(publish)\b/, then $1 would be
"publish", no?

--
You are receiving this mail because:
You are the assignee for the bug.

bugzilla-daemon at bugzilla

Aug 8, 2012, 7:43 AM

Post #4 of 5 (220 views)
Permalink

[Bug 6820] listpromotable throwing an error [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6820

Kevin A. McGrail <kmcgrail [at] pccc> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |kmcgrail [at] pccc

--- Comment #4 from Kevin A. McGrail <kmcgrail [at] pccc> ---
(In reply to comment #3)
> (In reply to comment #2)
> > Anyone have any idea what $1 is supposed to contain because I can't see what
> > it would possibly do?
>
> Well, if Mark is right and it's supposed to be/\b(publish)\b/, then $1 would
> be "publish", no?

Yep, I believe Mark is right. He responded to my svn submit faster than I
entered by bug updates. ;-)

svn commit -m 'Adding parens on regex to define $1 for bug 6820'
/usr/src/Mail-SpamAssassin/trunk/build/mkupdates/listpromotable
Sending build/mkupdates/listpromotable
Transmitting file data .
Committed revision 1370784.

This can likely be considered resolved but I want to look at the cron output
tonight and likely remove the DEBUG.

--
You are receiving this mail because:
You are the assignee for the bug.

bugzilla-daemon at bugzilla

Aug 14, 2012, 7:46 PM

Post #5 of 5 (195 views)
Permalink

[Bug 6820] listpromotable throwing an error [In reply to]

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads