
bugzilla-daemon at bugzilla
Jun 26, 2012, 12:41 PM
Post #1 of 2
(157 views)
Permalink
|
|
[Bug 6807] TVD_RCVD_SINGLE regex line
|
|
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6807 --- Comment #1 from Mark Martinec <Mark.Martinec [at] ijs> --- > state that a domain name can consist of lower and upper case characters and > that it is to be case insensitive. However TVD_RCVD_SINGLE in 72_active.cf > only checks for all lower case domain names: > header TVD_RCVD_SINGLE Received =~ /^from\s+(?!localhost)[^\s.a-z0-9-]+\s/ > I believe it should be: > header TVD_RCVD_SINGLE Received =~ /^from\s+(?!localhost)[^\s.a-zA-Z0-9-]+\s/ You are right about case insensitivity of domain names. But RFC 5321 also states that EHLO name should be a FQDN or an address literal: The domain name given in the EHLO command MUST be either a primary host name (a domain name that resolves to an address RR) or, if the host has no name, an address literal So even if a domain name is all capitals, it should contain at least one dot, thus saving it from the TVD_RCVD_SINGLE rule. > There's probably more that this change should be expanded to, this is just > the one that I see hitting alot. Please advise if I missed the mark here or > if this is done for a specific reason. The rule is inexact one way or another. I don't know good does it do in Q&A tests. The problem would be if a perfectly valid Received header field would fire it, but apparently this is not the case. -- You are receiving this mail because: You are the assignee for the bug.
|