Mailing List Archive: SpamAssassin: devel

[Bug 6805] subject_is_all_caps

Index | Next | Previous | View Threaded

bugzilla-daemon at bugzilla

Jun 12, 2012, 6:19 AM

Post #1 of 7 (323 views)
Permalink

[Bug 6805] subject_is_all_caps

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6805

Jake <stoked10 [at] hotmail> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |stoked10 [at] hotmail

--- Comment #1 from Jake <stoked10 [at] hotmail> ---
Sorry, AW: can also be added to that. Thanks

--
You are receiving this mail because:
You are the assignee for the bug.

bugzilla-daemon at bugzilla

Jun 12, 2012, 1:30 PM

Post #2 of 7 (314 views)
Permalink

[Bug 6805] subject_is_all_caps [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6805

Kevin A. McGrail <kmcgrail [at] pccc> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |kmcgrail [at] pccc

--- Comment #2 from Kevin A. McGrail <kmcgrail [at] pccc> ---
(In reply to comment #1)
> Sorry, AW: can also be added to that. Thanks

Jake, I'm open to adding something for that. Perhaps it would trigger a
BLANK_FWD_RE_SUBJECT rule or something like that instead.

Can you work on a patch to submit?

--
You are receiving this mail because:
You are the assignee for the bug.

bugzilla-daemon at bugzilla

Jun 12, 2012, 2:27 PM

Post #3 of 7 (311 views)
Permalink

[Bug 6805] subject_is_all_caps [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6805

RW <rwmaillists [at] googlemail> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |rwmaillists [at] googlemail

--- Comment #3 from RW <rwmaillists [at] googlemail> ---
I think it would be a good idea to strip standard prefixes whatever the case. I
don't see the point of a subject that starts with Re: and continues in capitals
being let off because of the "e".

The specific example of "RE:5" shouldn't be an problem because it's less than
the minimum of 10 characters.

--
You are receiving this mail because:
You are the assignee for the bug.

bugzilla-daemon at bugzilla

Jun 12, 2012, 2:29 PM

Post #4 of 7 (313 views)
Permalink

[Bug 6805] subject_is_all_caps [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6805

--- Comment #4 from Kevin A. McGrail <kmcgrail [at] pccc> ---
(In reply to comment #3)
> I think it would be a good idea to strip standard prefixes whatever the
> case. I don't see the point of a subject that starts with Re: and continues
> in capitals being let off because of the "e".
>
> The specific example of "RE:5" shouldn't be an problem because it's less
> than the minimum of 10 characters.

My thoughts were to switch the case on his patch so tr instead of s. but we
can look at some improvement and get some more eyes on that code!

--
You are receiving this mail because:
You are the assignee for the bug.

bugzilla-daemon at bugzilla

Jun 13, 2012, 3:58 AM

Post #5 of 7 (308 views)
Permalink

[Bug 6805] subject_is_all_caps [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6805

--- Comment #5 from Jake <stoked10 [at] hotmail> ---
I'm not certain what you need from me for a patch, but I'm using this:

$subject =~ s/[RE:|FWD:|FW:|AW:]//g;

in HeaderEval.pm.

My example was a bad one, maybe a better one is "RE: 123456789" or even
"RE:RE:RE:RE: 123" basically I believe RE should not be apart of the subject
line evaluation. This additional also helps if you ever get a non-encoded
special or foreign character subject. In that case you pass the greater than 10
test, but when all characters but a-zA-Z are stripped, you are usually only
left with "RE or FWD" which fails the all caps test.

Another potentially less desirable fix would be to move the "$subject =~
s/[^a-zA-Z]//g;" line higher in the sub before the check for 10.

-Jake

--
You are receiving this mail because:
You are the assignee for the bug.

bugzilla-daemon at bugzilla

Jun 13, 2012, 4:24 AM

Post #6 of 7 (311 views)
Permalink

[Bug 6805] subject_is_all_caps [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6805

--- Comment #6 from Jake <stoked10 [at] hotmail> ---
(In reply to comment #3)
> I think it would be a good idea to strip standard prefixes whatever the
> case. I don't see the point of a subject that starts with Re: and continues
> in capitals being let off because of the "e".
>

That's an excellent point!I altered my line to:

$subject =~ tr/RE:|FWD:|FW:|AW://gi;

--
You are receiving this mail because:
You are the assignee for the bug.

axb.lists at gmail

Jun 27, 2012, 7:27 AM

Post #7 of 7 (269 views)
Permalink

Re: [Bug 6805] subject_is_all_caps [In reply to]

On 06/27/2012 04:00 PM, bugzilla-daemon [at] bugzilla wrote:
> https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6805
>
> Mark Martinec <Mark.Martinec [at] ijs> changed:
>
> What |Removed |Added
> ----------------------------------------------------------------------------
> Version|unspecified |3.3.2
> Target Milestone|Undefined |3.4.0
>
> --- Comment #7 from Mark Martinec <Mark.Martinec [at] ijs> ---
> I went for:
> $subject =~ s/^(?:(?:Re|Fwd|Fw|Aw|Antwort|Sv):\s*)+//i;
>
>
> trunk (3.4):
> Bug 6805: subject_is_all_caps - strip prefixes like Re:, Fwd:
> Sending lib/Mail/SpamAssassin/Plugin/HeaderEval.pm
> Committed revision 1354506.
>

while you're at it:
WG: (german "Weiterleitung" / Forward)
TR: french?

Axb

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads