Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: SpamAssassin: devel

[Bug 6801] UNPARSEABLE_RELAY returns numeric result

 

 

SpamAssassin devel RSS feed   Index | Next | Previous | View Threaded


bugzilla-daemon at bugzilla

Jun 5, 2012, 11:28 AM

Post #1 of 5 (201 views)
Permalink
[Bug 6801] UNPARSEABLE_RELAY returns numeric result

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6801

--- Comment #1 from Mark Martinec <Mark.Martinec [at] ijs> ---
> Suggested fix:
> header __UNPARSEABLE_RELAY eval:check_relays_unparseable()
> meta UNPARSEABLE_RELAY (__UNPARSEABLE_RELAY >= 1)

+1
Fine with me, the change looks innocent enough and may prevent surprises.

--
You are receiving this mail because:
You are the assignee for the bug.


bugzilla-daemon at bugzilla

Jun 5, 2012, 11:51 AM

Post #2 of 5 (191 views)
Permalink
[Bug 6801] UNPARSEABLE_RELAY returns numeric result [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6801

Kevin A. McGrail <kmcgrail [at] pccc> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |kmcgrail [at] pccc

--- Comment #2 from Kevin A. McGrail <kmcgrail [at] pccc> ---
(In reply to comment #1)
> > Suggested fix:
> > header __UNPARSEABLE_RELAY eval:check_relays_unparseable()
> > meta UNPARSEABLE_RELAY (__UNPARSEABLE_RELAY >= 1)
>
> +1
> Fine with me, the change looks innocent enough and may prevent surprises.

I feel uncomfortable voting on this because I don't know what we are doing with
it.

Is this the proposed change?

Index: 20_head_tests.cf
===================================================================
--- 20_head_tests.cf (revision 1346433)
+++ 20_head_tests.cf (working copy)
@@ -559,12 +559,14 @@

ifplugin Mail::SpamAssassin::Plugin::RelayEval

-header UNPARSEABLE_RELAY eval:check_relays_unparseable()
-tflags UNPARSEABLE_RELAY userconf
+header __UNPARSEABLE_RELAY eval:check_relays_unparseable()
+tflags __UNPARSEABLE_RELAY userconf
+
+meta UNPARSEABLE_RELAY (__UNPARSEABLE_RELAY >= 1)
+tflags UNPARSEABLE_RELAY userconf
describe UNPARSEABLE_RELAY Informational: message has unparseable relay
lines


-
header RCVD_HELO_IP_MISMATCH eval:helo_ip_mismatch()
describe RCVD_HELO_IP_MISMATCH Received: HELO and IP do not match, but should

--
You are receiving this mail because:
You are the assignee for the bug.


bugzilla-daemon at bugzilla

Jun 15, 2012, 7:34 AM

Post #3 of 5 (158 views)
Permalink
[Bug 6801] UNPARSEABLE_RELAY returns numeric result [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6801

RW <rwmaillists [at] googlemail> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |rwmaillists [at] googlemail

--- Comment #3 from RW <rwmaillists [at] googlemail> ---
Since someone may actually find a use for the count, I'd suggest giving the
hidden rule a more meaningful name like __UNPARSEABLE_RELAY_COUNT.

Currently UNPARSEABLE_RELAY doesn't seem to be used anywhere, it's purely
informational.

--
You are receiving this mail because:
You are the assignee for the bug.


bugzilla-daemon at bugzilla

Jun 15, 2012, 8:16 AM

Post #4 of 5 (157 views)
Permalink
[Bug 6801] UNPARSEABLE_RELAY returns numeric result [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6801

Cedric Knight <cedric [at] gn> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |cedric [at] gn

--- Comment #4 from Cedric Knight <cedric [at] gn> ---
+1 for the name __UNPARSEABLE_RELAY_COUNT

Otherwise the change is as in Comment 2.

--
You are receiving this mail because:
You are the assignee for the bug.


bugzilla-daemon at bugzilla

Jun 15, 2012, 7:32 PM

Post #5 of 5 (154 views)
Permalink
[Bug 6801] UNPARSEABLE_RELAY returns numeric result [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6801

Kevin A. McGrail <kmcgrail [at] pccc> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED

--- Comment #5 from Kevin A. McGrail <kmcgrail [at] pccc> ---
thanks. Good comments.

svn commit rules/20_head_tests.cf -m 'Fix for unparseable relay suggested by
Cedric Knight bug 6801'
Sending rules/20_head_tests.cf
Transmitting file data .
Committed revision 1350841.

--
You are receiving this mail because:
You are the assignee for the bug.

SpamAssassin devel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.