Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: SpamAssassin: devel

[Bug 6782] New: TLD update handling / RegistrarBoundaries need improving

 

 

SpamAssassin devel RSS feed   Index | Next | Previous | View Threaded


bugzilla-daemon at bugzilla

Apr 1, 2012, 5:41 AM

Post #1 of 1 (107 views)
Permalink
[Bug 6782] New: TLD update handling / RegistrarBoundaries need improving

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6782

Bug #: 6782
Summary: TLD update handling / RegistrarBoundaries need
improving
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P2
Component: Libraries
AssignedTo: dev [at] spamassassin
ReportedBy: hege [at] hege
Classification: Unclassified


We have config options util_rb_tld, 2tld etc. What these do is add values to
Mail::SpamAssassin::Util::RegistrarBoundaries::VALID_TLDS etc from Conf.pm.

Problem is that only some very internal SA functions can make use of the
updates. I couldn't figure out how this exactly works. Atleast HTML parser etc
see them, since URIBL uses those results and util_rb_tld does query new
domains/TLDs using it (for uris with scheme).

Anything that uses the static $VALID_TLDS_RE will not see updates. This
includes schemeless uri parsing (so URIBL does not work for those) and
FreeMail.

Anything that uses Mail::SpamAssassin::Util::RegistrarBoundaries "directly"
will not see those updates. Some suspect code:

./Plugin/URIDNSBL.pm: $nsrhblstr =
Mail::SpamAssassin::Util::RegistrarBoundaries::trim_domain($nsmatch);
./Plugin/HTTPSMismatch.pm: $uri =
Mail::SpamAssassin::Util::RegistrarBoundaries::trim_domain($uri);
./Plugin/HTTPSMismatch.pm: undef $uri unless
(Mail::SpamAssassin::Util::RegistrarBoundaries::is_domain_valid($uri));
./Plugin/HTTPSMismatch.pm: $https =
Mail::SpamAssassin::Util::RegistrarBoundaries::trim_domain($https);
./Plugin/HTTPSMismatch.pm: undef $https unless
(Mail::SpamAssassin::Util::RegistrarBoundaries::is_domain_valid($https));
./Plugin/WLBLEval.pm:
Mail::SpamAssassin::Util::RegistrarBoundaries::split_domain($addr_domain);
./Plugin/WLBLEval.pm:
Mail::SpamAssassin::Util::RegistrarBoundaries::split_domain($relay_rdns);
./Plugin/HeaderEval.pm: $dom =
Mail::SpamAssassin::Util::RegistrarBoundaries::trim_domain($dom);
./Plugin/HeaderEval.pm:
(Mail::SpamAssassin::Util::RegistrarBoundaries::is_domain_valid($dom));
./Util.pm: $uri =
Mail::SpamAssassin::Util::RegistrarBoundaries::trim_domain($uri);
./Util.pm:
(Mail::SpamAssassin::Util::RegistrarBoundaries::is_domain_valid($uri));

Some serious reorganization is needed if we want to properly support TLD list
updates via sa-update.

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

SpamAssassin devel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.