Mailing List Archive: SpamAssassin: devel

[Bug 6241] mkrules does not understand newer options and 'else'

Index | Next | Previous | View Threaded

bugzilla-daemon at bugzilla

Nov 24, 2009, 3:45 AM

Post #1 of 6 (535 views)
Permalink

[Bug 6241] mkrules does not understand newer options and 'else'

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6241

Mark Martinec <Mark.Martinec [at] ijs> changed:

What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|Undefined |3.3.1

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

bugzilla-daemon at bugzilla

Dec 7, 2009, 8:19 AM

Post #2 of 6 (444 views)
Permalink

[Bug 6241] mkrules does not understand newer options and 'else' [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6241

Mark Martinec <Mark.Martinec [at] ijs> changed:

What |Removed |Added
----------------------------------------------------------------------------
Priority|P5 |P3
Target Milestone|3.3.1 |3.3.0
Severity|minor |normal

--- Comment #1 from Mark Martinec <Mark.Martinec [at] ijs> 2009-12-07 08:19:25 UTC ---
Don't know much about 'build/mkrules', except that it does not handle well
the nested if/else/endif in rules. The rulesrc/sandbox/khopesh/20_khop_bl.cf
is currently clobbered (by me - partly commented out) to at least pass syntax
checks (lint), but as a result we have a duplicate rule __NOT_SPOOFED in
72_active.cf and in the published tarball.

I'm changing target to 3.3.0 and bringing up priority.

Either the build/mkrules should be fixed (and 20_khop_bl.cf restored),
or nested ifs should be banned from rules and 20_khop_bl.cf (and
72_active.cf) changed accordingly.

Btw, the DKIM_VERIFIED in 20_khop_bl.cf should be renamed to DKIM_VALID
(because the DKIM_VERIFIED has a score 0 now, so the meta rule __NOT_SPOOFED
in 72_active.cf produces a warning).

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

bugzilla-daemon at bugzilla

Dec 7, 2009, 12:56 PM

Post #3 of 6 (450 views)
Permalink

[Bug 6241] mkrules does not understand newer options and 'else' [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6241

Justin Mason <jm [at] jmason> changed:

What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P1
CC| |jm [at] jmason

--- Comment #2 from Justin Mason <jm [at] jmason> 2009-12-07 12:56:40 UTC ---
yep, this is pretty serious brokenness.

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

bugzilla-daemon at bugzilla

Dec 16, 2009, 4:46 AM

Post #4 of 6 (384 views)
Permalink

[Bug 6241] mkrules does not understand newer options and 'else' [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6241

--- Comment #3 from Mark Martinec <Mark.Martinec [at] ijs> 2009-12-16 04:46:15 UTC ---
> yep, this is pretty serious brokenness.

Actually, not only that it does not understand a nested if.
I tried replacing nested 'if's with four independent ifs
( rulesrc/sandbox/khopesh/20_khop_bl.cf ) :

if plugin(Mail::SpamAssassin::Plugin::SPF) &&
plugin(Mail::SpamAssassin::Plugin::DKIM)
meta __NOT_SPOOFED ALL_TRUSTED || SPF_PASS || DKIM_VALID
endif
if plugin(Mail::SpamAssassin::Plugin::SPF) &&
!plugin(Mail::SpamAssassin::Plugin::DKIM)
meta __NOT_SPOOFED ALL_TRUSTED || SPF_PASS
endif
if !plugin(Mail::SpamAssassin::Plugin::SPF) &&
plugin(Mail::SpamAssassin::Plugin::DKIM)
meta __NOT_SPOOFED ALL_TRUSTED || DKIM_VALID
endif
if !plugin(Mail::SpamAssassin::Plugin::SPF) &&
!plugin(Mail::SpamAssassin::Plugin::DKIM)
# Neither DKIM nor SPF ... ugh.
meta __NOT_SPOOFED ALL_TRUSTED
endif
tflags __NOT_SPOOFED nice

and the:
perl build/mkrules --exit_on_no_src --src rulesrc --out rules \
--manifest MANIFEST --manifestskip MANIFEST.SKIP
produced the following single 'if' in rules/72_active.cf:

if plugin(Mail::SpamAssassin::Plugin::SPF) &&
plugin(Mail::SpamAssassin::Plugin::DKIM)
meta __NOT_SPOOFED ALL_TRUSTED || SPF_PASS || DKIM_VALID
meta __NOT_SPOOFED ALL_TRUSTED || SPF_PASS
meta __NOT_SPOOFED ALL_TRUSTED || DKIM_VALID
meta __NOT_SPOOFED ALL_TRUSTED
tflags __NOT_SPOOFED nice
endif

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

bugzilla-daemon at bugzilla

Dec 16, 2009, 5:05 AM

Post #5 of 6 (388 views)
Permalink

[Bug 6241] mkrules does not understand newer options and 'else' [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6241

--- Comment #4 from Mark Martinec <Mark.Martinec [at] ijs> 2009-12-16 05:05:06 UTC ---
20_khop_bl.cf Bug 6241: comment out complex 'if's to work
around a deficiency in mkrules (may be restored when fixed);
20_khop_bl.cf Bug 6258: replace DKIM_VERIFIED with DKIM_VALID
to avoid a warning: "rules: meta test __NOT_SPOOFED has
dependency 'DKIM_VERIFIED' with a zero score"
Sending lib/Mail/SpamAssassin/Timeout.pm
Sending rulesrc/sandbox/khopesh/20_khop_bl.cf
Sending t/timeout.t
Committed revision 891224.

oops, submitted too many files, reverting Timeout.pm and t/timeout.t
Sending lib/Mail/SpamAssassin/Timeout.pm
Sending t/timeout.t
Committed revision 891227.

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

bugzilla-daemon at bugzilla

Dec 16, 2009, 5:09 AM

Post #6 of 6 (387 views)
Permalink

[Bug 6241] mkrules does not understand newer options and 'else' [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6241

Mark Martinec <Mark.Martinec [at] ijs> changed:

What |Removed |Added
----------------------------------------------------------------------------
Priority|P1 |P2

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads