Mailing List Archive: SpamAssassin: devel

[Bug 6246] [review] 3.3.0 beta1/SVN fails make test if Mail::DKIM is not 0.36_5 or higher

Index | Next | Previous | View Threaded

bugzilla-daemon at bugzilla

Dec 15, 2009, 6:25 AM

Post #1 of 10 (754 views)
Permalink

[Bug 6246] [review] 3.3.0 beta1/SVN fails make test if Mail::DKIM is not 0.36_5 or higher

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6246

Mark Martinec <Mark.Martinec [at] ijs> changed:

What |Removed |Added
----------------------------------------------------------------------------
Summary|3.3.0 beta1/SVN fails make |[review] 3.3.0 beta1/SVN
|test if Mail::DKIM is not |fails make test if
|0.36_5 or higher |Mail::DKIM is not 0.36_5 or
| |higher
Status Whiteboard| |needs 2 votes

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

bugzilla-daemon at bugzilla

Dec 15, 2009, 6:53 AM

Post #2 of 10 (733 views)
Permalink

[Bug 6246] [review] 3.3.0 beta1/SVN fails make test if Mail::DKIM is not 0.36_5 or higher [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6246

--- Comment #14 from Justin Mason <jm [at] jmason> 2009-12-15 06:53:29 UTC ---
Mark, can you attach that as a patch, for review? it's hard to tell what's
changed with a totally new replacement file.

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

bugzilla-daemon at bugzilla

Dec 15, 2009, 7:18 AM

Post #3 of 10 (730 views)
Permalink

[Bug 6246] [review] 3.3.0 beta1/SVN fails make test if Mail::DKIM is not 0.36_5 or higher [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6246

--- Comment #15 from Mark Martinec <Mark.Martinec [at] ijs> 2009-12-15 07:18:33 UTC ---
Created an attachment (id=4599)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4599)
proposed patch

Here it is as a patch. Btw, changes of a version '0.00' to 0
is because a string '0.00' is treated as true in perl.

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

bugzilla-daemon at bugzilla

Dec 15, 2009, 7:39 AM

Post #4 of 10 (738 views)
Permalink

[Bug 6246] [review] 3.3.0 beta1/SVN fails make test if Mail::DKIM is not 0.36_5 or higher [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6246

--- Comment #16 from Warren Togami <wtogami [at] redhat> 2009-12-15 07:39:44 UTC ---
Can we say 0.37 instead of 0.36_5 everywhere? 0.36_5 didn't exist as the newer
version for very long, and it doesn't universally work in all version
comparison algorithms. We can confuse users a less to just say 0.37.

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

bugzilla-daemon at bugzilla

Dec 15, 2009, 7:43 AM

Post #5 of 10 (736 views)
Permalink

[Bug 6246] [review] 3.3.0 beta1/SVN fails make test if Mail::DKIM is not 0.36_5 or higher [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6246

--- Comment #17 from Mark Martinec <Mark.Martinec [at] ijs> 2009-12-15 07:43:29 UTC ---
> Can we say 0.37 instead of 0.36_5 everywhere? 0.36_5 didn't exist as the newer
> version for very long, and it doesn't universally work in all version
> comparison algorithms. We can confuse users a less to just say 0.37.

Agreed. The 0.37 has now been available sufficiently long,
so that there is no longer a need to refer to its beta versions.

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

bugzilla-daemon at bugzilla

Dec 15, 2009, 8:43 AM

Post #6 of 10 (725 views)
Permalink

[Bug 6246] [review] 3.3.0 beta1/SVN fails make test if Mail::DKIM is not 0.36_5 or higher [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6246

Justin Mason <jm [at] jmason> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 2 votes |needs 1 votes

--- Comment #18 from Justin Mason <jm [at] jmason> 2009-12-15 08:43:51 UTC ---
+1 looks great

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

bugzilla-daemon at bugzilla

Dec 16, 2009, 3:49 AM

Post #7 of 10 (704 views)
Permalink

[Bug 6246] [review] 3.3.0 beta1/SVN fails make test if Mail::DKIM is not 0.36_5 or higher [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6246

--- Comment #19 from Mark Martinec <Mark.Martinec [at] ijs> 2009-12-16 03:49:38 UTC ---
One more vote please.

(assuming the:
domain signature. Version 0.36_5 or later is needed to fully support ADSP.
will be replaced by:
domain signature. Version 0.37 or later is needed to fully support ADSP.
as per comment Comment 16 and 17)

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

bugzilla-daemon at bugzilla

Dec 16, 2009, 3:51 AM

Post #8 of 10 (700 views)
Permalink

[Bug 6246] [review] 3.3.0 beta1/SVN fails make test if Mail::DKIM is not 0.36_5 or higher [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6246

AXB <alex.uribl [at] gmail> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |alex.uribl [at] gmail

--- Comment #20 from AXB <alex.uribl [at] gmail> 2009-12-16 03:51:54 UTC ---
+1

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

bugzilla-daemon at bugzilla

Dec 16, 2009, 4:04 AM

Post #9 of 10 (700 views)
Permalink

[Bug 6246] [review] 3.3.0 beta1/SVN fails make test if Mail::DKIM is not 0.36_5 or higher [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6246

--- Comment #21 from Mark Martinec <Mark.Martinec [at] ijs> 2009-12-16 04:04:58 UTC ---
Thanks for a review!

Bug 6246: let DependencyInfo.pm understand a concept of
recommended module version, besides a required version;
polish reporting, esp. in view of Mail::DKIM dependencies
Sending lib/Mail/SpamAssassin/Util/DependencyInfo.pm
Sending t/dkim2.t
Committed revision 891207.

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

bugzilla-daemon at bugzilla

Dec 16, 2009, 4:27 AM

Post #10 of 10 (698 views)
Permalink

[Bug 6246] [review] 3.3.0 beta1/SVN fails make test if Mail::DKIM is not 0.36_5 or higher [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6246

Mark Martinec <Mark.Martinec [at] ijs> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Platform|Other |All
Resolution| |FIXED
Status Whiteboard|needs 1 votes |

--- Comment #22 from Mark Martinec <Mark.Martinec [at] ijs> 2009-12-16 04:27:17 UTC ---
resolved, closing

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads