Mailing List Archive: SpamAssassin: devel

[Bug 6214] compiled body rules doesnt match

Index | Next | Previous | View Threaded

bugzilla-daemon at bugzilla

Nov 9, 2009, 10:25 AM

Post #1 of 4 (456 views)
Permalink

[Bug 6214] compiled body rules doesnt match

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6214

Mark Martinec <Mark.Martinec [at] ijs> changed:

What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P1

--- Comment #6 from Mark Martinec <Mark.Martinec [at] ijs> 2009-11-09 10:25:19 UTC ---
I can reproduce the problem revealed by test in Comment 4, but I don't know
enough about compiled rules to help here (I don't use it here, not worth the
trouble imo). Bumping up priority.

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

bugzilla-daemon at bugzilla

Nov 14, 2009, 4:38 PM

Post #2 of 4 (391 views)
Permalink

[Bug 6214] compiled body rules doesnt match [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6214

--- Comment #7 from Justin Mason <jm [at] jmason> 2009-11-14 16:38:40 UTC ---
Created an attachment (id=4574)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4574)
t script demonstrating the bug

I _think_ this t script should be passing, if sa-compile is working in trunk.
right now it fails for me :(

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

bugzilla-daemon at bugzilla

Nov 16, 2009, 4:12 PM

Post #3 of 4 (377 views)
Permalink

[Bug 6214] compiled body rules doesnt match [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6214

Justin Mason <jm [at] jmason> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED

--- Comment #8 from Justin Mason <jm [at] jmason> 2009-11-16 16:12:30 UTC ---
yep -- there was a bug there alright. The fix from bug 6060 was incomplete,
and didn't work for one-line body rules (as used by sa-compiled rulesets);
hence sa-compiled rules were all missing their hits. We would have spotted
that sooner if I'd been careful enough to add an end-to-end sa-compile test in
the first place :(

Anyway, here's the fix:

: 382...; svn commit -m "bug 6214: sa-compile broken by change from bug 6060,
fix (and add test)"
Sending .
Sending MANIFEST
Sending lib/Mail/SpamAssassin/Plugin/OneLineBodyRuleType.pm
Adding t/sa_compile.t
Adding xt/50_sa_compile.t
Transmitting file data ....
Committed revision 881065.

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

bugzilla-daemon at bugzilla

Nov 16, 2009, 6:32 PM

Post #4 of 4 (376 views)
Permalink

[Bug 6214] compiled body rules doesnt match [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6214

--- Comment #9 from Mark Martinec <Mark.Martinec [at] ijs> 2009-11-16 18:32:29 UTC ---
> yep -- there was a bug there alright. The fix from bug 6060 was incomplete,
> and didn't work for one-line body rules (as used by sa-compiled rulesets);

Mea culpa, thanks for finding the missing parameter!

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads