Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: SpamAssassin: devel

[Bug 6200] Replace use of Digest::SHA1 by Digest::SHA

 

 

SpamAssassin devel RSS feed   Index | Next | Previous | View Threaded


bugzilla-daemon at bugzilla

Oct 16, 2009, 8:39 AM

Post #1 of 1 (270 views)
Permalink
[Bug 6200] Replace use of Digest::SHA1 by Digest::SHA

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6200

--- Comment #3 from Mark Martinec <Mark.Martinec [at] ijs> 2009-10-16 08:39:41 UTC ---
So, how about replacing the existing:

use Digest::SHA1 qw(sha1);

with:

BEGIN {
eval { require Digest::SHA1; import Digest::SHA1 qw(sha1); 1 }
or do { require Digest::SHA; import Digest::SHA qw(sha1) }
}


(or the other way around, trying SHA first and falling back to SHA1)


This way we could lose hard dependency on Digest::SHA1 (which is not a
base module), but retain compatibility with sites which will disable
the DKIM plugin and refuse to install Digest::SHA on pre-10.0 perls.

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

SpamAssassin devel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.