bugzilla-daemon at bugzilla
Oct 15, 2009, 10:09 AM
Post #4 of 10
(820 views)
Permalink
|
|
[Bug 6218] spamd input delimiter $/ can be corrupt by a tainted error in a plugin
[In reply to]
|
|
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6218
Mark Martinec <Mark.Martinec [at] ijs> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P5 |P3
Platform|Other |All
Target Milestone|Undefined |3.3.0
--- Comment #3 from Mark Martinec <Mark.Martinec [at] ijs> 2009-10-15 10:09:04 UTC ---
> Created an attachment (id=4549)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4549) [details]
> Patch to avoid definitive $/ corruption
I don't think spamd is the right place to fix this problem. If some
underlying module leaves a global $/ changed, this can wreak havoc
in places much earlier than in the top-level spamd code, so it
should be fixed as close as possible to the source of trouble.
The solution is a: local($/) in places where it is likely that
an underlying module would change the $/ .
I know that Razor agents used to do it, and there is some workaround
code for this in Dns.pm, although again I think the fix belongs to
the Razor plugin (and not to Dns.pm) in that particular case.
Perhaps all calls to plugin methods should be prefixed by a local($/),
although this is a bit drastic approach. It would be nice to locate
the source of the $/ change in your particular case, and at least
fix that. Any chance you could track this down?
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
|
