Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: SpamAssassin: devel

[Bug 6136] [review] Add multipass to ReplaceTags plugin

 

 

SpamAssassin devel RSS feed   Index | Next | Previous | View Threaded


bugzilla-daemon at bugzilla

Jun 30, 2009, 3:35 PM

Post #1 of 6 (281 views)
Permalink
[Bug 6136] [review] Add multipass to ReplaceTags plugin

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6136


Justin Mason <jm[at]jmason.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Summary|Add multipass to |[review] Add multipass to
|ReplaceTags plugin |ReplaceTags plugin
Status Whiteboard| |needs 1 vote




--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


bugzilla-daemon at bugzilla

Jun 30, 2009, 6:21 PM

Post #2 of 6 (258 views)
Permalink
[Bug 6136] [review] Add multipass to ReplaceTags plugin [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6136


Sidney Markowitz <sidney[at]sidney.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 1 vote |ready to commit




--- Comment #3 from Sidney Markowitz <sidney[at]sidney.com> 2009-06-30 18:21:41 PST ---
+1 for committing the second patch (which appears to be the intention)

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


bugzilla-daemon at bugzilla

Jul 1, 2009, 1:41 AM

Post #3 of 6 (255 views)
Permalink
[Bug 6136] [review] Add multipass to ReplaceTags plugin [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6136





--- Comment #4 from Justin Mason <jm[at]jmason.org> 2009-07-01 01:41:29 PST ---
yeah, to clarify, I was referring to whichever one John wants to apply; I
presume that'll probably be the second patch, since I agree that appears to be
the intention.

go ahead John -- you've got the votes ;)

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


bugzilla-daemon at bugzilla

Jul 1, 2009, 8:48 PM

Post #4 of 6 (245 views)
Permalink
[Bug 6136] [review] Add multipass to ReplaceTags plugin [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6136





--- Comment #5 from John Hardin <jhardin[at]impsec.org> 2009-07-01 20:48:08 PST ---
I've been running the patched trunk (3.3) ReplaceTags.pm on my live and testing
3.2.5 installs without any obvious problems. Apart from the multipass change
here's the diff between 3.2 and 3.3:

--- branches/3.2/lib/Mail/SpamAssassin/Plugin/ReplaceTags.pm 2009-07-01
20:41:35.000000000 -0700
+++ trunk/lib/Mail/SpamAssassin/Plugin/ReplaceTags.pm 2009-07-01
20:42:16.000000000 -0700
@@ -56,6 +56,7 @@
use strict;
use warnings;
use bytes;
+use re 'taint';

use vars qw(@ISA);
@ISA = qw(Mail::SpamAssassin::Plugin);
@@ -179,7 +180,7 @@

sub set_config {
my ($self, $conf) = @_;
- my @cmds = ();
+ my @cmds;

=head1 RULE DEFINITIONS AND PRIVILEGED SETTINGS


...those don't look substantive. Should I just go ahead and copy ReplaceTags.pm
in toto from trunk to 3.2?

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


bugzilla-daemon at bugzilla

Jul 2, 2009, 12:39 AM

Post #5 of 6 (238 views)
Permalink
[Bug 6136] [review] Add multipass to ReplaceTags plugin [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6136





--- Comment #6 from Justin Mason <jm[at]jmason.org> 2009-07-02 00:39:10 PST ---
I would stick with patching it, instead of copying in toto; I'm not sure what
all the side-effects of "use re 'taint'" would be.

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


bugzilla-daemon at bugzilla

Jul 2, 2009, 2:51 AM

Post #6 of 6 (235 views)
Permalink
[Bug 6136] [review] Add multipass to ReplaceTags plugin [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6136





--- Comment #7 from Mark Martinec <Mark.Martinec[at]ijs.si> 2009-07-02 02:51:41 PST ---
> I would stick with patching it, instead of copying in toto; I'm not sure what
> all the side-effects of "use re 'taint'" would be.

I agree. The use re 'taint' is probably harmless, but as it hasn't
been applied to other modules in 3.2, it is probably better
not to do it here. The other one is just cosmetic, removes
redundant assignment, no need to backport it, but you may
if you like it.

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

SpamAssassin devel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact lists@gossamer-threads.com
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.