Mailing List Archive: SpamAssassin: devel

[Bug 5948] uninitialized value within @pristine_headers PerMsgStatus.pm line 832

Index | Next | Previous | View Threaded

bugzilla-daemon at bugzilla

Jun 30, 2009, 3:11 AM

Post #1 of 3 (221 views)
Permalink

[Bug 5948] uninitialized value within @pristine_headers PerMsgStatus.pm line 832

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5948

Justin Mason <jm [at] jmason> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |INVALID

--- Comment #2 from Justin Mason <jm [at] jmason> 2009-06-30 03:10:59 PST ---
resolving due to lack of followup

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

bugzilla-daemon at bugzilla

Jun 30, 2009, 3:29 AM

Post #2 of 3 (189 views)
Permalink

[Bug 5948] uninitialized value within @pristine_headers PerMsgStatus.pm line 832 [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5948

Mark Martinec <Mark.Martinec [at] ijs> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|INVALID |FIXED

--- Comment #3 from Mark Martinec <Mark.Martinec [at] ijs> 2009-06-30 03:29:51 PST ---
> resolving due to lack of followup

Actually, I think its a good defensive programming suggestion, even in the
absence of evidence. I'm putting the change in (complain if somone disagrees).

defensive programming - avoid a warning, Bug 5948
Sending lib/Mail/SpamAssassin/PerMsgStatus.pm
Committed revision 789655 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=789655 ).

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

bugzilla-daemon at bugzilla

Jun 30, 2009, 1:05 PM

Post #3 of 3 (185 views)
Permalink

[Bug 5948] uninitialized value within @pristine_headers PerMsgStatus.pm line 832 [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5948

--- Comment #4 from Theo Van Dinter <felicity [at] apache> 2009-06-30 13:05:32 PST ---
I can see the argument, but at the same time, as far as I can see,
get_pristine_header() will always return something, "" if there are no headers,
which gets split into a single array element, and so this issue should never
occur with $array[$#array].

Adding in a check to see if there are elements, when there should always be at
least 1 element, just slows down the code.

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads