Mailing List Archive: SpamAssassin: devel

[Bug 6131] Makefile.PL is doing evil things to detect DESTDIR

Index | Next | Previous | View Threaded

bugzilla-daemon at bugzilla

Jun 25, 2009, 2:02 PM

Post #1 of 7 (487 views)
Permalink

[Bug 6131] Makefile.PL is doing evil things to detect DESTDIR

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6131

Justin Mason <jm [at] jmason> changed:

What |Removed |Added
----------------------------------------------------------------------------
Priority|P5 |P2

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

bugzilla-daemon at bugzilla

Jun 29, 2009, 4:19 AM

Post #2 of 7 (435 views)
Permalink

[Bug 6131] Makefile.PL is doing evil things to detect DESTDIR [In reply to]

bugzilla-daemon at bugzilla

Jun 30, 2009, 9:21 AM

Post #3 of 7 (424 views)
Permalink

[Bug 6131] Makefile.PL is doing evil things to detect DESTDIR [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6131

--- Comment #10 from Justin Mason <jm [at] jmason> 2009-06-30 09:21:41 PST ---
ok, first draft:

http://taint.org/x/2009/bug6131.part1.patch

look sensible?

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

bugzilla-daemon at bugzilla

Jun 30, 2009, 10:35 AM

Post #4 of 7 (421 views)
Permalink

[Bug 6131] Makefile.PL is doing evil things to detect DESTDIR [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6131

--- Comment #11 from Mark Martinec <Mark.Martinec [at] ijs> 2009-06-30 10:35:20 PST ---
> ok, first draft:
> http://taint.org/x/2009/bug6131.part1.patch
> look sensible?

Lots of deletions, good!

Applies cleanly, works out of the box for me, examining the patch
looks fine to me, although I'm not too intimate with Makefile.PL.

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

bugzilla-daemon at bugzilla

Jun 30, 2009, 3:04 PM

Post #5 of 7 (420 views)
Permalink

[Bug 6131] Makefile.PL is doing evil things to detect DESTDIR [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6131

--- Comment #12 from Justin Mason <jm [at] jmason> 2009-06-30 15:04:38 PST ---
: 649...; svn commit -m "bug 6131: simplify Makefile.PL and fix a bug in
DESTDIR support by increasing the minimum ExtUtils::MakeMaker version required
to 6.17" Makefile.PL
Sending Makefile.PL
Transmitting file data .
Committed revision 789978 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=789978 ).

I think this still may need a review to check if the PACKAGING file is still
right...

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

bugzilla-daemon at bugzilla

Jul 1, 2009, 1:55 AM

Post #6 of 7 (409 views)
Permalink

[Bug 6131] Makefile.PL is doing evil things to detect DESTDIR [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6131

--- Comment #13 from Justin Mason <jm [at] jmason> 2009-07-01 01:55:11 PST ---
actually, more than that, I'm going to write some tests for this. should be
easily testable

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

bugzilla-daemon at bugzilla

Jul 2, 2009, 3:49 PM

Post #7 of 7 (385 views)
Permalink

[Bug 6131] Makefile.PL is doing evil things to detect DESTDIR [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6131

Justin Mason <jm [at] jmason> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED

--- Comment #14 from Justin Mason <jm [at] jmason> 2009-07-02 15:49:58 PST ---

: 186...; svn commit -m "bug 6131: add test suite for Makefile.PL parameters" t
MANIFEST
Sending t/SATest.pm
Adding t/make_install.t
Transmitting file data ..
Committed revision 790753 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=790753 ).

(that t file is SVN-only btw.)

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads