Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: SpamAssassin: devel

[Bug 6132] FreeMail plugin

 

 

SpamAssassin devel RSS feed   Index | Next | Previous | View Threaded


bugzilla-daemon at bugzilla

Jun 10, 2009, 5:10 AM

Post #1 of 18 (1690 views)
Permalink
[Bug 6132] FreeMail plugin

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6132


Justin Mason <jm [at] jmason> changed:

What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|Undefined |3.3.0




--- Comment #1 from Justin Mason <jm [at] jmason> 2009-06-10 05:09:59 PST ---
great news! setting milestone for the 3.3.0 release. I don't have the time to
respond or check it in right now but I'll come back to it rsn assuming nobody
else does....

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


bugzilla-daemon at bugzilla

Jun 10, 2009, 5:10 AM

Post #2 of 18 (1641 views)
Permalink
[Bug 6132] FreeMail plugin [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6132


Justin Mason <jm [at] jmason> changed:

What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P2




--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


bugzilla-daemon at bugzilla

Jun 10, 2009, 8:10 AM

Post #3 of 18 (1640 views)
Permalink
[Bug 6132] FreeMail plugin [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6132





--- Comment #2 from Karsten Bräckelmann <guenther [at] rudersport> 2009-06-10 08:10:12 PST ---
Didn't actually run any debugging, just poking at the code for some review, but
there's a problem with the whitelisting in parse_config().

if ($opts->{key} eq "freemail_whitelist") {
foreach my $temp (split(/\s+/, $opts->{value})) {
my $value = lc($temp);
if ($temp =~ /\w[.@]\w/i) {
$self->{freemail_domains}{$value} = 1;
}

I believe that should be freemail_whitelist instead of freemail_domain here.
Oh, and for consistency, you should match $value against the RE. ;)

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


bugzilla-daemon at bugzilla

Jun 10, 2009, 8:53 AM

Post #4 of 18 (1643 views)
Permalink
[Bug 6132] FreeMail plugin [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6132





--- Comment #3 from Henrik Krohns <hege [at] hege> 2009-06-10 08:53:45 PST ---
Right, fixed for 2.001 ;)

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


bugzilla-daemon at bugzilla

Jun 11, 2009, 2:32 PM

Post #5 of 18 (1626 views)
Permalink
[Bug 6132] FreeMail plugin [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6132





--- Comment #4 from Justin Mason <jm [at] jmason> 2009-06-11 14:32:53 PST ---
cool. checked in:

: 71...; svn commit -m "bug 6132: add the FreeMail ruleset and plugin for
testing, as requested. thanks to Henrik Krohns" rulesrc/sandbox/hege
Adding rulesrc/sandbox/hege
Adding rulesrc/sandbox/hege/20_FreeMail_domains.cf
Adding rulesrc/sandbox/hege/20_FreeMail_mass.cf
Adding rulesrc/sandbox/hege/FreeMail.pm
Transmitting file data ...
Committed revision 783928 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=783928 ).

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


bugzilla-daemon at bugzilla

Jun 11, 2009, 2:34 PM

Post #6 of 18 (1615 views)
Permalink
[Bug 6132] FreeMail plugin [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6132





--- Comment #5 from Justin Mason <jm [at] jmason> 2009-06-11 14:34:14 PST ---
Created an attachment (id=4461)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4461)
test mail, should fire T_FREEMAIL_FROM

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


bugzilla-daemon at bugzilla

Jun 11, 2009, 2:35 PM

Post #7 of 18 (1627 views)
Permalink
[Bug 6132] FreeMail plugin [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6132





--- Comment #6 from Justin Mason <jm [at] jmason> 2009-06-11 14:35:25 PST ---
oh, btw:

'Or could I
have my own sandbox where I can test it (have some other rules also..)?'

I've checked it in under your name -- if you're interested, I'd be happy to
start the SVN account creation process?

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


bugzilla-daemon at bugzilla

Jun 11, 2009, 4:12 PM

Post #8 of 18 (1626 views)
Permalink
[Bug 6132] FreeMail plugin [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6132





--- Comment #7 from Justin Mason <jm [at] jmason> 2009-06-11 16:12:39 PST ---
btw there appears to be some issue in recreating the Mail::Spamassassin object,
t/recreate.t is now failing with:

t/recreate....ok 1/9rules: failed to run T_FREEMAIL_FROM_END_DIGIT test,
skipping:
(Can't locate object method "check_freemail_from" via package
"Mail::SpamAssassin::PerMsgStatus" at (eval 900) line 194.
)
rules: failed to run __freemail_reply test, skipping:
(Can't locate object method "check_freemail_replyto" via package
"Mail::SpamAssassin::PerMsgStatus" at (eval 900) line 239.
)
rules: failed to run T_FREEMAIL_SUBJECT test, skipping:
(Can't locate object method "check_freemail_header" via package
"Mail::SpamAssassin::PerMsgStatus" at (eval 900) line 684.
)
rules: failed to run __freemail_replyto test, skipping:
(Can't locate object method "check_freemail_replyto" via package
"Mail::SpamAssassin::PerMsgStatus" at (eval 900) line 1004.
)
rules: failed to run __freemail_hdr_replyto test, skipping:
(Can't locate object method "check_freemail_header" via package
"Mail::SpamAssassin::PerMsgStatus" at (eval 900) line 1224.
)
rules: failed to run T_FREEMAIL_FROM test, skipping:
(Can't locate object method "check_freemail_from" via package
"Mail::SpamAssassin::PerMsgStatus" at (eval 900) line 1494.
)
t/recreate....ok 3/9plugin: failed to parse plugin
/home/jm/ftp/sa/trunk/t/../t/log/test_rules_copy/EmailBL.pm: Can't locate
/home/jm/ftp/sa/trunk/t/../t/log/test_rules_copy/EmailBL.pm in @INC (@INC
contains: ../blib/lib t . /home/jm/ftp/sa/trunk/blib/lib
/home/jm/ftp/sa/trunk/blib/arch /etc/perl /usr/local/lib/perl/5.10.0
/usr/local/share/perl/5.10.0 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.10
/usr/share/perl/5.10 /usr/local/lib/site_perl) at
../blib/lib/Mail/SpamAssassin/PluginHandler.pm line 108.

[ignored warning, not recreate-related]
plugin: failed to parse plugin
/home/jm/ftp/sa/trunk/t/../t/log/test_rules_copy/sandbox-hstern.pm: Can't
locate /home/jm/ftp/sa/trunk/t/../t/log/test_rules_copy/sandbox-hstern.pm in
@INC (@INC contains: ../blib/lib t . /home/jm/ftp/sa/trunk/blib/lib
/home/jm/ftp/sa/trunk/blib/arch /etc/perl /usr/local/lib/perl/5.10.0
/usr/local/share/perl/5.10.0 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.10
/usr/share/perl/5.10 /usr/local/lib/site_perl) at
../blib/lib/Mail/SpamAssassin/PluginHandler.pm line 108.

[ignored warning, not recreate-related]
plugin: failed to parse plugin
/home/jm/ftp/sa/trunk/t/../t/log/test_rules_copy/FreeMail.pm: Can't locate
/home/jm/ftp/sa/trunk/t/../t/log/test_rules_copy/FreeMail.pm in @INC (@INC
contains: ../blib/lib t . /home/jm/ftp/sa/trunk/blib/lib
/home/jm/ftp/sa/trunk/blib/arch /etc/perl /usr/local/lib/perl/5.10.0
/usr/local/share/perl/5.10.0 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.10
/usr/share/perl/5.10 /usr/local/lib/site_perl) at
../blib/lib/Mail/SpamAssassin/PluginHandler.pm line 108.

[ignored warning, not recreate-related]
t/recreate....ok 5/9rules: failed to run T_FREEMAIL_FROM_END_DIGIT test,
skipping:
(Can't locate object method "check_freemail_from" via package
"Mail::SpamAssassin::PerMsgStatus" at (eval 1856) line 194.
)
rules: failed to run __freemail_reply test, skipping:
(Can't locate object method "check_freemail_replyto" via package
"Mail::SpamAssassin::PerMsgStatus" at (eval 1856) line 239.
)
rules: failed to run T_FREEMAIL_SUBJECT test, skipping:
(Can't locate object method "check_freemail_header" via package
"Mail::SpamAssassin::PerMsgStatus" at (eval 1856) line 684.
)
rules: failed to run __freemail_replyto test, skipping:
(Can't locate object method "check_freemail_replyto" via package
"Mail::SpamAssassin::PerMsgStatus" at (eval 1856) line 1004.
)
rules: failed to run __freemail_hdr_replyto test, skipping:
(Can't locate object method "check_freemail_header" via package
"Mail::SpamAssassin::PerMsgStatus" at (eval 1856) line 1224.
)
rules: failed to run T_FREEMAIL_FROM test, skipping:
(Can't locate object method "check_freemail_from" via package
"Mail::SpamAssassin::PerMsgStatus" at (eval 1856) line 1494.
)
t/recreate....NOK 9/9# Failed test 9 in t/recreate.t at line 90
t/recreate....FAILED test 9
Failed 1/9 tests, 88.89% okay
Failed Test Stat Wstat Total Fail List of Failed
-------------------------------------------------------------------------------
t/recreate.t 9 1 9
Failed 1/1 test scripts. 1/9 subtests failed.
Files=1, Tests=9, 3 wallclock secs ( 2.50 cusr + 0.10 csys = 2.60 CPU)
Failed 1/1 test programs. 1/9 subtests failed.
make: *** [test_dynamic] Error 255


I would guess there might be some kind of plugin lifecycle bug there...

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


bugzilla-daemon at bugzilla

Jun 11, 2009, 4:33 PM

Post #9 of 18 (1611 views)
Permalink
[Bug 6132] FreeMail plugin [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6132





--- Comment #8 from Karsten Bräckelmann <guenther [at] rudersport> 2009-06-11 16:33:28 PST ---
The checkin from revision 783928 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=783928 ) has the loadplugin line in
20_FreeMail_mass.cf, which lexicographically comes *after*
20_FreeMail_domains.cf.

The ifplugin in the latter will pretty much disable the plugin, cause there are
no freemail_domain's loaded. Might also explain that recreation failure?

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


bugzilla-daemon at bugzilla

Jun 12, 2009, 8:49 AM

Post #10 of 18 (1607 views)
Permalink
[Bug 6132] FreeMail plugin [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6132





--- Comment #9 from Justin Mason <jm [at] jmason> 2009-06-12 08:49:03 PST ---
(In reply to comment #8)
> The checkin from revision 783928 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=783928 ) has the loadplugin line in
> 20_FreeMail_mass.cf, which lexicographically comes *after*
> 20_FreeMail_domains.cf.
>
> The ifplugin in the latter will pretty much disable the plugin, cause there are
> no freemail_domain's loaded. Might also explain that recreation failure?

I think the "mkrules" compilation step from "make" rearranges them.

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


bugzilla-daemon at bugzilla

Jun 19, 2009, 3:41 PM

Post #11 of 18 (1460 views)
Permalink
[Bug 6132] FreeMail plugin [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6132


Sidney Markowitz <sidney [at] sidney> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |sidney [at] sidney




--- Comment #10 from Sidney Markowitz <sidney [at] sidney> 2009-06-19 15:41:00 PST ---
*** Bug 6138 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


bugzilla-daemon at bugzilla

Jun 19, 2009, 5:23 PM

Post #12 of 18 (1462 views)
Permalink
[Bug 6132] FreeMail plugin [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6132





--- Comment #11 from Sidney Markowitz <sidney [at] sidney> 2009-06-19 17:23:39 PST ---
20_FreeMail_mass.cf had a ifplugin line commented out. That made sense because
it was immediately preceded by a loadplugin, so obviously is not needed.

Unfortunately, what is obvious is not always true. When the rules in the file
are moved out of that file into 70_sandbox.cf, the ifplugin becomes necessary
during make test when FreeMail.pm may not be available to load.

Uncommenting the ifplugin and the associated endif seems to fix the failure.

Committed revision 786732 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=786732 ).

Since I'm not familiar with this bug report as a whole, just trying to fix the
Hudson builds, could someone else decide if this is ready to be closed as
FIXED, assuming that Hudson finally stops complaining after this commit?

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


bugzilla-daemon at bugzilla

Jun 20, 2009, 3:38 AM

Post #13 of 18 (1457 views)
Permalink
[Bug 6132] FreeMail plugin [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6132


Justin Mason <jm [at] jmason> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED




--- Comment #12 from Justin Mason <jm [at] jmason> 2009-06-20 03:38:10 PST ---
I think that did it ;)

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


bugzilla-daemon at bugzilla

Jun 20, 2009, 3:39 AM

Post #14 of 18 (1454 views)
Permalink
[Bug 6132] FreeMail plugin [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6132


Justin Mason <jm [at] jmason> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |




--- Comment #13 from Justin Mason <jm [at] jmason> 2009-06-20 03:39:09 PST ---
oh wait. we got sidetracked by the t/recreate.t issue. this bug is for
discussion of the FreeMail plugin itself! reopening for that....

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


bugzilla-daemon at bugzilla

Jun 29, 2009, 4:29 AM

Post #15 of 18 (1258 views)
Permalink
[Bug 6132] FreeMail plugin [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6132





--- Comment #14 from Justin Mason <jm [at] jmason> 2009-06-29 04:29:33 PST ---
so I'd like to add the plugin, but I guess it needs a viable host for the DNS
zone first, right?

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


bugzilla-daemon at bugzilla

Jun 29, 2009, 4:35 AM

Post #16 of 18 (1268 views)
Permalink
[Bug 6132] FreeMail plugin [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6132





--- Comment #15 from AXB <alex.uribl [at] gmail> 2009-06-29 04:35:54 PST ---
(In reply to comment #14)
> so I'd like to add the plugin, but I guess it needs a viable host for the DNS
> zone first, right?

You're confusing with EmailBL

This plugin doesn't do any lookups.
Its all "static"

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


bugzilla-daemon at bugzilla

Jun 29, 2009, 4:38 AM

Post #17 of 18 (1262 views)
Permalink
[Bug 6132] FreeMail plugin [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6132





--- Comment #16 from Henrik Krohns <hege [at] hege> 2009-06-29 04:38:22 PST ---
Yeah. No DNS.

One thing is needed:

freemail_domains.cf should be distributed with sa-update, but that's no problem
right?

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


bugzilla-daemon at bugzilla

Jul 6, 2009, 9:53 AM

Post #18 of 18 (1193 views)
Permalink
[Bug 6132] FreeMail plugin [In reply to]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6132





--- Comment #17 from Justin Mason <jm [at] jmason> 2009-07-06 09:53:04 PST ---
(In reply to comment #16)
> Yeah. No DNS.

oh yeah. right, duh. ;)

> One thing is needed:
>
> freemail_domains.cf should be distributed with sa-update, but that's no problem
> right?

yep, no problem there. OK, next task is to get it into lib/Mail/SpamAssassin
with the rest of the "official" plugins etc. should be easy enough!

--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

SpamAssassin devel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.