Mailing List Archive: Request Tracker: Users

FW: Long Lines on ticket display page

Index | Next | Previous | View Threaded

c_apotla at qualcomm

Nov 25, 2009, 9:10 AM

Post #1 of 2 (379 views)
Permalink

FW: Long Lines on ticket display page

Sorry about that . It is 3.8.2 (mod_perl2) on a sun solaris machine with an Oracle Db.

Let me know if you need any other info.

Regards,
-Ashish

________________________________________
From: Jesse Vincent [jesse [at] bestpractical]
Sent: Wednesday, November 25, 2009 10:31 PM
To: Potla, Ashish Bassaliel
Cc: rt-users [at] bestpractical
Subject: Re: [rt-users] Long Lines on ticket display page

On Wed 25.Nov'09 at 3:03:05 -0800, Potla, Ashish Bassaliel wrote:
> Hello,
>
> Some bizarre things have been happening and would like to know if anyone has seen similar cases.
>
What version of RT are you folks running?

-Jesse
>
>
> 1. When a long line is in the message body, it runs off the screen.
>
> 2. Sometimes, long words, like path names are unnecessarily truncated and wrapped to the next line even though the end
> is not reached.
>
> 3. Inconsistent new lines get added to the message body(especially to indented previous messages) and keeps making the
> email longer and longer each time correspondence is added to it.
>
>
>
> Please help me out!
>
>
>
> Thank you,
>
> -Ashish
>

> _______________________________________________
> http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-users
>
> Community help: http://wiki.bestpractical.com
> Commercial support: sales [at] bestpractical
>
>
> Discover RT's hidden secrets with RT Essentials from O'Reilly Media.
> Buy a copy at http://rtbook.bestpractical.com
_______________________________________________
http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-users

Community help: http://wiki.bestpractical.com
Commercial support: sales [at] bestpractical

Discover RT's hidden secrets with RT Essentials from O'Reilly Media.
Buy a copy at http://rtbook.bestpractical.com

jesse at bestpractical

Nov 25, 2009, 9:17 AM

Post #2 of 2 (336 views)
Permalink

Re: FW: Long Lines on ticket display page [In reply to]

On Wed, Nov 25, 2009 at 09:10:30AM -0800, Potla, Ashish Bassaliel wrote:
> Sorry about that . It is 3.8.2 (mod_perl2) on a sun solaris machine with an Oracle Db.
>

We've definitely made wrapping improvements in the past couple point
releases. And one since that last release:

commit 4eb846f4b7da66940f6bc479a0367d226969e99d
Author: Jesse Vincent <jesse [at] bestpractical>
Date: Fri Oct 30 14:54:21 2009 -0400

RT was accidentally injecting too many newlines when rendering plaintext messages without <pre>.

This commit fixes the regex.

diff --git a/share/html/Ticket/Elements/ShowMessageStanza b/share/html/Ticket/Elements/ShowMessageStanza
index e9b57bb..0d4fe61 100755
--- a/share/html/Ticket/Elements/ShowMessageStanza
+++ b/share/html/Ticket/Elements/ShowMessageStanza
@@ -98,7 +98,7 @@ my $print_content = sub {
$m->callback( content => $ref, %ARGS );
$m->comp('/Elements/MakeClicky', content => $ref, ticket => $ticket, %ARGS);
unless ( $plain_text_pre || $plain_text_mono ) {
- $$ref =~ s{(?=\r*\n)}{<br />}g if defined $$ref;
+ $$ref =~ s{(\r?\n)}{<br />}g if defined $$ref;
}
$m->out( $$ref );
};

_______________________________________________
http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-users

Community help: http://wiki.bestpractical.com
Commercial support: sales [at] bestpractical

Discover RT's hidden secrets with RT Essentials from O'Reilly Media.
Buy a copy at http://rtbook.bestpractical.com

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads