Mailing List Archive: Request Tracker: Devel

[Patch] Handling "0" in Custom Fields

Index | Next | Previous | View Threaded

ol at bofh

Oct 13, 2009, 7:45 AM

Post #1 of 3 (361 views)
Permalink

[Patch] Handling "0" in Custom Fields

[RT 3.8.5]

FYI,

the Ticket/Modify.html display doesn't show simple "any value" custom field value if
that "any value" happens to be "0".

Fix:

In html/Elements/EditCustomFieldFreeform

change

<input name="<%$name%>" id="<%$name%>" size="<%$Cols%>" class="CF-<%$CustomField->id%>-Edit" value="<%$Default ? $Default : ''%>" />

to

<input name="<%$name%>" id="<%$name%>" size="<%$Cols%>" class="CF-<%$CustomField->id%>-Edit" value="<%defined($Default) ? $Default : ''%>" />

/ol
--
-=- Otmar Lendl -- ol[at]bofh.priv.at -- http://lendl.priv.at/ -=-
_______________________________________________
List info: http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel

falcone at bestpractical

Oct 13, 2009, 9:26 AM

Post #2 of 3 (317 views)
Permalink

Re: [Patch] Handling "0" in Custom Fields [In reply to]

On Tue, Oct 13, 2009 at 04:45:58PM +0200, Otmar Lendl wrote:
>
> [RT 3.8.5]
>
> FYI,
>
> the Ticket/Modify.html display doesn't show simple "any value" custom field value if
> that "any value" happens to be "0".

It appears that this was already addressed in
2759e9adbc07cc9074d60f3b0aaf324bcd49a948
and a similar patch to the other half of the file was applied in
a4e5bc195b30a49d9125e948f008566899b70f9b

You may want to test 3.8.6rc1 which contains these fixes

-kevin

ol at bofh

Oct 13, 2009, 12:19 PM

Post #3 of 3 (316 views)
Permalink

Re: [Patch] Handling "0" in Custom Fields [In reply to]

Kevin Falcone wrote:
> On Tue, Oct 13, 2009 at 04:45:58PM +0200, Otmar Lendl wrote:
>> [RT 3.8.5]
>>
>> FYI,
>>
>> the Ticket/Modify.html display doesn't show simple "any value" custom field value if
>> that "any value" happens to be "0".

>
> You may want to test 3.8.6rc1 which contains these fixes
>

Actually I ignored the bug in the RT 3.4 installation which supported the
application over the last 3 years. This week I upgraded to the latest
version in Debian and found just marginal improvements regarding this
issue, thus I looked into what's missing.

Glad to hear this has already been taken care of.

/ol
--
-=- Otmar Lendl -- ol[at]bofh.priv.at -- http://lendl.priv.at/ -=-
_______________________________________________
List info: http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact lists@gossamer-threads.com