Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Request Tracker: Devel

Patch for RT-Extension-ResetPassword

 

 

Request Tracker devel RSS feed   Index | Next | Previous | View Threaded


axelilly at gmail

Jun 23, 2009, 8:24 AM

Post #1 of 3 (593 views)
Permalink
Patch for RT-Extension-ResetPassword

Please find attached a patch for RT-Extension-ResetPassword.

This patch corrects two spots that do not build links correctly.

The links now obey $RT::WebURL


--
Jason 'axelilly' Fenner
GTalk: axelilly[at]gmail.com
Attachments: RT-Extension-ResetPassword.urlfix.patch (1.49 KB)


falcone at bestpractical

Jun 23, 2009, 2:55 PM

Post #2 of 3 (535 views)
Permalink
Re: Patch for RT-Extension-ResetPassword [In reply to]

On Jun 23, 2009, at 11:24 AM, Jason Fenner wrote:

> Please find attached a patch for RT-Extension-ResetPassword.
> This patch corrects two spots that do not build links correctly.
> The links now obey $RT::WebURL

Two issues, you're interpolating RT::WebURL inside a single
quoted string which won't work, and you really want $RT::WebPath
because these are RT internal links. Take a look at the patch
I applied to:
html/Callbacks/RT-Extension-ResetPassword/Elements/Login

-kevin
_______________________________________________
List info: http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel


axelilly at gmail

Jun 24, 2009, 6:52 AM

Post #3 of 3 (528 views)
Permalink
Re: Patch for RT-Extension-ResetPassword [In reply to]

On Tue, Jun 23, 2009 at 5:55 PM, Kevin Falcone <falcone[at]bestpractical.com>wrote:

> On Jun 23, 2009, at 11:24 AM, Jason Fenner wrote:
>
> > Please find attached a patch for RT-Extension-ResetPassword.
> > This patch corrects two spots that do not build links correctly.
> > The links now obey $RT::WebURL
>
> Two issues, you're interpolating RT::WebURL inside a single
> quoted string which won't work, and you really want $RT::WebPath
> because these are RT internal links. Take a look at the patch
> I applied to:
> html/Callbacks/RT-Extension-ResetPassword/Elements/Login
>
> -kevin
> _______________________________________________
> List info:
> http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel
>

Thanks for pointing that out.

I have created a new patch with using $RT::WebPath and not interpolated
within a quoted string.


--
Jason 'axelilly' Fenner
GTalk: axelilly[at]gmail.com
Attachments: RT-Extension-ResetPassword.urlfix.2.diff (1.50 KB)

Request Tracker devel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact lists@gossamer-threads.com
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.