Mailing List Archive: Request Tracker: Devel

CGM shrink

Index | Next | Previous | View Threaded

elacour at easter-eggs

Feb 11, 2009, 1:23 AM

Post #1 of 7 (1663 views)
Permalink

CGM shrink

Dear RT hackers,

Does someone know (ruz?) which change in RT make entries that are
removed by shrink_cgm_table.pl script no longer be written to db in
3.8.x ?

(I would like to backport this on 3.6 if possible)

_______________________________________________
List info: http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel

ruslan.zakirov at gmail

Feb 11, 2009, 5:51 AM

Post #2 of 7 (1600 views)
Permalink

Re: CGM shrink [In reply to]

svk snn lib/RT/CachedGroupMember_Overlay.pm, I think it's one line
change in method Create. Ping me if you wouldn't find it.

On Wed, Feb 11, 2009 at 12:23 PM, Emmanuel Lacour
<elacour [at] easter-eggs> wrote:
>
> Dear RT hackers,
>
> Does someone know (ruz?) which change in RT make entries that are
> removed by shrink_cgm_table.pl script no longer be written to db in
> 3.8.x ?
>
> (I would like to backport this on 3.6 if possible)
>
> _______________________________________________
> List info: http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel
>

--
Best regards, Ruslan.
_______________________________________________
List info: http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel

elacour at easter-eggs

Feb 13, 2009, 7:51 AM

Post #3 of 7 (1587 views)
Permalink

Re: CGM shrink [In reply to]

On Wed, Feb 11, 2009 at 04:51:19PM +0300, Ruslan Zakirov wrote:
> svk snn lib/RT/CachedGroupMember_Overlay.pm, I think it's one line
> change in method Create. Ping me if you wouldn't find it.
>

Thanks Ruz :), seems to be this change:

@@ -148,6 +149,8 @@
}
}

+ return $id if $args{'Member'}->id == $args{'Group'}->id;
+
if ( $args{'Member'}->IsGroup() ) {
my $GroupMembers = $args{'Member'}->Object->MembersObj();
while ( my $member = $GroupMembers->Next() ) {

That will have some impact here as the cgm table contains 1232959 rows and the
shrink script removes 390419 rows :)

_______________________________________________
List info: http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel

ruslan.zakirov at gmail

Feb 13, 2009, 9:33 AM

Post #4 of 7 (1584 views)
Permalink

Re: CGM shrink [In reply to]

don't forget to analyze table after that.

On Fri, Feb 13, 2009 at 6:51 PM, Emmanuel Lacour
<elacour [at] easter-eggs> wrote:
> On Wed, Feb 11, 2009 at 04:51:19PM +0300, Ruslan Zakirov wrote:
>> svk snn lib/RT/CachedGroupMember_Overlay.pm, I think it's one line
>> change in method Create. Ping me if you wouldn't find it.
>>
>
> Thanks Ruz :), seems to be this change:
>
> @@ -148,6 +149,8 @@
> }
> }
>
> + return $id if $args{'Member'}->id == $args{'Group'}->id;
> +
> if ( $args{'Member'}->IsGroup() ) {
> my $GroupMembers = $args{'Member'}->Object->MembersObj();
> while ( my $member = $GroupMembers->Next() ) {
>
>
>
> That will have some impact here as the cgm table contains 1232959 rows and the
> shrink script removes 390419 rows :)
>
>

--
Best regards, Ruslan.
_______________________________________________
List info: http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel

elacour at easter-eggs

Feb 13, 2009, 12:46 PM

Post #5 of 7 (1581 views)
Permalink

Re: CGM shrink [In reply to]

On Fri, Feb 13, 2009 at 08:33:55PM +0300, Ruslan Zakirov wrote:
> don't forget to analyze table after that.
>

Of course :)

But on this RT, shrink of cgms has near to no effect on performances :(

_______________________________________________
List info: http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel

ruslan.zakirov at gmail

Feb 13, 2009, 12:57 PM

Post #6 of 7 (1591 views)
Permalink

Re: CGM shrink [In reply to]

ACL check should be a little bit faster and some other queries but I
don't think improvement is more than 3%. However, 1 percent here and
there and quickly it's ten and more :)

On Fri, Feb 13, 2009 at 11:46 PM, Emmanuel Lacour
<elacour [at] easter-eggs> wrote:
> On Fri, Feb 13, 2009 at 08:33:55PM +0300, Ruslan Zakirov wrote:
>> don't forget to analyze table after that.
>>
>
> Of course :)
>
> But on this RT, shrink of cgms has near to no effect on performances :(
>
>

--
Best regards, Ruslan.
_______________________________________________
List info: http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel

elacour at easter-eggs

Feb 13, 2009, 1:05 PM

Post #7 of 7 (1580 views)
Permalink

Re: CGM shrink [In reply to]

On Fri, Feb 13, 2009 at 11:57:17PM +0300, Ruslan Zakirov wrote:
> ACL check should be a little bit faster and some other queries but I
> don't think improvement is more than 3%. However, 1 percent here and
> there and quickly it's ten and more :)
>

Yes, but I looked at cleanup of CGMs because I was facing slowness issue
on "take" action and ... that's exactly the bug already discussed here:
http://rt3.fsck.com/Ticket/Display.html?id=12554 :(

Here the same query take between about 5 seconds, doing a full index
scan on CGMs, for an empty result :(

Seems far faster on Oracle 10 than 9 ...

_______________________________________________
List info: http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads