Mailing List Archive: Request Tracker: Devel

[PATCH] css/html layout cleanup

Index | Next | Previous | View Threaded

elacour at easter-eggs

Jan 11, 2009, 9:39 AM

Post #1 of 11 (1681 views)
Permalink

[PATCH] css/html layout cleanup

Dear RT hackers,

trying to resolve the following tickets, I did a first "rewrite" of RT
css/html. Goal was also to remove absolute/fixed positionning in favour
of dynamic positionning (using floats).

12437: problem with #topactions in konqueror
6823: try to make proper xhtml
12770: #nav in konqueror > 4
10079: display problem when $Showbar = 0

here is some comments of my work:

- tools in search results was not using $actions, but wrote ul/li itself
with bad positionning, so I moved it to an update of $actions in
Ticket/Elements/Tab
- 12770: was just a problem with the three "empty" <div> used between
<ul> and <li> which is not allowed, I just removed them with no side
effect it seems
- there was some curious ordering in html between page-navigation, nav,
header and quickbar, I moved them to have a simple layout: a top
"quickbar", a left "nav", a right "page" (new div, which contains
topactions, then page-navigation, then body) and a footer
- I don't think RT can be used without scrolling under less than
1024x768 screens, so I added a min-width of 76em to body to avoid
"page" to go down "nav" in case of overflow
- I leave the title (mostly ticket subject) in topactions to wrap and so
use two lines if necessary, this makes the navigation bar to go down if
needed, but seems far better to me than truncated subjects

I tested this with:

- ie6 win$
- ie7 win$
- ff2 win$
- safari win$
- ff3 GNU/Linux
- konqueror 4 GNU/Linux

12437, 12770 and 10079 seems resolved with this, there doesn't seems to
be major issues (doesn't looks worse than actually ;)).

Can you _test this_ then _report any major regression_ (with screenshots
and navigator version) before I commit this?

I now there is still some little bugs (mostly with ie6 :() and other
thinks I want to enhance, But I'm tired and prefer to commit this as
soon as possible and fix remaining issues one by one :)

PS: attached, test2.html which is the minimal layout I wanted to apply
on RT.

Attachments:

layout-cleanup.patch (16.3 KB)

test2.html (1.58 KB)

richih.mailinglist at gmail

Jan 12, 2009, 3:07 AM

Post #2 of 11 (1616 views)
Permalink

Re: [PATCH] css/html layout cleanup [In reply to]

2009/1/11 Emmanuel Lacour <elacour [at] easter-eggs>:

> Can you _test this_ then _report any major regression_ (with screenshots
> and navigator version) before I commit this?

It would probably be fastest if you provided a test RT for some time.

Richard
_______________________________________________
List info: http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel

ruslan.zakirov at gmail

Jan 12, 2009, 3:43 AM

Post #3 of 11 (1610 views)
Permalink

Re: [PATCH] css/html layout cleanup [In reply to]

2009/1/11 Emmanuel Lacour <elacour [at] easter-eggs>:
>
> Dear RT hackers,
>
>
> trying to resolve the following tickets, I did a first "rewrite" of RT
> css/html. Goal was also to remove absolute/fixed positionning in favour
> of dynamic positionning (using floats).
>
> 12437: problem with #topactions in konqueror
> 6823: try to make proper xhtml
> 12770: #nav in konqueror > 4
> 10079: display problem when $Showbar = 0
>
>
> here is some comments of my work:
>
> - tools in search results was not using $actions, but wrote ul/li itself
> with bad positionning, so I moved it to an update of $actions in
> Ticket/Elements/Tab
Not sure. Should look at it. May be it's related to 3.5 style.

> - 12770: was just a problem with the three "empty" <div> used between
> <ul> and <li> which is not allowed, I just removed them with no side
> effect it seems
This can go.

> - there was some curious ordering in html between page-navigation, nav,
> header and quickbar, I moved them to have a simple layout: a top
> "quickbar", a left "nav", a right "page" (new div, which contains
> topactions, then page-navigation, then body) and a footer
Jesse knowns this better.

> - I don't think RT can be used without scrolling under less than
> 1024x768 screens, so I added a min-width of 76em to body to avoid
> "page" to go down "nav" in case of overflow
Is it web2.0 only?

> - I leave the title (mostly ticket subject) in topactions to wrap and so
> use two lines if necessary, this makes the navigation bar to go down if
> needed, but seems far better to me than truncated subjects
I'm ok.

Anyway, should try with localized version. Russian is often wider a little.

>
>
> I tested this with:
>
> - ie6 win$
> - ie7 win$
> - ff2 win$
> - safari win$
> - ff3 GNU/Linux
> - konqueror 4 GNU/Linux
>
> 12437, 12770 and 10079 seems resolved with this, there doesn't seems to
> be major issues (doesn't looks worse than actually ;)).
>
> Can you _test this_ then _report any major regression_ (with screenshots
> and navigator version) before I commit this?
>
> I now there is still some little bugs (mostly with ie6 :() and other
> thinks I want to enhance, But I'm tired and prefer to commit this as
> soon as possible and fix remaining issues one by one :)

If it's improvement and as we're in earlier 3.8.3 stage then may be it
should go in (if other developers agree).

>
>
> PS: attached, test2.html which is the minimal layout I wanted to apply
> on RT.
>
> _______________________________________________
> List info: http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel
>
>

--
Best regards, Ruslan.
_______________________________________________
List info: http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel

jesse at bestpractical

Jan 12, 2009, 5:39 AM

Post #4 of 11 (1589 views)
Permalink

Re: [PATCH] css/html layout cleanup [In reply to]

Emmanuel,

Thank you so much for all this hacking. I'd very much like to see this
get into RT. Until it's settled and IE 6 is happy, it probably makes
sense to do the work on a feature branch, just so as to not destabilize
others or cause you to block the release or a release to block you.

Once it's checked into a branch, I'm happy to try it out on rt3.fsck.com
;)

Is that reasonable?

Jesse
_______________________________________________
List info: http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel

richih.mailinglist at gmail

Jan 12, 2009, 7:20 AM

Post #5 of 11 (1608 views)
Permalink

Re: [PATCH] css/html layout cleanup [In reply to]

On Mon, Jan 12, 2009 at 14:39, Jesse Vincent <jesse [at] bestpractical> wrote:

> Once it's checked into a branch, I'm happy to try it out on rt3.fsck.com
> ;)
>
> Is that reasonable?

Assuming you were asking the list at large: Yes. Best overall solution,
imo.

Richard
_______________________________________________
List info: http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel

elacour at easter-eggs

Jan 13, 2009, 1:41 AM

Post #6 of 11 (1582 views)
Permalink

Re: [PATCH] css/html layout cleanup [In reply to]

On Mon, Jan 12, 2009 at 02:43:03PM +0300, Ruslan Zakirov wrote:
> >
> > - tools in search results was not using $actions, but wrote ul/li itself
> > with bad positionning, so I moved it to an update of $actions in
> > Ticket/Elements/Tab
> Not sure. Should look at it. May be it's related to 3.5 style.
>

Well I must admit, that I didn't touch the 3.5 style. It's already a lot
of work to have one working style ;) We can try to adapt it once web2
modification are validated.

> > - I don't think RT can be used without scrolling under less than
> > 1024x768 screens, so I added a min-width of 76em to body to avoid
> > "page" to go down "nav" in case of overflow
> Is it web2.0 only?
>

Sorry I don't understand your question here.

>
> Anyway, should try with localized version. Russian is often wider a little.
>

Kak franzusky :/

_______________________________________________
List info: http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel

elacour at easter-eggs

Jan 13, 2009, 1:42 AM

Post #7 of 11 (1589 views)
Permalink

Re: [PATCH] css/html layout cleanup [In reply to]

On Mon, Jan 12, 2009 at 08:39:36AM -0500, Jesse Vincent wrote:
>
> Emmanuel,
>
> Thank you so much for all this hacking. I'd very much like to see this
> get into RT. Until it's settled and IE 6 is happy, it probably makes
> sense to do the work on a feature branch, just so as to not destabilize
> others or cause you to block the release or a release to block you.
>
> Once it's checked into a branch, I'm happy to try it out on rt3.fsck.com
> ;)
>
> Is that reasonable?
>

Sure, and this way I can this remaining bugs before merge in trunk.

svn://svn.bestpractical.com/rt/3.8/branches/html-css-cleanup

_______________________________________________
List info: http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel

jesse at bestpractical

Jan 13, 2009, 5:57 AM

Post #8 of 11 (1591 views)
Permalink

Re: [PATCH] css/html layout cleanup [In reply to]

> svn://svn.bestpractical.com/rt/3.8/branches/html-css-cleanup

Fantastic. Thanks!

Now live on http://rt3.fsck.com?user=guest&pass=guest

And I've filed half a dozen bugs already ;)

jesse at bestpractical

Jan 13, 2009, 6:17 AM

Post #9 of 11 (1587 views)
Permalink

Re: [PATCH] css/html layout cleanup [In reply to]

On Tue, Jan 13, 2009 at 10:41:18AM +0100, Emmanuel Lacour wrote:
> On Mon, Jan 12, 2009 at 02:43:03PM +0300, Ruslan Zakirov wrote:
> > >
> > > - tools in search results was not using $actions, but wrote ul/li itself
> > > with bad positionning, so I moved it to an update of $actions in
> > > Ticket/Elements/Tab
> > Not sure. Should look at it. May be it's related to 3.5 style.
> >
>
> Well I must admit, that I didn't touch the 3.5 style. It's already a lot
> of work to have one working style ;) We can try to adapt it once web2
> modification are validated.

The existing styles should work at least as well as they currently do
before this goes into trunk. There are organizations that depend on the
older styles to be able to run RT 3.8. (So they don't need to retrain /
redo documentation). And the point of CSS is that it's at least supposed
to be possible to retheme without changing the raw html.

But yes, doing 3.5 and 3.4 compat stylesheets (and maybe giving them
names ;) once the current main theme is done makes sense.
_______________________________________________
List info: http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel

panu at colorplaza

Jan 13, 2009, 6:25 AM

Post #10 of 11 (1589 views)
Permalink

Re: [PATCH] css/html layout cleanup [In reply to]

> Until it's settled and IE 6 is happy

Just a general question.

How important is IE6 support anymore. For our environment all the people
who need to use RT we can force to use whatever browser and we are not
locked to MS/IE at all. So it's possible I can't relate to bigger
organizations requirements. Life without IE6 or lower is just so much
easier...
_______________________________________________
List info: http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel

jesse at bestpractical

Jan 13, 2009, 6:55 AM

Post #11 of 11 (1584 views)
Permalink

Re: [PATCH] css/html layout cleanup [In reply to]

On Tue, Jan 13, 2009 at 03:25:22PM +0100, Panu wrote:
> > Until it's settled and IE 6 is happy
>
> Just a general question.
>
> How important is IE6 support anymore.

Very. Many larger organizations made the decision not to jump to IE7
and/or Vista because of in-house applications that only work with IE6.

I'm pleased that my organization has an "IE6 only on development
workstations" policy, but many of my clients do not have that luxury.

Thankfully, it's pretty easy to add an IE6-only stylesheet without
hurting everyone else ;)

> For our environment all the people
> who need to use RT we can force to use whatever browser and we are not
> locked to MS/IE at all. So it's possible I can't relate to bigger
> organizations requirements. Life without IE6 or lower is just so much
> easier...
> _______________________________________________
> List info: http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel
>

--
_______________________________________________
List info: http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads