Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Request Tracker: Devel

PATCH: minor bug in Ticket/Elements/ShowHistory

 

 

Request Tracker devel RSS feed   Index | Next | Previous | View Threaded


Olly.Stephens at arm

Nov 18, 2008, 4:12 PM

Post #1 of 2 (746 views)
Permalink
PATCH: minor bug in Ticket/Elements/ShowHistory

Ticket/Elements/ShowHistory in 3.8.1 has a conditional <div> at the top
with an unconditional </div> at the bottom. This causes the tickets to
leak out of the body on the approvals summary page because the
conditions for the div aren't true so you get too many closes.

The attached [trivial] patch resolves it.

Olly

Index: share/html/Ticket/Elements/ShowHistory
===================================================================
--- share/html/Ticket/Elements/ShowHistory (revision 6360)
+++ share/html/Ticket/Elements/ShowHistory (working copy)
@@ -132,8 +132,8 @@
</div>
% if ($ShowDisplayModes or $ShowTitle) {
<& /Widgets/TitleBoxEnd &>
+</div>
% }
-</div>
<%INIT>
my $Transactions = new RT::Transactions($session{'CurrentUser'});
if ($Tickets) {

--
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
Attachments: rt-showhistory-patch.txt (0.43 KB)


elacour at easter-eggs

Nov 18, 2008, 10:49 PM

Post #2 of 2 (693 views)
Permalink
Re: PATCH: minor bug in Ticket/Elements/ShowHistory [In reply to]

On Wed, Nov 19, 2008 at 12:12:21AM -0000, Olly Stephens wrote:
> Ticket/Elements/ShowHistory in 3.8.1 has a conditional <div> at the top
> with an unconditional </div> at the bottom. This causes the tickets to
> leak out of the body on the approvals summary page because the
> conditions for the div aren't true so you get too many closes.
>

I opened a bug for you here:

http://rt3.fsck.com/Ticket/Display.html?id=12812&user=guest&pass=guest

_______________________________________________
List info: http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel

Request Tracker devel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.