sunnavy at bestpractical
Nov 4, 2009, 3:12 AM
Post #1 of 1
(93 views)
Permalink
|
|
rt branch, 3.999-trunk, updated. f49b2a60087a86c1c081f46b866a09c2c26a298a
|
|
The branch, 3.999-trunk has been updated
via f49b2a60087a86c1c081f46b866a09c2c26a298a (commit)
via 178ba632c7baba32de083c40b69321dafcfadcd7 (commit)
from af24abba9fadf5fb77a26a791f9148207be4aabb (commit)
Summary of changes:
lib/RT.pm | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
- Log -----------------------------------------------------------------
commit 178ba632c7baba32de083c40b69321dafcfadcd7
Author: sunnavy <sunnavy[at]bestpractical.com>
Date: Wed Nov 4 19:02:03 2009 +0800
no need to fiddle @INC if no plugin dir libs at all.
interesting and weird, this can erase the warning in my box when `make test`:
"Use of uninitialized value $filename in require at /opt/perl-5.10.1/lib/5.10.1/AutoLoader.pm line 28 during global destruction"
in fact, the real problem is the following line in RT::init_plugin_paths:
@INC = grep !$seen{$_}++, @tmp_inc;
if replaced with
@INC = @tmp_inc;
the warning is gone.
So, seems it's the problem of repetitive lib paths in @INC.
I have no idea why :/
diff --git a/lib/RT.pm b/lib/RT.pm
index e98ae55..c7fa142 100644
--- a/lib/RT.pm
+++ b/lib/RT.pm
@@ -264,6 +264,7 @@ sub init_plugin_paths {
my $self = shift || __PACKAGE__;
my @lib_dirs = $self->plugin_dirs('lib');
+ return unless @lib_dirs; # in case no plugins at all
my @tmp_inc;
my $local_lib = $self->local_lib_path;
commit f49b2a60087a86c1c081f46b866a09c2c26a298a
Merge: 178ba63 af24abb
Author: sunnavy <sunnavy[at]bestpractical.com>
Date: Wed Nov 4 19:10:51 2009 +0800
Merge branch '3.999-trunk' of diesel:/git/rt into 3.999-trunk
-----------------------------------------------------------------------
_______________________________________________
Rt-commit mailing list
Rt-commit[at]lists.bestpractical.com
http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-commit
|
