Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Request Tracker: Commit

rt branch, 4.0/handle-IS-vs-is, created. rt-4.0.6-254-g2ef762e

 

 

Request Tracker commit RSS feed   Index | Next | Previous | View Threaded


falcone at bestpractical

Aug 10, 2012, 4:00 PM

Post #1 of 1 (112 views)
Permalink
rt branch, 4.0/handle-IS-vs-is, created. rt-4.0.6-254-g2ef762e

The branch, 4.0/handle-IS-vs-is has been created
at 2ef762ef34a06707bbde8a5a056456c10b596a57 (commit)

- Log -----------------------------------------------------------------
commit 2ef762ef34a06707bbde8a5a056456c10b596a57
Author: Kevin Falcone <falcone [at] bestpractical>
Date: Fri Aug 10 18:59:02 2012 -0400

Make a few checks case insensitive

Otherwise, Requestor is NULL and Requestor IS NULL are not the same.

The _LinkLimit change fixes 'RefersTo is NULL'. Before, 'RefersTo is
NULL' was converted to 'RefersTo IS NOT NULL'.

diff --git a/lib/RT/Tickets.pm b/lib/RT/Tickets.pm
index 7946399..f610fb2 100644
--- a/lib/RT/Tickets.pm
+++ b/lib/RT/Tickets.pm
@@ -454,7 +454,7 @@ sub _LinkLimit {

my $is_local = 1;
if ( $is_null ) {
- $op = ($op =~ /^(=|IS)$/)? 'IS': 'IS NOT';
+ $op = ($op =~ /^(=|IS)$/i)? 'IS': 'IS NOT';
}
elsif ( $value =~ /\D/ ) {
$is_local = 0;
@@ -934,7 +934,7 @@ sub _WatcherLimit {
my $groups = $self->_RoleGroupsJoin( Type => $type, Class => $class, New => !$type );

$self->_OpenParen;
- if ( $op =~ /^IS(?: NOT)?$/ ) {
+ if ( $op =~ /^IS(?: NOT)?$/i ) {
# is [not] empty case

my $group_members = $self->_GroupMembersJoin( GroupsAlias => $groups );

-----------------------------------------------------------------------
_______________________________________________
Rt-commit mailing list
Rt-commit [at] lists
http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-commit

Request Tracker commit RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.