Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Quagga: Dev

ospfd memory leak

 

 

Quagga dev RSS feed   Index | Next | Previous | View Threaded


paul at clubi

Aug 4, 2003, 5:50 AM

Post #1 of 3 (348 views)
Permalink
ospfd memory leak

More from hasso's trawling of Marc:

http://marc.theaimsgroup.com/?l=zebra&m=102709522416331&w=4

Seems quite reasonable.

regards,
--
Paul Jakma paul [at] clubi paul [at] jakma Key ID: 64A2FF6A
warning: do not ever send email to spam [at] dishone
Fortune:
Lots of folks confuse bad management with destiny.
-- Frank Hubbard


paul at clubi

Aug 4, 2003, 10:35 AM

Post #2 of 3 (350 views)
Permalink
Re: ospfd memory leak [In reply to]

here is the patch but with:

- list (struct route).path renamed to paths - done mainly to make
sure every use caused a compile failure. (but also, list name should
be plural imo).

- ospf_route_new(): initialisation of the (struct route *)->paths
list. add list del function pointer, ospf_path_free() here - not in
middle of the code somewhere.

- ospf_route_free(): call list_delete on the paths linked list

- various: update (struct route *)->path to paths. Remove any list
initialisation or delete being done. (hopefully caught them all).

i can undo the first change, and it will be a /much/ smaller patch :)

regards,
--
Paul Jakma paul [at] clubi paul [at] jakma Key ID: 64A2FF6A
warning: do not ever send email to spam [at] dishone
Fortune:
Nature always sides with the hidden flaw.
Attachments: zebra-ospf-mem-leak2.diff (15.0 KB)


paul at clubi

Aug 4, 2003, 10:47 AM

Post #3 of 3 (350 views)
Permalink
Re: ospfd memory leak [In reply to]

one small addendum.. missed a list_new(). see attached.

regards,
--
Paul Jakma paul [at] clubi paul [at] jakma Key ID: 64A2FF6A
warning: do not ever send email to spam [at] dishone
Fortune:
Tomorrow's computers some time next month.
-- DEC
Attachments: zebra-ospf-route-list-addendum.diff (0.73 KB)

Quagga dev RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.